Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 925152 - www-client/firefox-123.0: use of undeclared identifier 'res_nquery' on musl system
Summary: www-client/firefox-123.0: use of undeclared identifier 'res_nquery' on musl s...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2024-02-21 08:27 UTC by 12101111
Modified: 2024-02-24 07:30 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
fix for musl (fix-res_nquery.patch,827 bytes, patch)
2024-02-21 08:29 UTC, 12101111 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description 12101111 2024-02-21 08:27:43 UTC 
Firefox use res_nquery which is not available for musl

See:
https://hg.mozilla.org/mozilla-central/rev/88d71cf5ea62
https://hg.mozilla.org/mozilla-central/rev/99907723d4c4

Reproducible: Always

Steps to Reproduce:
emerge "=www-client/firefox-123.0"
Actual Results:  
/tmp/portage/www-client/firefox-123.0/work/firefox-123.0/netwerk/dns/PlatformDNSUnix.cpp:36:15: error: use of undeclared identifier 'res_nquery'
   36 |         len = res_nquery(&_res, host.get(), ns_c_in,
      |               ^
Comment 1 12101111 2024-02-21 08:29:57 UTC 
Created attachment 885586 [details, diff]
fix for musl
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-02-21 08:32:10 UTC 
Chcking __RES looks suspicious.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-02-21 10:00:35 UTC 
(In reply to 12101111 from comment #3)
> https://www.openwall.com/lists/musl/2020/10/23/16

Huh, alright.
Comment 5 Joonas Niilola gentoo-dev 2024-02-22 08:05:54 UTC 
While I really can't judge the quality, does https://git.alpinelinux.org/aports/tree/community/firefox/res_nquery.patch seem better? At least I like the definitions better there.
Comment 6 hugegameartgd 2024-02-24 00:30:29 UTC 
Upstream bug report: https://bugzilla.mozilla.org/show_bug.cgi?id=1881123, fixed by https://phabricator.services.mozilla.com/D202400
Comment 7 Joonas Niilola gentoo-dev 2024-02-24 06:06:58 UTC 
Upstream patch is tagged for firefox-125 and it doesn't apply cleanly to 123. I'll add the alpine patch and keep it until 125.
Comment 8 Larry the Git Cow gentoo-dev 2024-02-24 07:30:10 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=126f123ad02ab8de5be6d7089d481d4454f11f6a

commit 126f123ad02ab8de5be6d7089d481d4454f11f6a
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2024-02-24 07:29:46 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2024-02-24 07:30:07 +0000

    www-client/firefox: fix 123.0 on musl
    
    Closes: https://bugs.gentoo.org/925152
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 www-client/firefox/Manifest             | 2 +-
 www-client/firefox/firefox-123.0.ebuild | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)