Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 925017 - gui-apps/waybar-9999 now requires and unconditionally uses gtk-layer-shell
Summary: gui-apps/waybar-9999 now requires and unconditionally uses gtk-layer-shell
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Jonas Toth
URL: https://github.com/Alexays/Waybar/pul...
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-02-19 22:26 UTC by Brett Alcox
Modified: 2024-02-26 13:04 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brett Alcox 2024-02-19 22:26:24 UTC
See PR: https://github.com/Alexays/Waybar/pull/2836 

Previously, gtk-layer-shell was only conditionally used (and in the case of Gentoo ebuild, the "popups" USE flag specifically). Because of this, gtk-layer-shell is now an unknown option provided within the Meson build.

popups is a default USE flag, so this happens almost always unless explicitly disabled (and now, even if disabled, compile will only work if you actually have gtk-layer-shell installed) 

Reproducible: Sometimes

Steps to Reproduce:
1. Emerge waybar-9999 with +popups
2. Observe 
Actual Results:  
Meson build failure due to the (now) unknown build flag "gtk-layer-shell"

Expected Results:  
To not see a build failure AND to have gtk-layer-shell not be a conditional dep 

meson setup --libdir lib64 --localstatedir /var/lib --prefix /usr --sysconfdir /etc --wrap-mode nodownload --build.pkg-config-path /usr/share/pkgconfig --pkg-config-path /usr/share/pkgconfig --native-file /var/tmp/portage/gui-apps/waybar-9999/temp/meson.x86_64-pc-linux-gnu.amd64.ini -Db_pch=false -Dwerror=false -Db_lto=false --buildtype plain -Dman-pages=enabled -Dcava=disabled -Dlibevdev=disabled -Djack=disabled -Dlibinput=enabled -Dlogind=enabled -Dmpd=disabled -Dmpris=disabled -Dlibnl=enabled -Dgtk-layer-shell=enabled -Dpulseaudio=enabled -Dwireplumber=enabled -Dsndio=disabled -Dsystemd=enabled -Dtests=disabled -Ddbusmenu-gtk=enabled -Dlibudev=enabled -Dupower_glib=enabled -Drfkill=enabled -Dexperimental=false /var/tmp/portage/gui-apps/waybar-9999/work/waybar-9999 /var/tmp/portage/gui-apps/waybar-9999/work/waybar-9999-build
The Meson build system
Version: 1.3.2
Source dir: /var/tmp/portage/gui-apps/waybar-9999/work/waybar-9999
Build dir: /var/tmp/portage/gui-apps/waybar-9999/work/waybar-9999-build
Build type: native build

meson.build:1:0: ERROR: Unknown options: "gtk-layer-shell"

A full log can be found at /var/tmp/portage/gui-apps/waybar-9999/work/waybar-9999-build/meson-logs/meson-log.txt
 * ERROR: gui-apps/waybar-9999::gentoo failed (configure phase):
 *   (no error message)
 * 
 * Call stack:
 *     ebuild.sh, line  136:  Called src_configure
 *   environment, line 2872:  Called meson_src_configure
 *   environment, line 2296:  Called die
 * The specific snippet of code:
 *       "${mesonargs[@]}" ) || die
 * 
 * If you need support, post the output of `emerge --info '=gui-apps/waybar-9999::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=gui-apps/waybar-9999::gentoo'`.
 * The complete build log is located at '/var/tmp/portage/gui-apps/waybar-9999/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/gui-apps/waybar-9999/temp/environment'.
 * Working directory: '/var/tmp/portage/gui-apps/waybar-9999/work/waybar-9999'
 * S: '/var/tmp/portage/gui-apps/waybar-9999/work/waybar-9999'
Comment 1 Larry the Git Cow gentoo-dev 2024-02-26 13:04:27 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fd9f94f5973ae308d710493a830df56c248b1d66

commit fd9f94f5973ae308d710493a830df56c248b1d66
Author:     brettalcox <brettalcox@gmail.com>
AuthorDate: 2024-02-24 14:14:15 +0000
Commit:     Yixun Lan <dlan@gentoo.org>
CommitDate: 2024-02-26 13:04:09 +0000

    gui-apps/waybar: fix 9999 compile fail
    
    requiring gtk-layer-shell in 9999 as it is now
    unconditionally required as a dependency.
    
    See https://github.com/Alexays/Waybar/pull/2836
    
    Closes: https://bugs.gentoo.org/925017
    Closes: https://github.com/gentoo/gentoo/pull/35514
    Signed-off-by: brettalcox <brettalcox@gmail.com>
    Acked-by: Julien Roy <julien@jroy.ca>
    Signed-off-by: Yixun Lan <dlan@gentoo.org>

 gui-apps/waybar/waybar-9999.ebuild | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)