Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 924935 - net-nds/389-ds-base-2.3.2 fails to build - slapi_r_plugin/src/value.rs: error: variable does not need to be mutable
Summary: net-nds/389-ds-base-2.3.2 fails to build - slapi_r_plugin/src/value.rs: error...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Robert Förster
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks:
 
Reported: 2024-02-18 16:41 UTC by Anders Larsson
Modified: 2024-04-28 11:15 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for it to build correctly (file_924935.txt,450 bytes, patch)
2024-02-18 16:43 UTC, Anders Larsson
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Larsson 2024-02-18 16:41:59 UTC
net-nds/389-ds-base-2.3.2 Fails to build due to stricter rust checks.

Reproducible: Always

Steps to Reproduce:
1. emerge -1 '=net-nds/389-ds-base-2.3.2'
Actual Results:  
Fails with:
error: variable does not need to be mutable
   --> slapi_r_plugin/src/value.rs:185:13
    |
185 |         let mut v = unsafe { slapi_value_new() };
    |             ----^
    |             |
    |             help: remove this `mut`
    |
note: the lint level is defined here
   --> slapi_r_plugin/src/lib.rs:1:9
    |
1   | #![deny(warnings)]
    |         ^^^^^^^^
    = note: `#[deny(unused_mut)]` implied by `#[deny(warnings)]`

error: could not compile `slapi_r_plugin` (lib) due to previous error



Expected Results:  
Builds and installs successfully.

Portage 3.0.61 (python 3.11.7-final-0, default/linux/amd64/17.1/no-multilib/hardened, gcc-13, glibc-2.38-r10, 6.6.13-gentoo x86_64)                                                                                                                                                                                                            [32/2323]
=================================================================
System uname: Linux-6.6.13-gentoo-x86_64-QEMU_Virtual_CPU_version_2.5+-with-glibc2.38
KiB Mem:     1524288 total,    793288 free
KiB Swap:     524284 total,    499852 free
Timestamp of repository gentoo: Sun, 18 Feb 2024 13:00:01 +0000
Head commit of repository gentoo: 78c0a5617293a7e132253d0075d7474c360b4346
Head commit of repository anders-larsson: 79e482b656a9dd9253d2fd1115c1f3a5f4c8024b

Timestamp of repository certbot-dns-plugins: Mon, 12 Feb 2024 16:36:02 +0000
Head commit of repository certbot-dns-plugins: aeb968b7dfdf3f0191d34eb4cf20bb50ad6b42b7

sh bash 5.1_p16-r6
ld GNU ld (Gentoo 2.41 p5) 2.41.0
app-misc/pax-utils:        1.3.7::gentoo
app-shells/bash:           5.1_p16-r6::gentoo
dev-build/autoconf:        2.71-r6::gentoo
dev-build/automake:        1.16.5-r2::gentoo
dev-build/cmake:           3.27.9::gentoo
dev-build/libtool:         2.4.7-r1::gentoo
dev-build/make:            4.4.1-r1::gentoo
dev-build/meson:           1.3.0-r2::gentoo
dev-lang/perl:             5.38.2-r1::gentoo
dev-lang/python:           3.11.7::gentoo, 3.12.1_p1::gentoo
dev-lang/rust:             1.74.1::gentoo
sys-apps/baselayout:       2.14-r2::gentoo
sys-apps/openrc:           0.53::gentoo
sys-apps/sandbox:          2.38::gentoo
sys-devel/binutils:        2.41-r5::gentoo
sys-devel/binutils-config: 5.5::gentoo
sys-devel/gcc:             13.2.1_p20240113-r1::gentoo
sys-devel/gcc-config:      2.11::gentoo
sys-kernel/linux-headers:  6.6::gentoo (virtual/os-headers)
sys-libs/glibc:            2.38-r10::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    volatile: False
    sync-rsync-extra-opts:
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-max-age: 3
    sync-rsync-verify-metamanifest: yes

anders-larsson
    location: /var/db/repos/anders-larsson
    sync-type: git
    sync-uri: https://github.com/anders-larsson/gentoo-overlay.git
    masters: gentoo
    volatile: False

certbot-dns-plugins
    location: /var/db/repos/certbot-dns-plugins
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/certbot-dns-plugins.git
    masters: gentoo
    volatile: False

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe -march=native"
DISTDIR="/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="--with-bdeps=y --complete-graph y --jobs=5 --load-average=1 --getbinpkg"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox pkgdir-index-trusted preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_GB.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LEX="flex"
MAKEOPTS="-j1"
PKGDIR="/var/cache/binpkgs"
PORTAGE_BINHOST="http://domain.tld/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
SHELL="/bin/bash"
USE="acl amd64 bzip2 cet cli crypt dri fortran gdbm hardened iconv ipv6 libtirpc ncurses nls offensive openmp openssl pam pcre pic pie readline seccomp split-usr ssl ssp syslog test-rust unicode vim-syntax xattr xtpax zlib zsh-completion" ABI_X86="64" ADA_TARGET="gnat_2021" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_anon authn_dbm authn_file authz_dbm authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir env expires ext_filter file_cache filter headers include info log_config logio mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2 sse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 ntrip navcom oceanserver oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 tsip tripmate tnt ublox" GRUB_PLATFORMS="pc" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz glk hd44780 lb216 lcdm001 mtxorb text" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php8-1" POSTGRES_TARGETS="postgres15" PYTHON_SINGLE_TARGET="python3_11" PYTHON_TARGETS="python3_11" RUBY_TARGETS="ruby31" VIDEO_CARDS="amdgpu fbdev intel nouveau radeon radeonsi vesa dummy" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipp2p iface geoip fuzzy condition tarpit sysrq proto logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PYTHONPATH, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS
Comment 1 Anders Larsson 2024-02-18 16:43:44 UTC
Created attachment 885372 [details, diff]
Patch for it to build correctly

Builds successfully with included patch.
Comment 2 Larry the Git Cow gentoo-dev 2024-04-28 07:24:07 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4b22f2b6ca7262c033c67c49b4eb140d4edc49f8

commit 4b22f2b6ca7262c033c67c49b4eb140d4edc49f8
Author:     Robert Förster <Dessa@gmake.de>
AuthorDate: 2024-04-27 14:40:23 +0000
Commit:     Arthur Zamarin <arthurzam@gentoo.org>
CommitDate: 2024-04-28 07:08:26 +0000

    net-nds/389-ds-base: add 3.0.2
    
    Closes: https://bugs.gentoo.org/929734
    Bug: https://bugs.gentoo.org/924935
    Signed-off-by: Robert Förster <Dessa@gmake.de>
    Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

 net-nds/389-ds-base/389-ds-base-3.0.2.ebuild | 338 +++++++++++++++++++++++++++
 net-nds/389-ds-base/Manifest                 |  72 ++++++
 2 files changed, 410 insertions(+)
Comment 3 Robert Förster 2024-04-28 11:15:27 UTC
used Bugs instead of Closes tag accidentally, this builds now.