Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 924611 - [guru] gui-apps/ReGreet: Missing configuration files and cache directory.
Summary: [guru] gui-apps/ReGreet: Missing configuration files and cache directory.
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gonçalo Negrier Duarte
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-14 22:41 UTC by agooglygooglr
Modified: 2024-02-16 06:38 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description agooglygooglr 2024-02-14 22:41:15 UTC
There should be a directory with the path of `/var/cache/regreet` that is owned by the user `greetd` so that ReGreet can remember previously picked sessions.

There should also be template config files in `/etc/greetd` as well.

I was able to get the config files from ReGreet's git repo, but figuring out why ReGreet wasn't properly remembering my choice of session was more difficult to figure out, so it would be nice to avoid this headache for other users.
Comment 1 Gonçalo Negrier Duarte 2024-02-15 12:48:02 UTC
The config file should be created by the user because they can decided if they what to run the greetd as there user (for exemple using there gtk4 theme in the login manager) about that /var/cache/regreetd that should be make by the user as well I think guru thinderbox will fail if that is created by the ebuild
Comment 2 Gonçalo Negrier Duarte 2024-02-15 12:51:44 UTC
Also I not using ReGreet anymore if you what that change you can always send a PR to guru repo or a patch here I will happy accept, check frist if the QA not give out a error.
Comment 3 Gonçalo Negrier Duarte 2024-02-15 13:16:24 UTC
By the way the repo only have the file to create logs and cache folder using systemd-tmpfile so that wouldn’t work on openrc system. That file is used if the logs useflag is enable (I should change it to systemd useflag tho), so I don’t think this would be possible to be made for all users.
Comment 4 Gonçalo Negrier Duarte 2024-02-15 19:17:50 UTC
Since I Bug 922945 to solve I did a few touch up to the ebuild and add regreet.sample.toml to the /usr/doc/regreet folder and some things in the elog.

The manually creation of folder should work in openrc (I don't use openrc so I can test if QA fail I will revert this, in my opnion should be the user to created as it explain in the README).

But @agooglygooglr@gmail.com I will not put configuration file inside /etc/greetd, that is not good pratice since user can overwrite it by mistake using dispatch-conf.

Commit:https://gitweb.gentoo.org/repo/proj/guru.git/commit/?h=dev&id=c5d3ec090a9aa553d1c04f003564aacb2989ae49
Comment 5 agooglygooglr 2024-02-16 00:20:52 UTC
> about that /var/cache/regreetd that should be
> make by the user as well I think guru thinderbox will fail if that is
> created by the ebuild

Are there instructions anywhere telling the user they should do this? If not, it should definitely be added; since I wasted some minutes trying to figure out why regreet wasn't functioning properly on Gentoo.
Comment 6 Gonçalo Negrier Duarte 2024-02-16 00:46:30 UTC
If you seen the new commit you can see I make the ebuild create the files just need someone to test it on openrc.
You also need this commit (fix a typo): https://gitweb.gentoo.org/repo/proj/guru.git/commit/?h=dev&id=9f9c456165e9c4085def938443827feee00da57f
Comment 7 Larry the Git Cow gentoo-dev 2024-02-16 06:38:55 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=c5d3ec090a9aa553d1c04f003564aacb2989ae49

commit c5d3ec090a9aa553d1c04f003564aacb2989ae49
Author:     Gonçalo Negrier Duarte <gonegrier.duarte@gmail.com>
AuthorDate: 2024-02-15 19:07:05 +0000
Commit:     Gonçalo Negrier Duarte <gonegrier.duarte@gmail.com>
CommitDate: 2024-02-15 19:17:15 +0000

    gui-apps/ReGreet: add default environment variables before build
    * create missing cache and log folder for systemd and openrc
    * add missing regreet.sample.toml
    * add elog message as documentation to the user
    * add missing depedencies
    
    Closes: https://bugs.gentoo.org/924611
    Closes: https://bugs.gentoo.org/922945
    Signed-off-by: Gonçalo Negrier Duarte <gonegrier.duarte@gmail.com>

 ...eet-0.1.1-r3.ebuild => ReGreet-0.1.1-r4.ebuild} | 61 ++++++++++++++++---
 gui-apps/ReGreet/ReGreet-9999.ebuild               | 71 ++++++++++++++++++----
 gui-apps/ReGreet/metadata.xml                      |  4 +-
 3 files changed, 116 insertions(+), 20 deletions(-)