Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 924496 - dev-util/github-cli-2.42.0: link-time dev-lang/go error when -ggdb3 is present in CFLAGS
Summary: dev-util/github-cli-2.42.0: link-time dev-lang/go error when -ggdb3 is presen...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Low trivial
Assignee: William Hubbs
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-02-14 08:25 UTC by tacokoneko
Modified: 2024-08-15 21:24 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
/var/tmp/portage/dev-util/github-cli-2.42.0/temp/build.log (build.log.xz,116.57 KB, application/x-xz)
2024-02-14 08:26 UTC, tacokoneko
Details
emerge -pqv '=dev-util/github-cli-2.42.0::gentoo' (emerge-pqv-kitty.log,44 bytes, text/x-log)
2024-02-14 08:27 UTC, tacokoneko
Details

Note You need to log in before you can comment on or make changes to this bug.
Description tacokoneko 2024-02-14 08:25:38 UTC
How to reproduce:
CFLAGS="-ggdb3" emerge dev-util/github-cli

Portage 3.0.61 (python 3.11.7-final-0, default/linux/amd64/17.1/desktop, gcc-13, glibc-2.38-r10, 6.1.69-gentoo-dist x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-6.1.69-gentoo-dist-x86_64-AMD_Ryzen_9_5950X_16-Core_Processor-with-glibc2.38
KiB Mem:    32764220 total,   1887180 free
KiB Swap:  133113848 total, 122617720 free
Head commit of repository gentoo: 898ac6d1b0d59abbc128d2da46d1fa7e8431859a

Timestamp of repository FireBurn: Mon, 12 Feb 2024 16:35:36 +0000
Head commit of repository FireBurn: e2ff3f7567f534603efdbc152ca4d62dc63ff8f0

Timestamp of repository guru: Tue, 13 Feb 2024 16:49:01 +0000
Head commit of repository guru: 6851b4002107f7277f0c22895a843fd98fa969e9

Timestamp of repository pf4public: Tue, 13 Feb 2024 16:33:32 +0000
Head commit of repository pf4public: 7e02a289e281b680b73a6fc6883ab76d06174435

Timestamp of repository steam-overlay: Mon, 12 Feb 2024 16:35:44 +0000
Head commit of repository steam-overlay: d984553a1549c63a93d840bd1ecbadbe54a582a8

Timestamp of repository tatsh-overlay: Mon, 12 Feb 2024 16:36:02 +0000
Head commit of repository tatsh-overlay: 2cfd2507052ffe21e7194700b52c3b53a014ad20

Head commit of repository the-anime-team: 99e632bd248efe18047c03bd637ada9928019866

Timestamp of repository torbrowser: Mon, 12 Feb 2024 16:35:46 +0000
Head commit of repository torbrowser: e99b51cd8f02febfbd054dce6f30a80b058d68c7

sh bash 5.1_p16-r6
ld GNU ld (Gentoo 2.41 p4) 2.41.0
ccache version 4.9.1 [disabled]
app-misc/pax-utils:        1.3.7::gentoo
app-shells/bash:           5.1_p16-r6::gentoo
dev-build/autoconf:        2.13-r8::gentoo, 2.71-r6::gentoo
dev-build/automake:        1.16.5-r2::gentoo
dev-build/cmake:           3.27.9::gentoo
dev-build/libtool:         2.4.7-r1::gentoo
dev-build/make:            4.4.1-r1::gentoo
dev-build/meson:           1.3.1-r1::gentoo
dev-java/java-config:      2.3.3-r1::gentoo
dev-lang/perl:             5.38.2-r1::gentoo
dev-lang/python:           2.7.18_p16-r2::gentoo, 3.10.13::gentoo, 3.11.7::gentoo, 3.12.1_p1::gentoo
dev-lang/rust:             1.75.0-r1::gentoo
dev-lang/rust-bin:         1.74.1::gentoo
dev-util/ccache:           4.9.1::gentoo
sys-apps/baselayout:       2.14-r2::gentoo
sys-apps/openrc:           0.53::gentoo
sys-apps/sandbox:          2.38::gentoo
sys-devel/binutils:        2.41-r3::gentoo
sys-devel/binutils-config: 5.5::gentoo
sys-devel/clang:           16.0.6::gentoo, 17.0.6::gentoo
sys-devel/gcc:             13.2.1_p20240113-r1::gentoo
sys-devel/gcc-config:      2.11::gentoo
sys-devel/lld:             17.0.6::gentoo
sys-devel/llvm:            16.0.6::gentoo, 17.0.6::gentoo
sys-kernel/linux-headers:  6.6::gentoo (virtual/os-headers)
sys-libs/glibc:            2.38-r10::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: git
    sync-uri: https://gitlab.com/evbox/open-source/external/gentoo.git
    priority: -1000
    volatile: False

FireBurn
    location: /var/db/repos/FireBurn
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/FireBurn.git
    masters: gentoo
    volatile: False

guru
    location: /var/db/repos/guru
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/guru.git
    masters: gentoo
    volatile: False

local
    location: /var/db/repos/local
    masters: gentoo
    volatile: False

pf4public
    location: /var/db/repos/pf4public
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/pf4public.git
    masters: gentoo
    volatile: False

steam-overlay
    location: /var/db/repos/steam-overlay
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/steam-overlay.git
    masters: gentoo
    volatile: False

tatsh-overlay
    location: /var/db/repos/tatsh-overlay
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/tatsh-overlay.git
    masters: gentoo
    volatile: False

the-anime-team
    location: /var/db/repos/the-anime-team
    sync-type: git
    sync-uri: https://github.com/an-anime-team/gentoo-ebuilds.git
    masters: gentoo
    volatile: False

torbrowser
    location: /var/db/repos/torbrowser
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/torbrowser.git
    masters: gentoo
    volatile: False

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="@FREE @BINARY-REDISTRIBUTABLE UFAS free-noncomm MSttfEULA Parsec-EULA BUSL-1.1"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe -ggdb3"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=native -O2 -pipe -ggdb3"
DISTDIR="/var/cache/distfiles"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-march=native -O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news nostrip parallel-fetch pid-sandbox pkgdir-index-trusted preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-march=native -O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LEX="flex"
MAKEOPTS="-j12"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
SHELL="/bin/bash"
USE="X a52 aac acl acpi aio alsa amd64 amr amrenc ao apache2 appindicator appkit bash-completion bluetooth bluray branding brotli browser bs2b bzip2 cairo capi capstone cdda cdio cdr chromaprint chromium cli codec2 context contrib cpudetection crypt cube cups curl dbus declarative dedicated designer dri drm dts dvd dvdr elogind encode exif extra extras fat fdk ffmpeg firmware flac flite fontconfig fortran frei0r fribidi fuse gd gdbm geckodriver gif gimp git gles1 gles2 glusterfs glut gme gmp gnome-keyring gpl gpm gsettings gsm gstreamer gtk gtk2 gui gzip hardcoded-tables hip hwaccel iconv icu iec61883 ieee1394 imagemagick imap ipv6 jack java javafx javascript jemalloc joystick jpeg jpeg2k jpegxl kvazaar ladspa latex layers lcms libaom libaribb24 libass libcaca libdrm libilbc libnotify libplacebo librtmp libsamplerate libsoxr libtesseract libtirpc libv4l libvirt libvirtd libwww libxml2 lm-sensors lua lv2 lxc lz4 lzma lzo mad matroska mmal mng modplug mono mp3 mp4 mpeg mpi mplayer mtp multilib ncurses network network-cron nls notification numpy nvenc obex ogg openal opencl opengl openh264 openmp openssl opus osmesa oss pam pango parted pcre pdf pic pipewire pipewire-alsa plugins png policykit posix postgres postproc ppds pulseaudio python qemu qml qt5 qt6 quick quicktime readline rubberband ruby samba sasl sdl seccomp snappy sndfile sndio sound sound-server speex spell spice split-usr sqlite srt ssh ssl startup-notification suid svg test-rust themes theora threads tiff tk truetype twolame udev udisks unicode upnp upnp-av upower usb usbredir v4l vaapi vdpau vidstab virgl vkd3d vlc vmaf vnc vorbis vpx vulkan vulkan-overlay webchannel webp widgets wxwidgets x264 x265 xattr xcb xcomposite xft xinerama xml xv xvid zeroconf zeromq zimg zink zip zlib zstd zvbi" ABI_X86="64" ADA_TARGET="gnat_2021" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_anon authn_dbm authn_file authz_dbm authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir env expires ext_filter file_cache filter headers include info log_config logio mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2 aes avx avx2 f16c fma3 pclmul popcnt rdrand sha sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 ntrip navcom oceanserver oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 tsip tripmate tnt ublox" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz glk hd44780 lb216 lcdm001 mtxorb text" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php8-1" POSTGRES_TARGETS="postgres15" PYTHON_SINGLE_TARGET="python3_11" PYTHON_TARGETS="python3_11" QEMU_SOFTMMU_TARGETS="x86_64 i386 arm aarch64" QEMU_USER_TARGETS="x86_64 i386 arm aarch64" RUBY_TARGETS="ruby31" VIDEO_CARDS="amdgpu radeon radeonsi virtio" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipp2p iface geoip fuzzy condition tarpit sysrq proto logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EMERGE_DEFAULT_OPTS, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PYTHONPATH, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS

=================================================================
                        Package Settings
=================================================================

dev-util/github-cli-2.42.0::gentoo was built with the following:
USE="" ABI_X86="(64)"
CFLAGS="-march=native -O2 -pipe"
CXXFLAGS="-march=native -O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox pkgdir-index-trusted preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
LDFLAGS=""
Comment 1 tacokoneko 2024-02-14 08:26:53 UTC
Created attachment 884929 [details]
/var/tmp/portage/dev-util/github-cli-2.42.0/temp/build.log
Comment 2 tacokoneko 2024-02-14 08:27:46 UTC
Created attachment 884930 [details]
emerge -pqv '=dev-util/github-cli-2.42.0::gentoo'
Comment 3 Ionen Wolkens gentoo-dev 2024-02-14 08:32:07 UTC
wrt bug #924436's lazy temporary workaround
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=548e7366
>If this is a widespread issue, it may need visiting in go-env's
>go-env_set_compile_environment instead though.
As a user-side workaround, could explicitly set CGO_C(XX)FLAGS to not have -g3/-ggdb3 though.

Likely only surfacing now because it used to not respect *FLAGS before go-env.eclass I think? (not sure what Go does without it), assuming it's not just a new issue with a new Go version.
Comment 4 Arniii 2024-03-30 09:16:19 UTC
I've got the same bug with github-cli , docker-compose , app-shells/fzf .

setting 


CGO_CFLAGS="${COMMON_FLAGS}"
CGO_CXXFLAGS="${COMMON_FLAGS}"
CGO_FFLAGS="${COMMON_FLAGS}"

where COMMON_FLAGS doesn't contain -ggdb3
solve the compile issue.

Thanks for proposed used-side solution.
Comment 5 Emanuele Torre 2024-08-14 04:48:12 UTC
(Posting since the bug is still Status: UNCONFIRMED)
I've also just encoutered this bug when re-building dev-util/github-cli
after the recent dev-lang/go update.

The cause of the problem was indeed me adding -ggdb3 to my global CFLAGS
and CXXFLAGS since the last installation.

My temporary fix is removing -ggdb3 from CFLAGS when building this
package using:

    $ cat /etc/portage/env/noggdb3
    CFLAGS="${COMMON_FLAGS}"
    $ grep github-cli /etc/portage/package.env
    dev-util/github-cli noggdb3

Error message:

    GOROOT='' /usr/lib/go/pkg/tool/linux_amd64/link -o $WORK/b001/exe/a.out -importcfg $WORK/b001/importcfg.link -installsuffix shared -X=runtime.godebugDefault=asynctimerchan=1,gotypesalias=0,httpservecontentkeepheaders=1,tls3des=1,tlskyber=0,x509keypairleaf=0,x509negativeserial=1 -buildmode=pie -buildid=Sz568u9plDhJfnzE2jyi/SEQR9_4SXsWozKvXGQyJ/NavXMej7WJD-4NgK9iY8/Sz568u9plDhJfnzE2jyi -X github.com/cli/cli/v2/internal/build.Date=2024-08-14 -X github.com/cli/cli/v2/internal/build.Version=v2.52.0 -extld=x86_64-pc-linux-gnu-gcc $WORK/b001/_pkg_.a
    # github.com/cli/cli/v2/cmd/gh
    loadelf: $WORK/b163/_pkg_.a(_x001.o): 983185: sym#50 ("wm4.0.0e9cb841a877bcf5cacaa6a62ce29303"): ignoring symbol in section 1 (".group") (type 0)
    loadelf: $WORK/b163/_pkg_.a(_x002.o): 983189: sym#61 ("wm4.0.0e9cb841a877bcf5cacaa6a62ce29303"): ignoring symbol in section 1 (".group") (type 0)
    loadelf: $WORK/b163/_pkg_.a(_x003.o): 983194: sym#63 ("wm4.0.0e9cb841a877bcf5cacaa6a62ce29303"): ignoring symbol in section 1 (".group") (type 0)
    loadelf: $WORK/b163/_pkg_.a(_x004.o): 983198: sym#59 ("wm4.0.0e9cb841a877bcf5cacaa6a62ce29303"): ignoring symbol in section 1 (".group") (type 0)
    loadelf: $WORK/b163/_pkg_.a(_x005.o): 983203: sym#83 ("wm4.0.0e9cb841a877bcf5cacaa6a62ce29303"): ignoring symbol in section 1 (".group") (type 0)
    loadelf: $WORK/b163/_pkg_.a(_x006.o): 983208: sym#117 ("wm4.0.0e9cb841a877bcf5cacaa6a62ce29303"): ignoring symbol in section 1 (".group") (type 0)
    loadelf: $WORK/b172/_pkg_.a(_x001.o): 983212: sym#48 ("wm4.0.0e9cb841a877bcf5cacaa6a62ce29303"): ignoring symbol in section 1 (".group") (type 0)
    loadelf: $WORK/b172/_pkg_.a(_x002.o): 983216: sym#24 ("wm4.0.0e9cb841a877bcf5cacaa6a62ce29303"): ignoring symbol in section 1 (".group") (type 0)
    loadelf: $WORK/b172/_pkg_.a(_x003.o): 983221: sym#64 ("wm4.0.0e9cb841a877bcf5cacaa6a62ce29303"): ignoring symbol in section 1 (".group") (type 0)
    loadelf: $WORK/b172/_pkg_.a(_x004.o): 983228: sym#66 ("wm4.0.0e9cb841a877bcf5cacaa6a62ce29303"): ignoring symbol in section 1 (".group") (type 0)
    loadelf: $WORK/b172/_pkg_.a(_x005.o): 983243: sym#88 ("wm4.0.0e9cb841a877bcf5cacaa6a62ce29303"): ignoring symbol in section 1 (".group") (type 0)
    loadelf: $WORK/b172/_pkg_.a(_x006.o): 983253: sym#98 ("wm4.0.0e9cb841a877bcf5cacaa6a62ce29303"): ignoring symbol in section 1 (".group") (type 0)
    loadelf: $WORK/b172/_pkg_.a(_x007.o): 983260: sym#72 ("wm4.0.0e9cb841a877bcf5cacaa6a62ce29303"): ignoring symbol in section 1 (".group") (type 0)
    loadelf: $WORK/b172/_pkg_.a(_x008.o): 983265: sym#64 ("wm4.0.0e9cb841a877bcf5cacaa6a62ce29303"): ignoring symbol in section 1 (".group") (type 0)
    loadelf: $WORK/b172/_pkg_.a(_x009.o): 983270: sym#84 ("wm4.0.0e9cb841a877bcf5cacaa6a62ce29303"): ignoring symbol in section 1 (".group") (type 0)
    loadelf: $WORK/b172/_pkg_.a(_x010.o): 983275: sym#74 ("wm4.0.0e9cb841a877bcf5cacaa6a62ce29303"): ignoring symbol in section 1 (".group") (type 0)
    loadelf: $WORK/b172/_pkg_.a(_x011.o): 983280: sym#64 ("wm4.0.0e9cb841a877bcf5cacaa6a62ce29303"): ignoring symbol in section 1 (".group") (type 0)
    loadelf: $WORK/b172/_pkg_.a(_x012.o): 983288: sym#67 ("wm4.0.0e9cb841a877bcf5cacaa6a62ce29303"): ignoring symbol in section 1 (".group") (type 0)
    loadelf: $WORK/b172/_pkg_.a(_x013.o): 983293: sym#76 ("wm4.0.0e9cb841a877bcf5cacaa6a62ce29303"): ignoring symbol in section 1 (".group") (type 0)
    loadelf: $WORK/b210/_pkg_.a(_x001.o): 983301: sym#48 ("wm4.0.0e9cb841a877bcf5cacaa6a62ce29303"): ignoring symbol in section 1 (".group") (type 0)
    loadelf: $WORK/b210/_pkg_.a(_x002.o): 983306: sym#65 ("wm4.0.0e9cb841a877bcf5cacaa6a62ce29303"): ignoring symbol in section 1 (".group") (type 0)
    /usr/lib/go/pkg/tool/linux_amd64/link: too many errors
    exit status 1
    build.go: building task `bin/gh` failed.
    make: *** [Makefile:17: bin/gh] Error 1
Comment 6 Emanuele Torre 2024-08-14 06:08:21 UTC
I read the ebuild for this package and I was surprised to find a
filter-flags "-ggdb3"  command that clearly is not doing what it is
supposed to do.

I did some digging, and I have found that that filter-flags command as
well as the  filter-lto  and  unset LDFLAGS  that are also called in
src_compile, are seeming completely useless, because  GOC_LDFLAGS,
GOC_CFLAGS,  and the other  GOC_*FLAGS  variables are set earlier on in
src_unpack by  go-env_set_compile_environment .

I made a pull request that fixes this bug (and probably also bugs
related to lto if thoes  unset LDFLAGS  and  filter-lto  commands were
actually needed.)

https://github.com/gentoo/gentoo/pull/38140

o/
 emanuele6
Comment 7 Larry the Git Cow gentoo-dev 2024-08-15 21:18:43 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8b05c1c26ef96bb9324db626572f3c4a73e3178c

commit 8b05c1c26ef96bb9324db626572f3c4a73e3178c
Author:     Emanuele Torre <torreemanuele6@gmail.com>
AuthorDate: 2024-08-14 05:36:34 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-08-15 21:18:22 +0000

    dev-util/github-cli: fix build failure when -ggdb3 is in CFLAGS
    
    After experiencing the bug described in https://bugs.gentoo.org/924496,
    I was surprised to see  filter-flags "-ggdb3"  in the ebuilds for this
    package.
    
    I did some digging and found that go's goc does not use CFLAGS, LDFLAGS,
    etc by default; it only uses the GOC_*FLAGS environment variables.
    What causes goc to use CFLAGS if GOC_FLAGS is unset or empty is the
    go-env_set_compile_environment function from the go-env eclass, that is
    indirectly called by the go-module_live_vendor and go-module_src_unpack
    functions from the go-module eclass that are being called from the
    src_unpack of this ebuild.
    
    So, calling  filter-lto ,  filter-flags "-ggdb3" , and  unset LDFLAGS
    from src_compile before emake seems completely useless since those will
    only filter regular  *FLAGS  environment variable, and not the
    GOC_*FLAGS  environment variables initialised from the  *FLAGS
    variables earlier on in src_unpack.
    
    Moving those filter/unset commands to the start of  src_unpack  makes
    them filter/unset *FLAGS variables before GOC_*FLAGS variables are set,
    and actually fix the build problem encountered when CFLAGS contains
    -ggdb3.
    
    Bump copyright of touched ebuild files.
    
    Bug: https://bugs.gentoo.org/847991
    Closes: https://bugs.gentoo.org/924496
    Signed-off-by: Emanuele Torre <torreemanuele6@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/38140
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-util/github-cli/github-cli-2.27.0.ebuild | 15 ++++++++-------
 dev-util/github-cli/github-cli-2.31.0.ebuild | 15 ++++++++-------
 dev-util/github-cli/github-cli-2.32.1.ebuild | 15 ++++++++-------
 dev-util/github-cli/github-cli-2.33.0.ebuild | 15 ++++++++-------
 dev-util/github-cli/github-cli-2.42.0.ebuild | 13 +++++++------
 dev-util/github-cli/github-cli-2.52.0.ebuild | 13 +++++++------
 dev-util/github-cli/github-cli-9999.ebuild   | 15 ++++++++-------
 7 files changed, 54 insertions(+), 47 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fc1c525c544f7c4e4bc4a51ab71f7755e592eeef

commit fc1c525c544f7c4e4bc4a51ab71f7755e592eeef
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-08-15 21:11:24 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-08-15 21:18:23 +0000

    dev-util/github-cli: drop now-obsolete flag mangling
    
    The real issue is intrinsic to Go (or cgo, anyway) and so we shouldn't
    do it per-package, but rather in go-env.eclass. That's done now, so
    drop the package-local workaround.
    
    Bug: https://bugs.gentoo.org/924496
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-util/github-cli/github-cli-2.27.0.ebuild | 9 +--------
 dev-util/github-cli/github-cli-2.31.0.ebuild | 9 +--------
 dev-util/github-cli/github-cli-2.32.1.ebuild | 9 +--------
 dev-util/github-cli/github-cli-2.33.0.ebuild | 9 +--------
 dev-util/github-cli/github-cli-2.42.0.ebuild | 9 +--------
 dev-util/github-cli/github-cli-2.52.0.ebuild | 9 +--------
 dev-util/github-cli/github-cli-9999.ebuild   | 9 +--------
 7 files changed, 7 insertions(+), 56 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=116f54058abd4fa4a5b3c16ee49a99df11883a45

commit 116f54058abd4fa4a5b3c16ee49a99df11883a45
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-08-15 21:13:28 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-08-15 21:18:23 +0000

    go-env.eclass: workaround debug info issues
    
    Go can't handle some DWARF produced by GCC but nobody's been able
    to produce a simple testcase for it, so add a workaround where we replace
    -g3 with -g and -ggdb3 with -ggdb for GCC, like Ionen did in Kitty.
    
    Bug: https://bugs.gentoo.org/847991
    Bug: https://bugs.gentoo.org/924436
    Bug: https://bugs.gentoo.org/924496
    Closes: https://bugs.gentoo.org/929219
    Signed-off-by: Sam James <sam@gentoo.org>

 eclass/go-env.eclass | 6 ++++++
 1 file changed, 6 insertions(+)
Comment 8 Larry the Git Cow gentoo-dev 2024-08-15 21:24:21 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1f754863ff91dc4dca11e6a5217ffd449f39c74c

commit 1f754863ff91dc4dca11e6a5217ffd449f39c74c
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-08-15 21:23:22 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-08-15 21:24:05 +0000

    go-env.eclass: improve debug workaround
    
    Use what Ionen did in x11-terms/kitty to avoid touching flags for
    non-Go parts of the build.
    
    Bug: https://bugs.gentoo.org/847991
    Bug: https://bugs.gentoo.org/924436
    Bug: https://bugs.gentoo.org/924496
    Bug: https://bugs.gentoo.org/929219
    Signed-off-by: Sam James <sam@gentoo.org>

 eclass/go-env.eclass | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)