Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 924407 - dev-libs/liboil-0.3.17-r4 fails tests
Summary: dev-libs/liboil-0.3.17-r4 fails tests
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Freedesktop bugs
URL:
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks: slibtool
  Show dependency tree
 
Reported: 2024-02-13 08:05 UTC by Agostino Sarubbo
Modified: 2024-03-15 19:30 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,505.14 KB, text/plain)
2024-02-13 08:05 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2024-02-13 08:05:31 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-libs/liboil-0.3.17-r4 fails tests.
Discovered on: amd64 (internal ref: slibtool_tinderbox)
System: SLIBTOOL-SYSTEM (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#SLIBTOOL)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0015
Comment 1 Agostino Sarubbo gentoo-dev 2024-02-13 08:05:34 UTC
Created attachment 884836 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2024-02-13 08:05:35 UTC
Error(s) that match a know pattern:


FAIL: abs
FAIL: copy
FAIL: dso_check
FAIL: md5
FAIL: md5_profile
FAIL: zigzag
cmp: liboilarray.c: No such file or directory
grep: .libs/liboiltmp1.exp: No such file or directory
Comment 3 orbea 2024-02-21 15:24:05 UTC
Weird issue, some tests when using liboil-0.3.so.0 built by GNU libtool work, but if the library is built with slibtool they segfault. This is true even when the test itself was built by slibtool.

My first suspect is that liboil uses -export-symbols-regex which is not yet supported in slibtool, but will be soon so lets try again then.

See: https://dev.midipix.org/cross/slibtool/issue/61
Comment 4 orbea 2024-02-22 15:29:51 UTC
Slibtool now has -export-symbols-regex, but unfortunately this still doesn't work.

After further investigation I believe the real issue is that slibtool fails to add many object (.o) files to the liboilfunctions.a convenience library which are specified in liboilfunctions_la_LIBADD.
Comment 5 orbea 2024-02-22 15:53:57 UTC
New upstream slibtool issue: https://dev.midipix.org/cross/slibtool/issue/62
Comment 6 orbea 2024-02-23 00:21:47 UTC
Actually I was correct with my first suspicion that liboil required -export-symbols-regex to be implemented, but I missed a crucial detail. During the build liboil will generate liboilarray.c by grepping .libs/liboiltmp1.exp, but this file is a GNU libtool temporary file used during the creation of the LD version script and is not logic that slibtool requires so it was missing even after -export-symbols-regex was implemented.

This file is now created for compatibility purposes and the liboil tests work with slibtool-9999.
Comment 7 Larry the Git Cow gentoo-dev 2024-03-15 19:30:25 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=341f85a7caa16a7d986a4b428521562bf9120b08

commit 341f85a7caa16a7d986a4b428521562bf9120b08
Author:     orbea <orbea@riseup.net>
AuthorDate: 2024-03-15 13:51:37 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-15 19:29:22 +0000

    dev-build/slibtool: add 0.5.36
    
    Many bugs are fixed with this release, it is recommended for slibtool
    users to rebuild their entire system after this release. The addition of
    -export-symbols and -export-symbols-regex will allow exporting only the
    desired public symbols globally in any package that uses them.
    
    Closes: https://bugs.gentoo.org/925555
    Closes: https://bugs.gentoo.org/913670
    Closes: https://bugs.gentoo.org/916128
    Closes: https://bugs.gentoo.org/775596
    Closes: https://bugs.gentoo.org/792072
    Closes: https://bugs.gentoo.org/924407
    Closes: https://bugs.gentoo.org/924291
    Closes: https://bugs.gentoo.org/782013
    Closes: https://bugs.gentoo.org/914569
    Closes: https://bugs.gentoo.org/791880
    Closes: https://bugs.gentoo.org/913551
    Closes: https://bugs.gentoo.org/913688
    Closes: https://bugs.gentoo.org/914097
    Closes: https://bugs.gentoo.org/915966
    Closes: https://bugs.gentoo.org/924408
    Closes: https://bugs.gentoo.org/915121
    Closes: https://bugs.gentoo.org/913642
    Closes: https://bugs.gentoo.org/917639
    Closes: https://bugs.gentoo.org/917640
    Closes: https://bugs.gentoo.org/913530
    Closes: https://bugs.gentoo.org/913638
    Closes: https://bugs.gentoo.org/778515
    Closes: https://bugs.gentoo.org/920190
    Closes: https://bugs.gentoo.org/924404
    Signed-off-by: orbea <orbea@riseup.net>
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-build/slibtool/Manifest               |  2 ++
 dev-build/slibtool/slibtool-0.5.36.ebuild | 41 +++++++++++++++++++++++++++++++
 2 files changed, 43 insertions(+)