Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 924353 - app-editors/e3-2.8.2: suspicious riscv keyword
Summary: app-editors/e3-2.8.2: suspicious riscv keyword
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Keywording (show other bugs)
Hardware: riscv Linux
: Normal normal (vote)
Assignee: Emacs project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-12 09:21 UTC by Ulrich Müller
Modified: 2024-02-14 13:00 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2024-02-12 09:21:08 UTC
e3 is written in x86 assembly language, therefore I wonder how it could build on riscv. Please double check if the keywording is correct.

The ebuild currently has:
KEYWORDS="-* amd64 ~riscv x86"
Comment 1 Jakov Smolić archtester gentoo-dev 2024-02-12 13:37:20 UTC
It doesn't error out during the build but obviously can't be executed 

> >>> Compiling source in /var/tmp/portage/app-editors/e3-2.8.2/work/e3-2.82 ...
> make -j32 -l32 -- 32 LD=riscv64-unknown-linux-gnu-ld DEBUG=true
> nasm -O2 -f bin -l e3.lst -o e3 e3.asm -DCRIPLED_ELF=1 -DLINUX
> chmod +x e3
> ln -sf e3 e3ws
> ln -sf e3 e3em
> ln -sf e3 e3pi
> ln -sf e3 e3vi
> ln -sf e3 e3ne
> >>> Source compiled.
> (...)

> -bash: /usr/bin/e3: cannot execute binary file: Exec format error

It was probably a random keywording, but in any case the -* keyword should have been a giveaway.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-02-12 13:41:45 UTC
We should add a smoke test to src_test, better than nothing...
Comment 3 Larry the Git Cow gentoo-dev 2024-02-12 13:51:55 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d6630f6f02ee0159379bb3bd4222ac21f223401e

commit d6630f6f02ee0159379bb3bd4222ac21f223401e
Author:     Jakov Smolić <jsmolic@gentoo.org>
AuthorDate: 2024-02-12 13:46:57 +0000
Commit:     Jakov Smolić <jsmolic@gentoo.org>
CommitDate: 2024-02-12 13:47:01 +0000

    app-editors/e3: unkeyword 2.8.2 for ~riscv
    
    Package was keyworded without proper testing and can't work on riscv.
    Closes: https://bugs.gentoo.org/924353
    Signed-off-by: Jakov Smolić <jsmolic@gentoo.org>

 app-editors/e3/e3-2.8.2.ebuild | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 4 Larry the Git Cow gentoo-dev 2024-02-14 13:00:10 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=76480eb12412e13a6f9b105bde10fd7a98b137a6

commit 76480eb12412e13a6f9b105bde10fd7a98b137a6
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2024-02-14 12:55:14 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2024-02-14 12:59:48 +0000

    app-editors/e3: Suppress false positive warning for prestripped
    
    Make the build fail if the arch is unknown; update to EAPI 8 for
    two-argument usev.
    
    Closes: https://bugs.gentoo.org/924244
    Bug: https://bugs.gentoo.org/924353
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 app-editors/e3/e3-2.8.2.ebuild | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)