Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 924296 - media-libs/kvazaar-2.2.0 fails compilation with LTO
Summary: media-libs/kvazaar-2.2.0 fails compilation with LTO
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2024-02-11 14:27 UTC by Paolo Pedroni
Modified: 2024-04-07 23:35 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
kvazaar-2.2.0:20240211-124935.log.gz (kvazaar-2.2.0:20240211-124935.log.gz,12.63 KB, application/gzip)
2024-02-11 14:27 UTC, Paolo Pedroni
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paolo Pedroni 2024-02-11 14:27:08 UTC
Created attachment 884733 [details]
kvazaar-2.2.0:20240211-124935.log.gz

/var/tmp/portage/media-libs/kvazaar-2.2.0/work/kvazaar-2.2.0/src/strategies/generic/intra-generic.c: In function 'kvz_angular_pred_generic':
/var/tmp/portage/media-libs/kvazaar-2.2.0/work/kvazaar-2.2.0/src/strategies/generic/intra-generic.c:102:26: error: writing 64 bytes into a region of size 0 [-Werror=stringop-overflow=]
  102 |       tmp_ref[x + width] = ref_side[side_index - 1];
      |                          ^
/var/tmp/portage/media-libs/kvazaar-2.2.0/work/kvazaar-2.2.0/src/strategies/generic/intra-generic.c:64:13: note: at offset [-61, -33] into destination object 'tmp_ref' of size 64
   64 |   kvz_pixel tmp_ref[2 * 32];
      |             ^
/var/tmp/portage/media-libs/kvazaar-2.2.0/work/kvazaar-2.2.0/src/strategies/generic/intra-generic.c:102:26: error: writing 32 bytes into a region of size 0 [-Werror=stringop-overflow=]
  102 |       tmp_ref[x + width] = ref_side[side_index - 1];
      |                          ^
/var/tmp/portage/media-libs/kvazaar-2.2.0/work/kvazaar-2.2.0/src/strategies/generic/intra-generic.c:64:13: note: at offset [-93, -1] into destination object 'tmp_ref' of size 64
   64 |   kvz_pixel tmp_ref[2 * 32];
      |             ^
/var/tmp/portage/media-libs/kvazaar-2.2.0/work/kvazaar-2.2.0/src/strategies/avx2/intra-avx2.c: In function 'kvz_angular_pred_avx2':
/var/tmp/portage/media-libs/kvazaar-2.2.0/work/kvazaar-2.2.0/src/strategies/avx2/intra-avx2.c:443:26: error: writing 64 bytes into a region of size 0 [-Werror=stringop-overflow=]
  443 |       tmp_ref[x + width] = ref_side[side_index - 1];
      |                          ^
/var/tmp/portage/media-libs/kvazaar-2.2.0/work/kvazaar-2.2.0/src/strategies/avx2/intra-avx2.c:405:11: note: at offset [-61, -33] into destination object 'tmp_ref' of size 64
  405 |   uint8_t tmp_ref[2 * 32];
      |           ^
/var/tmp/portage/media-libs/kvazaar-2.2.0/work/kvazaar-2.2.0/src/strategies/avx2/intra-avx2.c:443:26: error: writing 32 bytes into a region of size 0 [-Werror=stringop-overflow=]
  443 |       tmp_ref[x + width] = ref_side[side_index - 1];
      |                          ^
/var/tmp/portage/media-libs/kvazaar-2.2.0/work/kvazaar-2.2.0/src/strategies/avx2/intra-avx2.c:405:11: note: at offset [-93, -1] into destination object 'tmp_ref' of size 64
  405 |   uint8_t tmp_ref[2 * 32];
      |           ^
lto1: all warnings being treated as errors
make[3]: *** [/var/tmp/portage/media-libs/kvazaar-2.2.0/temp/cct5X6yp.mk:14: /var/tmp/portage/media-libs/kvazaar-2.2.0/temp/cclBmnUR.ltrans4.ltrans.o] Error 1
lto-wrapper: fatal error: make returned 2 exit status
compilation terminated.
/usr/libexec/gcc/x86_64-pc-linux-gnu/ld: error: lto-wrapper failed
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:983: libkvazaar.la] Error 1
make[2]: Leaving directory '/var/tmp/portage/media-libs/kvazaar-2.2.0/work/kvazaar-2.2.0-abi_x86_64.amd64/src'
make[1]: *** [Makefile:529: all-recursive] Error 1
make[1]: Leaving directory '/var/tmp/portage/media-libs/kvazaar-2.2.0/work/kvazaar-2.2.0-abi_x86_64.amd64'
make: *** [Makefile:399: all] Error 2
 * ERROR: media-libs/kvazaar-2.2.0::gentoo failed (compile phase):
 *   emake failed

# emerge --info =media-libs/kvazaar-2.2.0
Portage 3.0.61 (python 3.11.7-final-0, default/linux/amd64/17.1/desktop/plasma/systemd/merged-usr, gcc-13, glibc-2.38-r10, 6.6.13-gentoo x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-6.6.13-gentoo-x86_64-AMD_Ryzen_9_7950X3D_16-Core_Processor-with-glibc2.38
KiB Mem:    65025204 total,  43289180 free
KiB Swap:  134217724 total, 121284092 free
Timestamp of repository gentoo: Fri, 09 Feb 2024 07:45:01 +0000
Head commit of repository gentoo: cc7880fad848dd3406bb0fdaef29b8fb38b74066
sh dash 0.5.12
ld GNU ld (Gentoo 2.41 p4) 2.41.0
distcc 3.4 x86_64-pc-linux-gnu [disabled]
ccache version 4.9.1 [disabled]
app-misc/pax-utils:        1.3.7::gentoo
app-shells/bash:           5.1_p16-r6::gentoo
dev-build/autoconf:        2.71-r6::gentoo
dev-build/automake:        1.16.5-r2::gentoo
dev-build/cmake:           3.27.9::gentoo
dev-build/libtool:         2.4.7-r1::gentoo
dev-build/make:            4.4.1-r1::gentoo
dev-build/meson:           1.3.0-r2::gentoo
dev-java/java-config:      2.3.3-r1::gentoo
dev-lang/perl:             5.38.2-r1::gentoo
dev-lang/python:           3.11.7::gentoo, 3.12.1_p1::gentoo
dev-lang/rust:             1.74.1::gentoo
dev-util/ccache:           4.9.1::gentoo
sys-apps/baselayout:       2.14-r2::gentoo
sys-apps/sandbox:          2.38::gentoo
sys-apps/systemd:          255.3::gentoo
sys-devel/binutils:        2.41-r3::gentoo
sys-devel/binutils-config: 5.5::gentoo
sys-devel/clang:           17.0.6::gentoo
sys-devel/gcc:             13.2.1_p20240113-r1::gentoo
sys-devel/gcc-config:      2.11::gentoo
sys-devel/lld:             17.0.6::gentoo
sys-devel/llvm:            17.0.6::gentoo
sys-kernel/linux-headers:  6.6::gentoo (virtual/os-headers)
sys-libs/glibc:            2.38-r10::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: rsync
    sync-uri: rsync://rsync.europe.gentoo.org/gentoo-portage
    priority: -1000
    volatile: True
    sync-rsync-verify-metamanifest: yes
    sync-rsync-extra-opts: 
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-max-age: 24

x-portage
    location: /usr/local/portage
    masters: gentoo
    priority: 0
    volatile: True

Binary Repositories:

gentoobinhost
    priority: 1
    sync-uri: https://gentoo.osuosl.org/releases/amd64/binpackages/17.1/x86-64

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="@FREE"
AR="/usr/bin/gcc-ar"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -frecord-gcc-switches -march=znver4 -mshstk -flto=16 -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/easy-rsa /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d"
CXXFLAGS="-O2 -pipe -frecord-gcc-switches -march=znver4 -mshstk -flto=16 -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing"
DISTDIR="/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going y --with-bdeps y"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-O2 -pipe -frecord-gcc-switches -march=znver4 -mshstk -flto=16 -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg-live compress-build-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox pkgdir-index-trusted preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms sign split-elog split-log strict test unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe -frecord-gcc-switches -march=znver4 -mshstk -flto=16 -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing"
GENTOO_MIRRORS="http://tux.rainside.sk/gentoo/ http://gentoo.mirror.root.lu/ ftp://tux.rainside.sk/gentoo/"
LANG="it_IT.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -Wl,--sort-common"
LEX="flex"
MAKEOPTS="-j32 -l32"
NM="/usr/bin/gcc-nm"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
RANLIB="/usr/bin/gcc-ranlib"
SHELL="/bin/bash"
USE="X a52 aac aalib acl acpi activities adns alsa amd64 ao audiofile avif bash-completion bluetooth branding brotli bzip2 cairo caps cdda cddb cdparanoia cdr cli colord crypt css cups curl dbus declarative dga djvu dri dts dvd dvdr encode exif expat fbcon ffmpeg fftw flac fontconfig foomaticdb fortran ftp gd gdbm geoip gif gimp gles2 gmp gnutls gphoto2 gpm graphviz gstreamer gtk gui guile handbook heif iconv icu idn imagemagick imlib introspection ipv6 java javascript jbig jemalloc jpeg jpeg2k jpegxl kde kwallet lame lapack lcms libass libnotify libsamplerate libtirpc lm-sensors lto lua lz4 lzma lzo mad magic man mhash mmap mng mp3 mp4 mpeg multilib musicbrainz ncurses nls offensive ogg openal opencl opengl openmp opus pam pango pcre pdf pipewire plasma png policykit postscript ppds pulseaudio qml qt5 qt6 rdesktop readline recode samba screencast sctp sdl seccomp sndfile sockets sound speex spell sqlite ssl startup-notification svg symlink syslog systemd sysvipc taglib telemetry test test-rust theora threads tidy tiff truetype udev udisks unicode upower usb v4l vaapi vala verify-sig vim-syntax vnc vorbis vulkan wavpack wayland webp widgets win32codecs wmf wxwidgets x264 xattr xcb xft xinerama xml xpm xscreensaver xv xvid yahoo zip zlib zstd" ABI_X86="64" ADA_TARGET="gnat_2021" ALSA_CARDS="hda-intel virmidi" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_anon authn_dbm authn_file authz_dbm authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir env expires ext_filter file_cache filter headers include info log_config logio mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 avx512f avx512dq avx512cd avx512bw avx512vl avx512vbmi f16c fma3 mmx mmxext pclmul popcnt rdrand sha sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3" CURL_SSL="gnutls" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 ntrip navcom oceanserver oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 tsip tripmate tnt ublox" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="libinput" KERNEL="linux" L10N="it en" LCD_DEVICES="bayrad cfontz glk hd44780 lb216 lcdm001 mtxorb text" LLVM_TARGETS="AMDGPU" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php8-1" POSTGRES_TARGETS="postgres15" PYTHON_SINGLE_TARGET="python3_11" PYTHON_TARGETS="python3_11" RUBY_TARGETS="ruby31" VIDEO_CARDS="amdgpu radeon radeonsi" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipp2p iface geoip fuzzy condition tarpit sysrq proto logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PYTHONPATH, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS

=================================================================
                        Package Settings
=================================================================

media-libs/kvazaar-2.2.0::gentoo was built with the following:
USE="static-libs test" ABI_X86="(64) -32 (-x32)"
CFLAGS="-O2 -pipe -frecord-gcc-switches -march=znver4 -mshstk -flto=16 -fno-lto -Wno-error"
CXXFLAGS="-O2 -pipe -frecord-gcc-switches -march=znver4 -mshstk -flto=16 -fno-lto -Wno-error"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -Wl,--sort-common -flto=16 -fno-lto"

# emerge -1pqv =media-libs/kvazaar-2.2.0
[ebuild   R   ] media-libs/kvazaar-2.2.0  USE="static-libs test" ABI_X86="(64) -32 (-x32)"
Comment 1 Eli Schwartz 2024-04-07 22:51:51 UTC
This is a -Wstringop-overflow, not really an LTO issue. I cannot even reproduce it at all, but I think that what happened here is:

the configure.ac sets -Werror, and we append-flags -Wno-error.

libtool drops only -Wno-error at link time, and LTO reruns various passes, triggering this warning which is escalated to -Werror.

Recent versions of libtool / eltpatch somehow allow both through?

Really, if you think about it this is just bug 907263.
Comment 2 Larry the Git Cow gentoo-dev 2024-04-07 23:35:19 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e6308710dff6e3e7469e536d5e947494ca080fd4

commit e6308710dff6e3e7469e536d5e947494ca080fd4
Author:     Eli Schwartz <eschwartz93@gmail.com>
AuthorDate: 2024-04-07 22:24:11 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-04-07 23:33:45 +0000

    media-libs/kvazaar: don't manually enable -Werror
    
    autotools is genius software. When you add a flag called
    --disable-werror, it isn't actually a flag called --disable-werror. It's
    a flag called AC_ARG_ENABLE(werror), which expands "code if argument
    was passed on the command line" and "code if argument was not passed on
    the command line" blocks. When you say "--disable-werror" all you
    actually do is add a formatted help text, which is otherwise totally
    ignored by autoconf.
    
    kvazaar had an AC_ARG_ENABLE that defined an
    action-if-argument-was-defined-on-the-command-line of nothing, and an
    action-if-argument-was-excluded-on-the-command-line of adding -Werror to
    CFLAGS.
    
    Back in commit 019c44a86ad017ea54703b7594b076cb0b840707, this was then
    used to work around the default addition of -Werror. Logical.
    
    In the very next release, upstream changed the help text to advertise
    the --enable-* form, and switched it to
    action-if-argument-was-defined-on-the-command-line of adding -Werror,
    action-if-argument-was-excluded-on-the-command-line of nothing.
    
    See:
    https://github.com/ultravideo/kvazaar/commit/033bc6bc45b0c6b200a4227208d2fa6263e09166
    
    This naturally meant that passing --disable-werror would add -Werror, in
    addition to setting the ignored shell variable enable_werror=no. So for
    seven years, we've been building with -Werror. Yay!
    
    During that very version bump, --disable-werror was never removed.
    Instead, append-flags was used to add an additional gcc switch back off,
    per the redundancy requirements of the Department of Redundancy Department's
    required approach to redundantly specifying redundant flags.
    
    This also appears to tickle edge cases in LTO due to libtool dropping
    some, but not all flags... sometimes. Leading to LTO being performed
    with global -Werror.
    
    Bug: https://bugs.gentoo.org/618434
    Closes: https://bugs.gentoo.org/907263
    Closes: https://bugs.gentoo.org/924296
    Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 media-libs/kvazaar/kvazaar-2.1.0.ebuild    | 5 +----
 media-libs/kvazaar/kvazaar-2.2.0.ebuild    | 5 +----
 media-libs/kvazaar/kvazaar-2.3.0-r1.ebuild | 3 ---
 media-libs/kvazaar/kvazaar-9999.ebuild     | 3 ---
 4 files changed, 2 insertions(+), 14 deletions(-)