Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 924218 - media-libs/vidstab-1.1.1 fails tests: tests.c:78: error: invalid use of void expression
Summary: media-libs/vidstab-1.1.1 fails tests: tests.c:78: error: invalid use of void ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Kalin KOZHUHAROV
URL:
Whiteboard: fixed in 1.1.1
Keywords: PullRequest, TESTFAILURE
Depends on: 924248
Blocks: c99-porting
  Show dependency tree
 
Reported: 2024-02-10 08:41 UTC by Agostino Sarubbo
Modified: 2024-11-01 03:19 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,111.69 KB, text/plain)
2024-02-10 08:41 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2024-02-10 08:41:52 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-libs/vidstab-1.1.1 fails tests.
Discovered on: amd64 (internal ref: tinderbox_musl)
System: MUSL-SYSTEM (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#MUSL)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0015
Comment 1 Agostino Sarubbo gentoo-dev 2024-02-10 08:41:55 UTC
Created attachment 884666 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2024-02-10 08:41:55 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


--   Package 'orc-0.4', required by 'virtual:world', not found
-- Could NOT find LibOrc (missing: ORC_LIBRARY ORC_INCLUDE_DIR) 
FAILED: CMakeFiles/tests.dir/tests.c.o 
/var/tmp/portage/media-libs/vidstab-1.1.1/work/vid.stab-1.1.1/tests/tests.c:78: error: invalid use of void expression
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-02-10 08:44:10 UTC
The real issue is:

/var/tmp/portage/media-libs/vidstab-1.1.1/work/vid.stab-1.1.1/tests/generate.c: In function 'generateFrames':
/var/tmp/portage/media-libs/vidstab-1.1.1/work/vid.stab-1.1.1/tests/testframework.h:21: warning: implicit declaration of function '__STRING' [-Wimplicit-function-declaration]
   21 |    : test_fails (__STRING(expr), __FILE__, __LINE__, ___FUNCTION))
      |                  ^~~~~~~~

The rest just comes from that.
Comment 4 Larry the Git Cow gentoo-dev 2024-02-10 23:29:29 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c285848bf59c8824a90f0f2fc9895efa7e36c70d

commit c285848bf59c8824a90f0f2fc9895efa7e36c70d
Author:     Kalin KOZHUHAROV <me.kalin@gmail.com>
AuthorDate: 2024-02-10 21:56:04 +0000
Commit:     Craig Andrews <candrews@gentoo.org>
CommitDate: 2024-02-10 23:29:26 +0000

    media-libs/vidstab: adding test dependency
    
    dev-lang/orc is required, iff FEATURES=test
    therefore introducing USE=test and adding this dependency.
    
    Merged from https://github.com/thinrope/pkalin/commit/8af40010830b5bf64d30a5ec7859171687ec77f2
    
    Reported-by: Kalin KOZHUHAROV <kalin@thinrope.net>
    Signed-off-by: Kalin KOZHUHAROV <kalin@thinrope.net>
    Closes: https://bugs.gentoo.org/924218
    Closes: https://github.com/gentoo/gentoo/pull/35264
    Signed-off-by: Craig Andrews <candrews@gentoo.org>

 media-libs/vidstab/vidstab-1.1.1.ebuild | 5 ++++-
 media-libs/vidstab/vidstab-9999.ebuild  | 5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)
Comment 5 Kalin KOZHUHAROV 2024-02-11 01:09:34 UTC
Craig, please revert that last change, since QA is complaining of broken tree... https://qa-reports.gentoo.org/output/gentoo-ci/bc0a667d44/output.html;pkg=media-libs:vidstab

I am working with the media-libs/vidstab upstream to have ORC code removed, since apparently it is not needed in any active code. --> https://github.com/georgmartius/vid.stab/pull/129
Comment 6 Craig Andrews gentoo-dev 2024-02-11 01:29:06 UTC
(In reply to Kalin KOZHUHAROV from comment #5)
> Craig, please revert that last change, since QA is complaining of broken
> tree...
> https://qa-reports.gentoo.org/output/gentoo-ci/bc0a667d44/output.html;
> pkg=media-libs:vidstab
> 
> I am working with the media-libs/vidstab upstream to have ORC code removed,
> since apparently it is not needed in any active code. -->
> https://github.com/georgmartius/vid.stab/pull/129

I fixed it moments after committing so there's no need to revert: https://github.com/gentoo/gentoo/commit/a0ed84029bc3da98f1173b71c49cc6c6b937afdb