Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 924114 - media-gfx/xloadimage-4.1-r16 fails to compile: window.c:836:24: error: __sighandler_t undeclared (first use in this function)
Summary: media-gfx/xloadimage-4.1-r16 fails to compile: window.c:836:24: error: __sigh...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard: musl
Keywords: PullRequest
Depends on:
Blocks: gcc-14-stable
  Show dependency tree
 
Reported: 2024-02-08 15:53 UTC by Agostino Sarubbo
Modified: 2025-02-10 09:34 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,51.99 KB, text/plain)
2024-02-08 15:53 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2024-02-08 15:53:35 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-gfx/xloadimage-4.1-r16 fails to compile.
Discovered on: amd64 (internal ref: tinderbox_musl)
System: MUSL-SYSTEM (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#MUSL)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0014
Comment 1 Agostino Sarubbo gentoo-dev 2024-02-08 15:53:37 UTC
Created attachment 884571 [details]
build.log

build log and emerge --info
Comment 2 NHO 2025-01-15 11:04:54 UTC
Bug persists in -r17
Comment 3 NHO 2025-01-15 11:12:03 UTC
Can't just add #include <linux/signal.h> - it defines multiple types differently from musl, compilation fails differently.
Comment 4 NHO 2025-01-15 11:21:12 UTC
Of course it's introduced by our patch, that needs to be replaced by another patch.
Comment 5 Larry the Git Cow gentoo-dev 2025-02-10 09:14:00 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2eb2b82b8c4cb09ac49b8fbb493a3ac43c1a139a

commit 2eb2b82b8c4cb09ac49b8fbb493a3ac43c1a139a
Author:     NHOrus <jy6x2b32pie9@yahoo.com>
AuthorDate: 2025-01-15 11:21:39 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-02-10 09:05:47 +0000

    media-gfx/xloadimage: fix incompatible function pointer types on musl
    
    Replaces previous patch that fixed it on glibc only
    
    Bug: https://bugs.gentoo.org/924114
    Signed-off-by: NHOrus <jy6x2b32pie9@yahoo.com>
    Closes: https://github.com/gentoo/gentoo/pull/40143
    Signed-off-by: Sam James <sam@gentoo.org>

 ...mage-4.1-fix-incomp-function-pointer-musl.patch | 14 ++++
 media-gfx/xloadimage/xloadimage-4.1-r18.ebuild     | 97 ++++++++++++++++++++++
 2 files changed, 111 insertions(+)