Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 924061 - www-client/firefox USE clang Masked on musl/llvm Profile
Summary: www-client/firefox USE clang Masked on musl/llvm Profile
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Profiles (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-08 08:58 UTC by Jake Winters
Modified: 2024-02-11 06:40 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jake Winters 2024-02-08 08:58:36 UTC
I noticed that since the end of 2023/beginning of 2024, the `clang` USE for `www-client/firefox` was masked when it worked perfectly fine from around the end of 2022 onwards. Since Clang is the official upstream compiler and the fact musl/llvm profiles aren't focused on (and don't include?) GCC, it doesn't make sense to mask `clang`.

After some digging, I found that a bug caused the USE to be masked on 2022-07-27, but this clearly no longer applies since it worked well after that date and it works fine when removing the force-masked `clang` USE by commenting out line 94 in `/var/db/repos/gentoo/profiles/features/musl/package.use.mask`, which seems to be the issue. This seems to be a bug which is caused by reverting the mask when it doesn't seem to be required.

I have successfully compiled and run Firefox after I commented out the line in the file in question.
Comment 1 Joonas Niilola gentoo-dev 2024-02-10 08:11:10 UTC
I guess it was related to libcxx being broken. Yeah I have no way to test this currently, I can lift off the mask and let's see what happens.
Comment 2 Joonas Niilola gentoo-dev 2024-02-10 08:16:35 UTC
Oh, actually, I see it's masked in regular musk profile too. I can test it on musl with firefox[clang], but not on musl/llvm.
Comment 3 Joonas Niilola gentoo-dev 2024-02-10 10:03:20 UTC
Yeah, looks like I can't actually compile it on musl with +clang.
Comment 4 Jake Winters 2024-02-11 01:03:43 UTC
I'm unsure about standard musl profile, but it's working for me since first attempt of commenting out the line in the file I mentioned on musl/llvm profile. I've asked other people to test it on their musl profiles.
Comment 5 Tohka 2024-02-11 02:07:04 UTC
I can confirm that I can compile on musl with +clang. I am on the musl/hardened/selinux profile.
Comment 6 Joonas Niilola gentoo-dev 2024-02-11 06:32:10 UTC
Actually my bad, I see my musl test container has package.masked rust and it somehow ended up pulling rust-bin >1.73 which is broken. With source-built rust Firefox does compile.
Comment 7 Larry the Git Cow gentoo-dev 2024-02-11 06:40:18 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d48fc6e32f86ef142c73c7c546d23d607334319e

commit d48fc6e32f86ef142c73c7c546d23d607334319e
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2024-02-11 06:37:40 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2024-02-11 06:40:15 +0000

    profiles/default/linux: remove firefox[clang] mask on musl profiles
    
     - while with ugly implementation, the current firefox:rapid ebuild should
       work with source-built rust on musl.
    
    Closes: https://bugs.gentoo.org/924061
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 profiles/default/linux/amd64/17.0/musl/clang/package.use.mask       | 6 ------
 profiles/default/linux/amd64/23.0/musl/llvm/package.use.mask        | 6 ------
 .../default/linux/amd64/23.0/split-usr/musl/llvm/package.use.mask   | 6 ------
 profiles/default/linux/arm64/17.0/musl/llvm/package.use.mask        | 6 ------
 profiles/default/linux/arm64/23.0/musl/llvm/package.use.mask        | 6 ------
 .../default/linux/arm64/23.0/split-usr/musl/llvm/package.use.mask   | 6 ------
 profiles/features/musl/package.use.mask                             | 5 -----
 7 files changed, 41 deletions(-)