Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 924034 - media-libs/libsdl2-2.30 version bump request
Summary: media-libs/libsdl2-2.30 version bump request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 921254
  Show dependency tree
 
Reported: 2024-02-08 07:05 UTC by Alexander Weber
Modified: 2024-03-17 03:42 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Weber 2024-02-08 07:05:29 UTC
media-libs/libsdl2-2.30 is out.

https://github.com/libsdl-org/SDL/releases/tag/release-2.30.0

Some packages (like games-emulation/duckstation::guru) requires it already.

Reproducible: Always
Comment 1 Ionen Wolkens gentoo-dev 2024-02-13 21:21:53 UTC
For what it's worth, haven't tried but I doubt duckstation *actually* needs it. The one who did this change to duckstation did the same on PCSX2 and constantly bumps the minimum libSDL2 requirement even though it does not actually use any new features from it (may eventually do but it's uncommon). Think it's just that they don't want to test/worry about old versions.

Not to say that libsdl2 shouldn't be updated here, but in the interim could optionally remove the 2.30.0 from [1].

[1] https://github.com/stenzek/duckstation/blob/d9846093/CMakeModules/DuckStationDependencies.cmake#L2
Comment 2 Alexander Weber 2024-03-11 10:41:54 UTC
The workaround with patching the version back to 2.28 does not work anymore  with duckstation. Seems the developer uses the new libsdl2 features now.

In the meantime the release libSDL 2.30.1 is out
Comment 3 James Le Cuirot gentoo-dev 2024-03-16 23:05:14 UTC
I went to bump this, but I keep hitting at least one test failure.

> ERROR: 03/16/24 23:03:00: Assert 'Verify returned value equals set value; got: testValue='050000007e0500000920000001800000,Nintendo Switch Pro Controller,platform:Linux,a:b0,b:b1,x:b3,y:b2,back:b9,guide:b11,start:b10,leftstick:b12,rightstick:b13,leftshoulder:b5,rightshoulder:b6,dpup:h0.1,dpdown:h0.4,dpleft:h0.8,dpright:h0.2,leftx:a0,lefty:a1,rightx:a2,righty:a3,lefttrigger:b7,righttrigger:b8,' value='ZtCLigs9;x': Failed

The "value" changes every time, which is particularly concerning. I've tried stripping my CFLAGS and I've also tried applying the latest changes to the 2.30.x branch, but it's still the same. It would be useful to know if anyone hits this.
Comment 4 Ionen Wolkens gentoo-dev 2024-03-16 23:38:35 UTC
(In reply to James Le Cuirot from comment #3)
> The "value" changes every time, which is particularly concerning. I've tried
> stripping my CFLAGS and I've also tried applying the latest changes to the
> 2.30.x branch, but it's still the same. It would be useful to know if anyone
> hits this.
Barely tried, but with simple a ebuild copy (didn't look at changes) to 2.30.1 and default'ish USE+haptic, tests passed for me.

fwiw I tried plugging a gamepad in (xbox one) just in-case it's reading real data and causing randomness, but that didn't change anything.

If enable USE=abi_x86_32, testautomation segfaults though (doesn't with 2.28.5), haven't really looked into that further. Still no message about a switch pro failed assert though.
Comment 5 Ionen Wolkens gentoo-dev 2024-03-16 23:41:56 UTC
(In reply to Ionen Wolkens from comment #4)
> fwiw I tried plugging a gamepad in (xbox one) just in-case it's reading real
> data and causing randomness, but that didn't change anything.
Then again, don't think portage user has access to it, so that likely didn't mean much :)
Comment 6 Larry the Git Cow gentoo-dev 2024-03-17 03:42:46 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0ad5e53f8cbd5848d7e6a5abc9453b31243d9c03

commit 0ad5e53f8cbd5848d7e6a5abc9453b31243d9c03
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-03-17 03:41:49 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-17 03:41:49 +0000

    media-libs/libsdl2: add 2.30.1
    
    Closes: https://bugs.gentoo.org/921254
    Closes: https://bugs.gentoo.org/924034
    Signed-off-by: Sam James <sam@gentoo.org>

 media-libs/libsdl2/Manifest              |   1 +
 media-libs/libsdl2/libsdl2-2.30.1.ebuild | 263 +++++++++++++++++++++++++++++++
 2 files changed, 264 insertions(+)