Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 923621 - net-vpn/tailscale-1.58.2: build version reports as 1.58.2-ERR-BuildInfo
Summary: net-vpn/tailscale-1.58.2: build version reports as 1.58.2-ERR-BuildInfo
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor
Assignee: William Hubbs
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-02-02 11:46 UTC by alex
Modified: 2024-09-22 09:16 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix tailscale version info (tailscale-version-info.patch,760 bytes, patch)
2024-02-16 12:59 UTC, Magnus Kessler
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description alex 2024-02-02 11:46:25 UTC
Variables used to tag the reported version have changed in https://github.com/tailscale/tailscale/commit/70a2929a12f246aa783684eca7f48cb4c8eb9d65

    -ldflags="-X tailscale.com/version.long=${LONG} -X tailscale.com/version.short=${SHORT} -X tailscale.com/version.gitCommit=${GIT_HASH}"
    +ldflags="-X tailscale.com/version.longStamp=${LONG} -X tailscale.com/version.shortStamp=${SHORT}"

Reproducible: Always

Steps to Reproduce:
1. Run "tailscale version"
2.
3.
Actual Results:  
1.58.2-ERR-BuildInfo
  go version: go1.21.6

Expected Results:  
1.58.2
  tailscale commit: b0e1bbb62ef3834e99f5212b44043cec1866b07e
  go version: go1.21.6

https://github.com/gentoo/gentoo/pull/32246
https://gitlab.alpinelinux.org/alpine/aports/-/issues/14775
Comment 1 Magnus Kessler 2024-02-16 12:59:02 UTC
Created attachment 885151 [details, diff]
Fix tailscale version info

Fixed version info patch for tailscale >= 1.46.1, rebased from https://github.com/gentoo/gentoo/pull/32246
Comment 2 Gabriel Marcano 2024-06-02 18:59:14 UTC
I can confirm that the patch in Comment 1 still works as of tailscale-1.66.1.
Comment 3 Larry the Git Cow gentoo-dev 2024-09-22 09:16:15 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e77801e9aff9fb8dc1aded981135dc6d1d92f55d

commit e77801e9aff9fb8dc1aded981135dc6d1d92f55d
Author:     Haochen Tong <i@hexchain.org>
AuthorDate: 2024-09-16 03:58:38 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-09-22 09:15:48 +0000

    net-vpn/tailscale: fix version reporting
    
    Closes: https://bugs.gentoo.org/923621
    Closes: https://github.com/gentoo/gentoo/pull/37721
    Signed-off-by: Sam James <sam@gentoo.org>

 .../{tailscale-1.72.0.ebuild => tailscale-1.72.0-r1.ebuild}         | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)