Bug 923333 – gui-wm/wayfire-0.8.0-r1[debug] fails tests: ASan runtime does not come first in initial library list; you should either link runtime to your application or manually preload it with LD_PRELOAD.

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Agostino Sarubbo 2024-01-30 11:54:20 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: gui-wm/wayfire-0.8.0-r1 fails tests.
Discovered on: amd64 (internal ref: ci)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0015

[Comment 1 Agostino Sarubbo 2024-01-30 11:54:23 UTC]

CC'ing also the author of the commit (b80e6a855ec9c0d2b96782ad8b72555295f85340)

[Comment 2 Agostino Sarubbo 2024-01-30 11:54:24 UTC]

Created attachment 883717 [details]
build.log

build log and emerge --info

[Comment 3 Agostino Sarubbo 2024-01-30 11:54:25 UTC]

Created attachment 883718 [details]
1-testlog.txt

1-testlog.txt

[Comment 4 Agostino Sarubbo 2024-01-30 11:54:26 UTC]

Error(s) that match a know pattern:


Library execinfo found: NO
Run-time dependency libinotify found: NO (tried pkgconfig and cmake)
wf-utils| Program doxygen found: NO

[Comment 5 Agostino Sarubbo 2024-01-30 12:34:36 UTC]

In general the error " ASan runtime does not come first in initial library list; you should either link runtime to your application or manually preload it with LD_PRELOAD." can be solved by using -static-libasan as LDFLAGS instead of -fsanitize=address.
Note that for clang it is -static-libsan

[Comment 6 Sam James 2024-01-30 12:37:10 UTC]

asan/ubsan/valgrind etc should not be used in ebuilds unless the user enables it via -fsanitize=*.

[Comment 7 Sam James 2024-01-30 12:37:29 UTC]

(In reply to Sam James from comment #6)
> asan/ubsan/valgrind etc should not be used in ebuilds unless the user
> enables it via -fsanitize=*.

(because it's brittle, breaks with sandbox all the time like this, and it's just generally not the done thing)

[Comment 8 Alfred Wingate 2024-01-30 12:41:48 UTC]

I've come towards the same conclusion, the meson feature would either way work just fine as it parses CXXFLAGS for fsanitize to disable the internal backtrace as well.

[Comment 9 Larry the Git Cow 2024-01-30 13:50:21 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=59a3a277d2adecbbfda0c88adf31583fd0cf99eb

commit 59a3a277d2adecbbfda0c88adf31583fd0cf99eb
Author:     Alfred Wingate <[e-mail]>
AuthorDate: 2024-01-30 12:45:38 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-01-30 13:48:34 +0000

    gui-wm/wayfire: remove debug use flag
    
    [sam: It's not appropriate to have a USE flag just for compiler flags,
    plus asan/ubsan/valgrind aren't appropriate in ebuilds either as they're
    so sensitive to e.g. sandbox.]
    
    Closes: https://bugs.gentoo.org/923333
    Signed-off-by: Alfred Wingate <[e-mail]>
    Closes: https://github.com/gentoo/gentoo/pull/35092
    Signed-off-by: Sam James <[e-mail]>

 gui-wm/wayfire/wayfire-0.7.5-r1.ebuild | 11 +++--------
 gui-wm/wayfire/wayfire-0.8.0-r1.ebuild |  9 ++-------
 gui-wm/wayfire/wayfire-0.8.0.ebuild    |  9 ++-------
 gui-wm/wayfire/wayfire-9999.ebuild     | 11 +++--------
 4 files changed, 10 insertions(+), 30 deletions(-)