Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 923298 - =media-libs/libpng-1.6.41 broken png_check_sig
Summary: =media-libs/libpng-1.6.41 broken png_check_sig
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-29 23:41 UTC by John Bowler
Modified: 2024-01-30 07:40 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Bowler 2024-01-29 23:41:59 UTC
The upstream release of libpng, 1.6.41, changed the result true<->false in the public API png_check_sig, consequently any app or library built against this new release which uses the API will fail on PNG tests.

This only happens when the app or library itself is built; the error in the header file is in a macro definition.  Thus if an app is rebuilt the error "frozen" and a rebuild is required.

The bug is here:

https://github.com/pnggroup/libpng/issues/534

The proposed fix is to release 1.6.42 (which has other changes):

https://github.com/pnggroup/libpng/commit/ac944e2b364cff96e8458110c2ad06a63f8543b3

There is a new release (apparently) of 1.6.42

Because this is a sticky problem and will be very difficult to apps/libraries which hit it to work out (i.e. this is a bug farm).

1.6.41-r1 with the above commit will fix the issue as will just the change to line 919 of png.h (the other changes are new comments).

1.6.42 is in the process of being released.

Reproducible: Always
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-01-30 04:30:49 UTC
Thank you for the heads-up John! I'll handle it now.
Comment 2 Larry the Git Cow gentoo-dev 2024-01-30 07:40:22 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=980938b537dc1d6dadfd4beb78b436e3638bc53c

commit 980938b537dc1d6dadfd4beb78b436e3638bc53c
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-01-30 07:39:58 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-30 07:39:58 +0000

    media-libs/libpng: fix png_check_sig ABI break
    
    Thank you to John Bowler for the heads-up.
    
    Closes: https://bugs.gentoo.org/923298
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/libpng-1.6.41-png_check_sig-abi.patch    | 94 ++++++++++++++++++++++
 ...ibpng-1.6.41.ebuild => libpng-1.6.41-r1.ebuild} |  4 +
 2 files changed, 98 insertions(+)
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-01-30 07:40:35 UTC
Thank you John. I'll handle the bump to 1.6.42 later today too.