Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 923026 - media-libs/libnsgif: version bump from 0.2.1-r3 to 1.0.0 renames the header file
Summary: media-libs/libnsgif: version bump from 0.2.1-r3 to 1.0.0 renames the header file
Status: RESOLVED CANTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Michael Orlitzky
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-27 13:26 UTC by Joonas Niilola
Modified: 2024-01-28 06:33 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joonas Niilola gentoo-dev 2024-01-27 13:26:47 UTC
Hey, 

received bug 923022 - looks like the version bump on libnsgif renames the header file from libnsgif.h to nsgif.h breaking at least one rdep. Could we symlink the new .h to also include the old .h?

It'd probably be easy to patch at least this one rdep, but there are more
https://packages.gentoo.org/packages/media-libs/libnsgif/reverse-dependencies
Comment 1 Joonas Niilola gentoo-dev 2024-01-27 13:41:37 UTC
(In reply to Joonas Niilola from comment #0)
> Could we symlink the new .h to also include the old .h?
> 

Aa well, that didn't work, too many changes in the header file.
Comment 2 Michael Orlitzky gentoo-dev 2024-01-27 21:23:58 UTC
Sorry about that, I didn't consider the non-netsurf consumers of this when I added the new version. I only recently added myself as maintainer, and this is the first version bump.

The API has major changes from what I understand. Porting may not be too difficult since I don't see any huge overhaul commits to netsurf itself; nevertheless, the best way forward is probably to add bounds on its reverse dependencies until they can be updated. Next time, I'll know better and will warn everyone ahead of time.
Comment 3 Joonas Niilola gentoo-dev 2024-01-28 06:22:48 UTC
Yeah don't worry, upstream doing upstream things :) I've reported the breakage on ahoviewer upstream too, waiting for a fix there. I'll restrict the version for now, but need to check whether the libnsgif.so is linked or not. Yeah I doubt much can be done on our side to fix it. Reopen if you feel other rdeps may benefit from this bug.

Thanks for stepping to maintain these packages though!
Comment 4 Larry the Git Cow gentoo-dev 2024-01-28 06:33:28 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=91134c6549795c7bab14b7abbc22966939b71c52

commit 91134c6549795c7bab14b7abbc22966939b71c52
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2024-01-28 06:31:56 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2024-01-28 06:31:56 +0000

    media-gfx/ahoviewer: restrict libnsgif
    
     - the .so doesn't seem to be linked.
    
    Closes: https://bugs.gentoo.org/923022
    Bug: https://bugs.gentoo.org/923026
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 media-gfx/ahoviewer/ahoviewer-2.0.0_pre20220827-r1.ebuild | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)