Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 923010 - dev-lang/rust-bin: add `profiler` USE
Summary: dev-lang/rust-bin: add `profiler` USE
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Rust Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-27 09:47 UTC by Matt Jolly
Modified: 2024-03-27 03:45 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Jolly gentoo-dev 2024-01-27 09:47:22 UTC
>=www-client/chromium-121 requires rust to build and currently depends on dev-lang/rust[profiler]. It would be ideal if `profiler` was available for users that wished to enable it in the -bin package, and for packages to depend on via the virtual.

I'll look into the `gn` build script for chromium in more depth sometime and see if there's a toggle somewhere to make it a bit more optional, but either way this seems like desirable functionality.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-03-09 03:20:52 UTC
commit 3582ca8048830238fe79f4e8c96b2969f1e1961f
Author: WANG Xuerui <xen0n@gentoo.org>
Date:   Thu Mar 7 17:43:00 2024 +0800

    dev-lang/rust-bin: add IUSE=profiler

    Parallel to dev-lang/rust's IUSE=profiler.

    See: https://github.com/gentoo/gentoo/pull/35085#issuecomment-1920621395
    Signed-off-by: WANG Xuerui <xen0n@gentoo.org>

commit 9e8e96ef78ad1e9dfbd84587c45e80e4922d80f5 (origin/master, origin/HEAD)
Author: WANG Xuerui <xen0n@gentoo.org>
Date:   Thu Mar 7 17:43:43 2024 +0800

    virtual/rust: add IUSE=profiler

    See: https://github.com/gentoo/gentoo/pull/35085#issuecomment-1920621395
    Closes: https://github.com/gentoo/gentoo/pull/35272
    Signed-off-by: WANG Xuerui <xen0n@gentoo.org>
Comment 2 Larry the Git Cow gentoo-dev 2024-03-27 03:45:55 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ec95eaffca8731e4604cacefe2fabc4b814f7a9c

commit ec95eaffca8731e4604cacefe2fabc4b814f7a9c
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-03-27 03:44:42 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-27 03:45:39 +0000

    virtual/rust: backport USE=profiler
    
    This makes life easier for Chromium which we're about to stable.
    
    Bug: https://bugs.gentoo.org/923010
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/arch/loong/package.use.mask                          | 4 ++++
 profiles/arch/s390/package.use.mask                           | 4 ++++
 virtual/rust/{rust-1.71.0-r1.ebuild => rust-1.71.0-r2.ebuild} | 8 ++++----
 virtual/rust/{rust-1.71.1-r1.ebuild => rust-1.71.1-r2.ebuild} | 8 ++++----
 virtual/rust/{rust-1.73.0.ebuild => rust-1.73.0-r1.ebuild}    | 8 ++++----
 virtual/rust/{rust-1.74.1.ebuild => rust-1.74.1-r1.ebuild}    | 6 +++---
 virtual/rust/{rust-1.75.0.ebuild => rust-1.75.0-r1.ebuild}    | 6 +++---
 virtual/rust/rust-1.76.0.ebuild                               | 2 +-
 8 files changed, 27 insertions(+), 19 deletions(-)