Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 922920 - net-im/telegram-desktop missing build-time dependency dev-cpp/expected-lite
Summary: net-im/telegram-desktop missing build-time dependency dev-cpp/expected-lite
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Esteve Varela Colominas
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-25 18:32 UTC by Jesús P Rey (Chuso)
Modified: 2024-01-31 09:04 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Full build log (build.log,8.42 KB, text/x-log)
2024-01-25 18:32 UTC, Jesús P Rey (Chuso)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jesús P Rey (Chuso) 2024-01-25 18:32:25 UTC
Created attachment 883122 [details]
Full build log

dev-cpp/expected-lite is required for building net-im/telegram-desktop but not pulled as a dependency:

CMake Error at /usr/share/cmake/Modules/CMakeFindDependencyMacro.cmake:76 (find_package):
  By not providing "Findexpected-lite.cmake" in CMAKE_MODULE_PATH this
  project has asked CMake to find a package configuration file provided by
  "expected-lite", but CMake did not find one.

  Could not find a package configuration file provided by "expected-lite"
  with any of the following names:

    expected-liteConfig.cmake
    expected-lite-config.cmake

  Add the installation prefix of "expected-lite" to CMAKE_PREFIX_PATH or set
  "expected-lite_DIR" to a directory containing one of the above files.  If
  "expected-lite" provides a separate development package or SDK, be sure it
  has been installed.
Call Stack (most recent call first):
  /usr/lib64/cmake/cppgir/cppgir-config.cmake:2 (find_dependency)
  cmake/external/glib/generate_cppgir.cmake:7 (find_package)
  cmake/external/glib/CMakeLists.txt:10 (include)
Comment 1 Yixun Lan archtester gentoo-dev 2024-01-30 23:55:55 UTC
dev-cpp/expected-lite is a dependency of dev-cpp/cppgir, while net-im/telegram-desktop has been patched to use system lib of dev-cpp/cppgir, so should have no problem here..

just curious, have you got dev-cpp/cppgir installed properly?
Comment 2 Jesús P Rey (Chuso) 2024-01-31 00:01:48 UTC
Yes, I do.

But dev-cpp/expected-lite is only a build-time dependency (DEPEND) for dev-cpp/cppgir and not a runtime dependency (RDEPEND).

That doesn't guarantee that dev-cpp/expected-lite is installed at the time net-im/telegram-desktop is being built.
Comment 3 Yixun Lan archtester gentoo-dev 2024-01-31 00:31:11 UTC
(In reply to Jesús P Rey (Chuso) from comment #2)
> Yes, I do.
prove it?

> 
> But dev-cpp/expected-lite is only a build-time dependency (DEPEND) for
> dev-cpp/cppgir and not a runtime dependency (RDEPEND).
> 
that's correct

> That doesn't guarantee that dev-cpp/expected-lite is installed at the time
> net-im/telegram-desktop is being built.
so we can say dev-cpp/expected-lite is a implicit build time dependency chain of telegram-desktop (via dev-cpp/cppgir)

I can think of one problem you may encounter, like, install dev-cpp/cppgir via binary pkg format (via BINHOST?) so the dev-cpp/expected-lite is not installed since it's a build time dependency, then later you try to build telegram-desktop from source.. it's kind of mixed installation..

@Esteve for this, I personally don't mind explicitly pull dev-cpp/expected-lite in as a build time dependency, what do you think?
Comment 4 Esteve Varela Colominas 2024-01-31 05:49:19 UTC
Yeah, it makes sense to just add it. I just wish I had an easier way to test for this in the future. Thanks for the report!
Comment 5 Larry the Git Cow gentoo-dev 2024-01-31 09:04:46 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b67e44a0476df7ac55371b5de9b9377fd4c25623

commit b67e44a0476df7ac55371b5de9b9377fd4c25623
Author:     Yixun Lan <dlan@gentoo.org>
AuthorDate: 2024-01-31 09:01:15 +0000
Commit:     Yixun Lan <dlan@gentoo.org>
CommitDate: 2024-01-31 09:04:09 +0000

    net-im/telegram-desktop: version bump 4.14.9 & fix build dep
    
    explicitly add dev-cpp/expected-lite as build dep
    
    Closes: https://bugs.gentoo.org/922920
    Signed-off-by: Yixun Lan <dlan@gentoo.org>

 net-im/telegram-desktop/Manifest                   |   1 +
 .../telegram-desktop-4.14.9.ebuild                 | 238 +++++++++++++++++++++
 2 files changed, 239 insertions(+)