Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 922793 - dev-cpp/highway-1.0.7 fails tests on arm64
Summary: dev-cpp/highway-1.0.7 fails tests on arm64
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: ARM64 Linux
: Normal normal (vote)
Assignee: Daniel Novomeský
URL: https://github.com/google/highway/iss...
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 922229
  Show dependency tree
 
Reported: 2024-01-23 21:47 UTC by matoro
Modified: 2024-02-09 14:10 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log and emerge --info (build.log.gz,180.01 KB, application/gzip)
2024-01-23 21:48 UTC, matoro
Details

Note You need to log in before you can comment on or make changes to this bug.
Description matoro archtester 2024-01-23 21:47:23 UTC
All in NEON code.  Presumably https://github.com/google/highway/issues/1549

99% tests passed, 6 tests failed out of 774

Total Test time (real) =   5.77 sec

The following tests FAILED:
	 91 - HighwayTestGroup/HighwayTest.TestAllIsInf/NEON  # GetParam() = 268435456 (Subprocess aborted)
	 92 - HighwayTestGroup/HighwayTest.TestAllIsInf/NEON_WITHOUT_AES  # GetParam() = 536870912 (Subprocess aborted)
	730 - HwyMathTestGroup/HwyMathTest.TestAllAtan2/NEON  # GetParam() = 268435456 (Subprocess aborted)
	731 - HwyMathTestGroup/HwyMathTest.TestAllAtan2/NEON_WITHOUT_AES  # GetParam() = 536870912 (Subprocess aborted)
	742 - SortTestGroup/SortTest.TestAllFloatInf/NEON  # GetParam() = 268435456 (Subprocess aborted)
	743 - SortTestGroup/SortTest.TestAllFloatInf/NEON_WITHOUT_AES  # GetParam() = 536870912 (Subprocess aborted)

Reproducible: Always
Comment 1 matoro archtester 2024-01-23 21:48:24 UTC
Created attachment 883010 [details]
build.log and emerge --info
Comment 2 Daniel Novomeský 2024-01-23 22:02:00 UTC
Do you have an opportunity to check if applying the patch from
https://github.com/google/highway/commit/45eea15b5488f3e7a15c2c94ac77bd9e99703203

would help the tests to pass?
Comment 3 matoro archtester 2024-01-24 00:54:35 UTC
(In reply to Daniel Novomeský from comment #2)
> Do you have an opportunity to check if applying the patch from
> https://github.com/google/highway/commit/
> 45eea15b5488f3e7a15c2c94ac77bd9e99703203
> 
> would help the tests to pass?

Yes, checked and confirmed it applies cleanly and fixes the issue.
Comment 4 Larry the Git Cow gentoo-dev 2024-02-09 14:10:18 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=75145e4759c8e12bf8994889ee69c24bacf1c4d5

commit 75145e4759c8e12bf8994889ee69c24bacf1c4d5
Author:     Daniel Novomeský <dnovomesky@gmail.com>
AuthorDate: 2024-01-25 11:55:42 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2024-02-09 14:09:49 +0000

    dev-cpp/highway: revbump for UB case fix
    
    Closes: https://bugs.gentoo.org/922793
    Signed-off-by: Daniel Novomeský <dnovomesky@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/35005
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 ...ay-1.0.7-Fix_UB_case_with_signed_overflow.patch | 29 +++++++++++++++
 dev-cpp/highway/highway-1.0.7-r1.ebuild            | 41 ++++++++++++++++++++++
 2 files changed, 70 insertions(+)