Hello! I'm running completely Xorg-less system, and I used dev-libs/girara on it (with zathura) without any issues - it compiled and run successfully without x11-base/xorg-proto. After commit https://gitweb.gentoo.org/repo/gentoo.git/commit/dev-libs/girara?id=81e700213dba4fce523e2b99e3379efea316dd2e, it started to require x11-base/xorg-proto unconditionally. Please, revert this commit, or, at least, add X useflag to the ebuild.
The only mention of X11 in girara sources, which I can find, is guarded by GDK_WINDOWING_X11 - which is not set with gtk[-X]. I guess, it should be considered as automagic dep, then, as there are no checks in meson file.
CC'ing author of commit. It doesn't appear to use headers that xorg-proto includes. https://github.com/search?q=repo%3Apwmt%2Fgirara+%2F%23include%3C%28X11%7CGL%29%2F&type=code
Okay, there are indeed two possibilities here. 1: the pkgconfig check is indeed tied to gtk+, which will then require whatever gtk+ was built with. 2: it's just a test dep, seeing how gtk+[X] is required for tests. The 1st one is a bit annoying and not much that can be done in the ebuild side for it, but then again it should really only affect tinderbox-builds (and maybe when flipping X/wayland system-wide). For the 2nd I'll update the ebuild.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b58ff0d1b59c5a4fb76eba09f33261a662451b61 commit b58ff0d1b59c5a4fb76eba09f33261a662451b61 Author: Joonas Niilola <juippis@gentoo.org> AuthorDate: 2024-01-23 06:49:44 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2024-01-23 06:49:44 +0000 dev-libs/girara: move xorg-proto dep under 'test' USE - soft update for 81e700213dba4fce523e2b99e3379efea316dd2e. Closes: https://bugs.gentoo.org/922722 Signed-off-by: Joonas Niilola <juippis@gentoo.org> dev-libs/girara/girara-0.4.0-r1.ebuild | 2 +- dev-libs/girara/girara-0.4.2.ebuild | 2 +- dev-libs/girara/girara-9999.ebuild | 10 +++++----- 3 files changed, 7 insertions(+), 7 deletions(-)
