Bug 922622 – sys-apps/iproute2-6.6.0-r3 - In file included from vlan.c:14: ../include/json_print.h: In function 'print_tv': ../include/json_print.h:58:48: error: passing argument 5 of 'print_color_tv' from incompatible pointer type [-Wincompatible-pointer-types]

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description ernsteiswuerfel 2024-01-21 14:02:57 UTC]

Created attachment 882777 [details]
build.log (ppc, 6.6.0-r3)

[...]
powerpc-gentoo-linux-musl-gcc -Wall -Wstrict-prototypes  -Wmissing-prototypes -Wmissing-declarations -Wold-style-definition -Wformat=2 -Os -mcpu=7450 -mtune=7450 -pipe  -pipe -I../include -I../include/uapi -DRESOLVE_HOSTNAMES -DLIBDIR=\"/usr/lib\" -DCONF_USR_DIR=\"/usr/share/iproute2\" -DCONF_ETC_DIR=\"/etc/iproute2\" -DNETNS_RUN_DIR=\"/run/netns\" -DNETNS_ETC_DIR=\"/etc/netns\" -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -Os -mcpu=7450 -mtune=7450 -pipe -DHAVE_HANDLE_AT -DHAVE_HANDLE_AT -DHAVE_SETNS -DHAVE_SETNS -DHAVE_LIBMNL -DHAVE_LIBMNL   -c -o vlan.o vlan.c
In file included from vlan.c:14:
../include/json_print.h:80:30: warning: 'struct timeval' declared inside parameter list will not be visible outside of this definition or declaration
   80 | _PRINT_FUNC(tv, const struct timeval *)
      |                              ^~~~~~~
../include/json_print.h:50:37: note: in definition of macro '_PRINT_FUNC'
   50 |                                     type value);                        \
      |                                     ^~~~
../include/json_print.h:80:30: warning: 'struct timeval' declared inside parameter list will not be visible outside of this definition or declaration
   80 | _PRINT_FUNC(tv, const struct timeval *)
      |                              ^~~~~~~
../include/json_print.h:55:45: note: in definition of macro '_PRINT_FUNC'
   55 |                                             type value)                 \
      |                                             ^~~~
../include/json_print.h: In function 'print_tv':
../include/json_print.h:58:48: error: passing argument 5 of 'print_color_tv' from incompatible pointer type [-Wincompatible-pointer-types]
   58 |                                                value);                  \
      |                                                ^~~~~
      |                                                |
      |                                                const struct timeval *
../include/json_print.h:80:1: note: in expansion of macro '_PRINT_FUNC'
   80 | _PRINT_FUNC(tv, const struct timeval *)
      | ^~~~~~~~~~~
../include/json_print.h:50:42: note: expected 'const struct timeval *' but argument is of type 'const struct timeval *'
   50 |                                     type value);                        \
      |                                          ^
../include/json_print.h:80:1: note: in expansion of macro '_PRINT_FUNC'
   80 | _PRINT_FUNC(tv, const struct timeval *)
      | ^~~~~~~~~~~
make[1]: *** [../config.include:24: vlan.o] Error 1
make[1]: Leaving directory '/var/tmp/portage/sys-apps/iproute2-6.6.0-r3/work/iproute2-6.6.0/bridge'
make: *** [Makefile:78: all] Error 2
 * ERROR: sys-apps/iproute2-6.6.0-r3::gentoo failed (compile phase):

[Comment 1 ernsteiswuerfel 2024-01-21 14:03:35 UTC]

Created attachment 882778 [details]
emerge --info

[Comment 2 Gabi Falk 2024-05-10 14:46:51 UTC]

This bug is reproducible on the musl systems, but not on the glibc systems.  I've made a patch and sent it upstream:

https://lore.kernel.org/netdev/[e-mail]/T/#u

[Comment 3 ernsteiswuerfel 2024-05-11 11:10:08 UTC]

Thanks!

[Comment 4 Larry the Git Cow 2024-05-21 11:48:56 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f51d73e7859d3df6589908082be198bdc34e4871

commit f51d73e7859d3df6589908082be198bdc34e4871
Author:     Gabi Falk <[e-mail]>
AuthorDate: 2024-05-11 09:00:00 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-05-21 11:48:20 +0000

    sys-apps/iproute2: fix compilation on musl-based systems with modern C (C99)
    
    Closes: https://bugs.gentoo.org/922622
    Signed-off-by: Gabi Falk <[e-mail]>
    Closes: https://github.com/gentoo/gentoo/pull/36638
    Signed-off-by: Sam James <[e-mail]>

 .../iproute2/files/iproute2-6.6.0-musl-c99.patch   | 75 ++++++++++++++++++++++
 sys-apps/iproute2/iproute2-6.6.0-r1.ebuild         |  1 +
 sys-apps/iproute2/iproute2-6.6.0-r3.ebuild         |  1 +
 sys-apps/iproute2/iproute2-6.6.0.ebuild            |  1 +
 sys-apps/iproute2/iproute2-6.8.0-r2.ebuild         |  1 +
 5 files changed, 79 insertions(+)

[Comment 5 Larry the Git Cow 2024-10-31 22:27:57 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ec79c30ea4476a71b8b15ad7674b3117cce7041a

commit ec79c30ea4476a71b8b15ad7674b3117cce7041a
Author:     Andreas K. Hüttel <[e-mail]>
AuthorDate: 2024-10-31 22:18:16 +0000
Commit:     Andreas K. Hüttel <[e-mail]>
CommitDate: 2024-10-31 22:27:43 +0000

    sys-apps/iproute2: drop 6.6.0, 6.6.0-r1
    
    Bug: https://bugs.gentoo.org/922622
    Signed-off-by: Andreas K. Hüttel <[e-mail]>

 sys-apps/iproute2/iproute2-6.6.0-r1.ebuild | 216 -----------------------------
 sys-apps/iproute2/iproute2-6.6.0.ebuild    | 215 ----------------------------
 2 files changed, 431 deletions(-)