Bug 922621 – media-video/ffmpeg-6.0.1-r1 - .../libavcodec/pcm-bluray.c: In function 'pcm_bluray_decode_frame': src/libavcodec/pcm-bluray.c:170:45: error: passing argument 2 of 'bytestream2_get_buffer' from incompatible pointer type [-Wincompatible-pointer-types]

• Status: UNCONFIRMED
• Product: Gentoo Linux

[Description ernsteiswuerfel 2024-01-21 13:44:59 UTC]

Created attachment 882775 [details]
build.log.xz (ppc, 6.0.1-r1)

Same for 6.0-r11, so no regression.

[...]
powerpc-gentoo-linux-musl-gcc -I. -Isrc/ -D_ISOC99_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600 -DPIC -DZLIB_CONST -DHAVE_AV_CONFIG_H -DBUILDING_avcodec -O2 -mcpu=7450 -mtune=7450 -pipe   -mcpu=7450 -std=c11 -fPIC -maltivec -mabi=altivec    -pthread    -I/usr/include/libdrm  -I/usr/include/freetype2 -I/usr/include/harfbuzz -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/opus -I/usr/include/opus -D_REENTRANT   -I/usr/include/webp -I/usr/include/webp      -I/usr/include/libdrm -Wdeclaration-after-statement -Wall -Wdisabled-optimization -Wpointer-arith -Wredundant-decls -Wwrite-strings -Wtype-limits -Wundef -Wmissing-prototypes -Wstrict-prototypes -Wempty-body -Wno-parentheses -Wno-switch -Wno-format-zero-length -Wno-pointer-sign -Wno-unused-const-variable -Wno-bool-operation -Wno-char-subscripts -O2 -mcpu=7450 -mtune=7450 -pipe -fno-math-errno -fno-signed-zeros -fno-tree-vectorize -Werror=format-security -Werror=implicit-function-declaration -Werror=missing-prototypes -Werror=return-type -Werror=vla -Wformat -Wno-maybe-uninitialized   -MMD -MF libavcodec/pcm-bluray.d -MT libavcodec/pcm-bluray.o -c -o libavcodec/pcm-bluray.o src/libavcodec/pcm-bluray.c
src/libavcodec/pcm-bluray.c: In function 'pcm_bluray_decode_frame':
src/libavcodec/pcm-bluray.c:170:45: error: passing argument 2 of 'bytestream2_get_buffer' from incompatible pointer type [-Wincompatible-pointer-types]
  170 |                 bytestream2_get_buffer(&gb, dst16, buf_size);
      |                                             ^~~~~
      |                                             |
      |                                             int16_t * {aka short int *}
In file included from src/libavcodec/pcm-bluray.c:29:
src/libavcodec/bytestream.h:268:70: note: expected 'uint8_t *' {aka 'unsigned char *'} but argument is of type 'int16_t *' {aka 'short int *'}
  268 |                                                             uint8_t *dst,
      |                                                             ~~~~~~~~~^~~
src/libavcodec/pcm-bluray.c:190:49: error: passing argument 2 of 'bytestream2_get_buffer' from incompatible pointer type [-Wincompatible-pointer-types]
  190 |                     bytestream2_get_buffer(&gb, dst16, avctx->ch_layout.nb_channels * 2);
      |                                                 ^~~~~
      |                                                 |
      |                                                 int16_t * {aka short int *}
src/libavcodec/bytestream.h:268:70: note: expected 'uint8_t *' {aka 'unsigned char *'} but argument is of type 'int16_t *' {aka 'short int *'}
  268 |                                                             uint8_t *dst,
      |                                                             ~~~~~~~~~^~~
make: *** [/var/tmp/portage/media-video/ffmpeg-6.0.1-r1/work/ffmpeg-6.0.1/ffbuild/common.mak:81: libavcodec/pcm-bluray.o] Error 1
 * ERROR: media-video/ffmpeg-6.0.1-r1::gentoo failed (compile phase):

[Comment 1 ernsteiswuerfel 2024-01-21 13:46:03 UTC]

Created attachment 882776 [details]
emerge --info

[Comment 2 Kostadin Shishmanov 2024-02-07 15:48:30 UTC]

Created attachment 884475 [details, diff]
patch from fedora

Can you test the attached patch? It's taken from fedora but it has the stuff that is already in gentoo and a test that might be 6.1+ only removed.

https://src.fedoraproject.org/rpms/ffmpeg/blob/rawhide/f/ffmpeg-gcc14.patch

[Comment 3 ernsteiswuerfel 2024-02-08 21:29:01 UTC]

(In reply to Kostadin Shishmanov from comment #2)
> Created attachment 884475 [details, diff] [details, diff]
> patch from fedora
> 
> Can you test the attached patch? It's taken from fedora but it has the stuff
> that is already in gentoo and a test that might be 6.1+ only removed.
Thanks Kostadin! The linked patch fixes the build on ppc. Though I had to rip out the vulkan parts of the patch to make it cleanly apply on ppc.