QA checks report (see URL): games-board/cockatrice/files/cockatrice-2.9.0-support-protobuf-23.patch: application/x-tar; charset=binary (size=10240) The file is a tar archive indeed: $ file files/cockatrice-2.9.0-support-protobuf-23.patch files/cockatrice-2.9.0-support-protobuf-23.patch: POSIX tar archive (GNU) $ tar tvf files/cockatrice-2.9.0-support-protobuf-23.patch -rw-r--r-- ask/syncthing 4896 2023-11-29 13:28 cockatrice-2.9.0-support-protobuf-23.patch
Lost in translation I guess https://github.com/gentoo/gentoo/pull/34008#issuecomment-1831806037 Surprised I missed this and that patch accepts it.
No, its mistake from me with making a tar.gz but not reflecting it in the file name. Meaning that the tar header got left in the file when guillaumeseren uncompressed it.
Hey, I am just looking at this, if it doesn't break anything, should we do something about it, I mean before the next version.
Yes, it should be fixed as soon as possible. binary files in the repo violate QA rules.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ad57df48cafcb1c8591a50ff1969cae990ccb4a0 commit ad57df48cafcb1c8591a50ff1969cae990ccb4a0 Author: James Le Cuirot <chewi@gentoo.org> AuthorDate: 2024-01-20 17:24:35 +0000 Commit: James Le Cuirot <chewi@gentoo.org> CommitDate: 2024-01-20 17:24:35 +0000 games-board/cockatrice: Extract patch that was accidentally added as a tar Closes: https://bugs.gentoo.org/922539 Signed-off-by: James Le Cuirot <chewi@gentoo.org> .../files/cockatrice-2.9.0-support-protobuf-23.patch | Bin 10240 -> 4896 bytes 1 file changed, 0 insertions(+), 0 deletions(-)
Sorry, don't know how I missed that. Perhaps because binaries barely show up in git log.
