Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 922533 - app-portage/emlop-0.6.1 fails tests (MUSL-SYSTEM): error: test failed, to rerun pass --bin emlop
Summary: app-portage/emlop-0.6.1 fails tests (MUSL-SYSTEM): error: test failed, to rer...
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Vincent de Phily
URL:
Whiteboard:
Keywords: PullRequest, TESTFAILURE
Depends on:
Blocks:
 
Reported: 2024-01-20 11:57 UTC by Agostino Sarubbo
Modified: 2024-03-05 11:23 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,182.83 KB, text/plain)
2024-01-20 11:58 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2024-01-20 11:57:59 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-portage/emlop-0.6.1 fails tests (MUSL-SYSTEM).
Discovered on: amd64 (internal ref: tinderbox_musl)

NOTE:
(MUSL-SYSTEM) in the summary means that bug was found on a machine that runs MUSL libc but this bug MAY or MAY NOT BE related to musl.
Comment 1 Agostino Sarubbo gentoo-dev 2024-01-20 11:58:02 UTC
Created attachment 882687 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2024-01-20 11:58:03 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


thread 'proces::tests::start_time' panicked at src/proces.rs:160:9:
error: test failed, to rerun pass `--bin emlop`
Comment 3 Vincent de Phily 2024-01-20 17:21:28 UTC
I don't think this failure is related to musl, just to running the tests on a very busy sytem. This unittest compares emlop's process-listing implementation with the standard ps binary. As that's inherently racy (ps and the emlop function don't run exactly at the same time, and therefore don't see the same processes), I've used an error count threshold to consider the test failed. But tinderbox is busy enough to smash that threshold.

Not sure what the best fix is. Raising the treshold could hide bugs. I could try to make the test less racy, but that'll only work up to a point. Safest bet would be to just skip this test when running from emerge (I already ignore tests that depend on no emerge process running, but do run those tests in the CI).

I'll #[ignore] that test in a future release of emlop. In the meantime for the 0.6.1 ebuild, you can skip that test by replacing `cargo test` with `cargo test -- --skip process::tests::start_time`.
Comment 4 Larry the Git Cow gentoo-dev 2024-03-05 11:23:40 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=56b6320b05c56ea53a1ab7ba3f22db1eef8ddec9

commit 56b6320b05c56ea53a1ab7ba3f22db1eef8ddec9
Author:     Vincent de Phily <moltonel@gmail.com>
AuthorDate: 2024-03-05 10:26:39 +0000
Commit:     Florian Schmaus <flow@gentoo.org>
CommitDate: 2024-03-05 11:23:23 +0000

    app-portage/emlop: add 0.7.0
    
    Bug: https://bugs.gentoo.org/922533
    Signed-off-by: Vincent de Phily <moltonel@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/35625
    Signed-off-by: Florian Schmaus <flow@gentoo.org>

 app-portage/emlop/Manifest           |  68 +++++++++++++++++++
 app-portage/emlop/emlop-0.7.0.ebuild | 126 +++++++++++++++++++++++++++++++++++
 2 files changed, 194 insertions(+)