Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 922500 - gnome2-utils.eclass: gnome2_gdk_pixbuf_update unnecessarily requires plugin list from gnome2_gdk_pixbuf_savelist
Summary: gnome2-utils.eclass: gnome2_gdk_pixbuf_update unnecessarily requires plugin l...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-01-19 13:46 UTC by Michał Górny
Modified: 2024-02-06 03:07 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-01-19 13:46:30 UTC
gnome2_gdk_pixbuf_update refuses to update the plugin cache unless GNOME2_ECLASS_GDK_PIXBUF_LOADERS is set to a list of plugins (by gnome2_gdk_pixbuf_savelist).  However, the list itself is never used, and this behavior is inconsistent with xdg_* function behavior.

How would you feel about making gnome2_gdk_pixbuf_update do the update unconditionally, and guarding it inside gnome2.eclass instead?
Comment 1 Larry the Git Cow gentoo-dev 2024-02-06 03:07:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=442e4c25bbb4e5e28984dbeb8e1468ded3bd273d

commit 442e4c25bbb4e5e28984dbeb8e1468ded3bd273d
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2024-01-25 15:37:00 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2024-02-06 03:07:32 +0000

    gnome2-utils.eclass: Make *_gdk_pixbuf_update work unconditionally
    
    Remove the GNOME2_ECLASS_GDK_PIXBUF_LOADERS condition that required
    calling gnome2_gdk_pixbuf_savelist prior to gnome2_gdk_pixbuf_update.
    The actual list was never used, and all the ebuilds calling the function
    in Gentoo contain conditions to avoid calling the function when loaders
    are not built.
    
    Closes: https://bugs.gentoo.org/922500
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 eclass/gnome2-utils.eclass | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)