java-pkg-simple.eclass has some tests like: if [[ java-pkg_get-target -lt 9 ]] Which does not work as intended, as the string 'java-pkg_get-target' is missing $(..) around it. When I added it, I noticed other shortcomings and fixed them. See patches attached. :) Reproducible: Always
Created attachment 882311 [details, diff] make code related to java 9+ actually execute
Created attachment 882312 [details, diff] cut possible prefix to allow integer comparison
Created attachment 882313 [details, diff] improve decision when to use --module-path
(In reply to Manuel Mommertz from comment #0) > java-pkg-simple.eclass has some tests like: > > if [[ java-pkg_get-target -lt 9 ]] > > Which does not work as intended, as the string 'java-pkg_get-target' is > missing $(..) around it. When I added it, I noticed other shortcomings and > fixed them. See patches attached. :) > > Reproducible: Always How did you discovery this issue, is/are there any package(s) affected by it?
I worked on an own ebuild, had some difficulties (unrelated) and looked at the sources to understand how exactly the eclass works. Then stumbled over this test by pure luck. ;)
Would it even solve bug #853151?
(In reply to Volkmar W. Pogatzki from comment #6) > Would it even solve bug #853151? No, that bug seems unrelated.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6b8564a70b0914325d4b41039012d6e639511e5d commit 6b8564a70b0914325d4b41039012d6e639511e5d Author: Manuel Mommertz <manuel.mommertz@desy.de> AuthorDate: 2024-01-17 13:24:16 +0000 Commit: Miroslav Šulc <fordfrog@gentoo.org> CommitDate: 2024-01-19 12:43:46 +0000 java-pkg-simple.eclass: improve decision when to use --module-path Closes: https://bugs.gentoo.org/922157 Signed-off-by: Manuel Mommertz <manuel.mommertz@desy.de> Closes: https://github.com/gentoo/gentoo/pull/34866 Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org> eclass/java-pkg-simple.eclass | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
