Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 921720 - kde-apps/kate-lib-23.08.4 w/o precompiled headers: apps/lib/ktexteditor_utils.h:97:21: error: ‘QWidgetList’ does not name a type; did you mean ‘QWidget’?
Summary: kde-apps/kate-lib-23.08.4 w/o precompiled headers: apps/lib/ktexteditor_utils...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL: https://invent.kde.org/utilities/kate...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2024-01-10 18:18 UTC by richard+gentoo-bugzilla
Modified: 2024-01-12 16:59 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info '=kde-apps/kate-lib-23.08.4::gentoo' (emerge-info.txt,9.82 KB, text/plain)
2024-01-10 18:20 UTC, richard+gentoo-bugzilla
Details
emerge -pqv '=kde-apps/kate-lib-23.08.4::gentoo' (emerge-pqv.txt,1.13 KB, text/plain)
2024-01-10 18:20 UTC, richard+gentoo-bugzilla
Details
build.log (build.log,223.67 KB, text/x-log)
2024-01-10 18:21 UTC, richard+gentoo-bugzilla
Details
patch adding the missing includes (kate-lib-23.08.4-missing-includes.patch,295 bytes, patch)
2024-01-12 06:53 UTC, Joshua Clayton
Details | Diff
updated ebuild. (kate-lib-23.08.4-r1.ebuild,1.98 KB, text/plain)
2024-01-12 06:55 UTC, Joshua Clayton
Details

Note You need to log in before you can comment on or make changes to this bug.
Description richard+gentoo-bugzilla 2024-01-10 18:18:15 UTC
I just tried to update my system and kde-apps/kate-lib-23.08.4 does not compile.

The following error occurs multiple times during build:
/var/tmp/portage/kde-apps/kate-lib-23.08.4/work/kate-23.08.4/apps/lib/ktexteditor_utils.h:97:21: error: ‘QWidgetList’ does not name a type; did you mean ‘QWidget’?
   97 | KATE_PRIVATE_EXPORT QWidgetList widgets(KTextEditor::MainWindow *mainWindow);
      |                     ^~~~~~~~~~~
      |                     QWidget
Comment 1 richard+gentoo-bugzilla 2024-01-10 18:20:02 UTC
Created attachment 881865 [details]
emerge --info '=kde-apps/kate-lib-23.08.4::gentoo'
Comment 2 richard+gentoo-bugzilla 2024-01-10 18:20:35 UTC
Created attachment 881866 [details]
emerge -pqv '=kde-apps/kate-lib-23.08.4::gentoo'
Comment 3 richard+gentoo-bugzilla 2024-01-10 18:21:12 UTC
Created attachment 881867 [details]
build.log
Comment 4 Scott Alfter 2024-01-10 20:36:12 UTC
I ran into the same problem...masking the package on my system for now to see if I can work around the brokenness that way.
Comment 5 Plüss Roland 2024-01-11 14:33:02 UTC
Masking is unfortunately not helping since KDE -> Kate -> hard-depends on it
Comment 6 Scott Alfter 2024-01-11 16:08:28 UTC
Masking the package was more about getting the rest of an "emerge @world" to complete without error.  

Adding MYCMAKEARGS="-DCMAKE_DISABLE_PRECOMPILE_HEADERS=OFF" to /etc/portage/make.conf will allow kate-lib to build; it basically negates the change made in https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3867345f8c2d9f24157508bc6372f479a82cf33f.
Comment 7 Arsen Arsenović gentoo-dev 2024-01-11 19:18:43 UTC
i reckon they forgot an include, when building with PCH, cmake will auto-'-include' the pch file they generated
Comment 8 Paul Gover 2024-01-11 19:57:16 UTC
Me too, except the message in my case is 'unknown type name "QtWidgetList"' and similar for QtUrl.  I'm using clang, if that's relevant.
Comment 9 Arsen Arsenović gentoo-dev 2024-01-11 20:21:51 UTC
that's the same error
Comment 10 Joshua Clayton 2024-01-12 06:51:07 UTC
Arsen Arsenović, you were right. Its a 2 line fix. Took longer to remember how to format the filenames for portage than to make the correction.
Comment 11 Joshua Clayton 2024-01-12 06:53:15 UTC
Created attachment 881995 [details, diff]
patch adding the missing includes
Comment 12 Joshua Clayton 2024-01-12 06:55:15 UTC
Created attachment 881996 [details]
updated ebuild.

uploaded patch and ebuild.  Works on my machine
Comment 13 Manuel Mommertz 2024-01-12 08:44:40 UTC
Same patch is needed / works for kate, kate-addons and kwrite.
Comment 14 Larry the Git Cow gentoo-dev 2024-01-12 09:24:43 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=caa998c2d10707501e91293540c25936b5fd8ae9

commit caa998c2d10707501e91293540c25936b5fd8ae9
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-01-12 09:21:26 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-12 09:21:50 +0000

    kde-apps/kate-lib: fix no-PCH build
    
    Closes: https://bugs.gentoo.org/921720
    Signed-off-by: Sam James <sam@gentoo.org>

 kde-apps/kate-lib/files/kate-23.08.4-no-pch.patch | 58 +++++++++++++++++++++++
 kde-apps/kate-lib/kate-lib-23.08.4.ebuild         |  4 ++
 2 files changed, 62 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6016f0772a62899d691b16037b4ec41289ba9e0e

commit 6016f0772a62899d691b16037b4ec41289ba9e0e
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-01-12 09:20:24 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-12 09:21:50 +0000

    kde-apps/kwrite: fix no-PCH build
    
    Closes: https://bugs.gentoo.org/921720
    Signed-off-by: Sam James <sam@gentoo.org>

 kde-apps/kwrite/files/kate-23.08.4-no-pch.patch | 58 +++++++++++++++++++++++++
 kde-apps/kwrite/kwrite-23.08.4.ebuild           |  4 ++
 2 files changed, 62 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b875567958605ab7edc00b638fcd3769e55a11a6

commit b875567958605ab7edc00b638fcd3769e55a11a6
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-01-12 09:19:39 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-12 09:21:49 +0000

    kde-apps/kate-addons: fix no-PCH build
    
    Closes: https://bugs.gentoo.org/921720
    Signed-off-by: Sam James <sam@gentoo.org>

 .../kate-addons/files/kate-23.08.4-no-pch.patch    | 58 ++++++++++++++++++++++
 kde-apps/kate-addons/kate-addons-23.08.4.ebuild    |  4 ++
 2 files changed, 62 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bde55b940d90885e1b8f51c8e6b4f0d87e6eea97

commit bde55b940d90885e1b8f51c8e6b4f0d87e6eea97
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-01-12 09:18:32 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-12 09:21:49 +0000

    kde-apps/kate: fix no-PCH build
    
    Closes: https://bugs.gentoo.org/921720
    Signed-off-by: Sam James <sam@gentoo.org>

 kde-apps/kate/files/kate-23.08.4-no-pch.patch | 58 +++++++++++++++++++++++++++
 kde-apps/kate/kate-23.08.4.ebuild             |  4 ++
 2 files changed, 62 insertions(+)
Comment 15 Plüss Roland 2024-01-12 12:02:14 UTC
It's still not working. The error is now different (in kde-apps/kate-addons-23.08.4 now):

In file included from /extension/tmp_portage/portage/kde-apps/kate-addons-23.08.4/work/kate-23.08.4/addons/project/kateprojectview.h:10,
                 from /extension/tmp_portage/portage/kde-apps/kate-addons-23.08.4/work/kate-23.08.4/addons/project/kateprojectview.cpp:8:
/extension/tmp_portage/portage/kde-apps/kate-addons-23.08.4/work/kate-23.08.4/addons/project/kateproject.h:10:5: warning: "QT_VERSION" is not defined, evaluates to 0 [-Wundef]
   10 | #if QT_VERSION < QT_VERSION_CHECK(6, 0, 0)
      |     ^~~~~~~~~~
/extension/tmp_portage/portage/kde-apps/kate-addons-23.08.4/work/kate-23.08.4/addons/project/kateproject.h:10:18: warning: "QT_VERSION_CHECK" is not defined, evaluates to 0 [-Wundef]
   10 | #if QT_VERSION < QT_VERSION_CHECK(6, 0, 0)
      |                  ^~~~~~~~~~~~~~~~
/extension/tmp_portage/portage/kde-apps/kate-addons-23.08.4/work/kate-23.08.4/addons/project/kateproject.h:10:34: error: missing binary operator before token "("
   10 | #if QT_VERSION < QT_VERSION_CHECK(6, 0, 0)
      |                                  ^
/extension/tmp_portage/portage/kde-apps/kate-addons-23.08.4/work/kate-23.08.4/addons/project/kateproject.h:279:92: error: ‘KTextEditor::ModificationInterface’ has not been declared
  279 |     void slotModifiedOnDisk(KTextEditor::Document *document, bool isModified, KTextEditor::ModificationInterface::ModifiedOnDiskReason reason);
      |                                                                                            ^~~~~~~~~~~~~~~~~~~~~
/extension/tmp_portage/portage/kde-apps/kate-addons-23.08.4/work/kate-23.08.4/addons/project/kateproject.h:279:136: error: expected ‘,’ or ‘...’ before ‘reason’
  279 |     void slotModifiedOnDisk(KTextEditor::Document *document, bool isModified, KTextEditor::ModificationInterface::ModifiedOnDiskReason reason);
      |                                                                                                                                        ^~~~~~
Comment 16 richard+gentoo-bugzilla 2024-01-12 12:13:25 UTC
I can't confirm the last comment by Roland. I just synced, removed the temporary MYCMAKEARGS patch by Scott and built kate, kate-addons and kate-lib. All three built just fine.
Comment 17 andre.goessel 2024-01-12 13:00:10 UTC
I can confirm the comment from Roland, on my side kate-addons has the same problem with the QT version check.
Comment 18 richard+gentoo-bugzilla 2024-01-12 13:06:12 UTC
Alright, could one of you please open a new bug at https://packages.gentoo.org/packages/kde-apps/kate-addons?
Comment 19 Larry the Git Cow gentoo-dev 2024-01-12 16:59:12 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fcc58d11dfd83610f3f3df8e98e7f9ebf593b830

commit fcc58d11dfd83610f3f3df8e98e7f9ebf593b830
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-01-12 16:58:59 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-12 16:58:59 +0000

    kde-apps/kate-lib: further no-pch fixes
    
    Closes: https://bugs.gentoo.org/921935
    Bug: https://bugs.gentoo.org/921720
    Signed-off-by: Sam James <sam@gentoo.org>

 kde-apps/kate-lib/files/kate-23.08.4-no-pch.patch | 56 ++++++++++++++++++-----
 1 file changed, 44 insertions(+), 12 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c3ff857b56efb6bb7c011432f5e41544471b5591

commit c3ff857b56efb6bb7c011432f5e41544471b5591
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-01-12 16:58:39 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-12 16:58:39 +0000

    kde-apps/kwrite: further no-pch fixes
    
    Closes: https://bugs.gentoo.org/921935
    Bug: https://bugs.gentoo.org/921720
    Signed-off-by: Sam James <sam@gentoo.org>

 kde-apps/kwrite/files/kate-23.08.4-no-pch.patch | 56 +++++++++++++++++++------
 1 file changed, 44 insertions(+), 12 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ebfa971a8b829712595c108ab9f3523cead261ca

commit ebfa971a8b829712595c108ab9f3523cead261ca
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-01-12 16:58:21 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-12 16:58:21 +0000

    kde-apps/kate-addons: further no-pch fixes
    
    Closes: https://bugs.gentoo.org/921935
    Bug: https://bugs.gentoo.org/921720
    Signed-off-by: Sam James <sam@gentoo.org>

 .../kate-addons/files/kate-23.08.4-no-pch.patch    | 56 +++++++++++++++++-----
 1 file changed, 44 insertions(+), 12 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fefe28433c4c61ce7f13aaf3fa4aab292e49d4cb

commit fefe28433c4c61ce7f13aaf3fa4aab292e49d4cb
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-01-12 16:57:32 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-12 16:57:32 +0000

    kde-apps/kate: further no-pch fixes
    
    Closes: https://bugs.gentoo.org/921935
    Bug: https://bugs.gentoo.org/921720
    Signed-off-by: Sam James <sam@gentoo.org>

 kde-apps/kate/files/kate-23.08.4-no-pch.patch | 56 +++++++++++++++++++++------
 1 file changed, 44 insertions(+), 12 deletions(-)