Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 921566 - games-emulation/yuzu-9999: build fails without cubeb use flag
Summary: games-emulation/yuzu-9999: build fails without cubeb use flag
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: GURU project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-07 15:25 UTC by Esad Katmer
Modified: 2024-01-08 07:22 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge--info.txt,6.17 KB, text/plain)
2024-01-07 15:26 UTC, Esad Katmer
Details
build log (build.log,12.50 KB, text/x-log)
2024-01-07 15:26 UTC, Esad Katmer
Details
die only if sed command fails (fix-building-without-cubeb.patch,526 bytes, patch)
2024-01-07 15:30 UTC, Esad Katmer
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Esad Katmer 2024-01-07 15:25:54 UTC
You can use 'sdl2' in 'Emulation -> Configure -> Audio -> Output Engine'.

Building without 'cubeb' makes 'Output Engine' options to
- auto
- sdl2
- null

I think with commit https://gitweb.gentoo.org/repo/proj/guru.git/commit/games-emulation/yuzu/yuzu-9999.ebuild?id=b00e62a18c6be01c5693346c8f448bffbf768828 intended purpose was to add 'find_package(Threads REQUIRED)' to the end of file.

This line causes systems configured without cubeb use flag to fail.

Reproducible: Always

Steps to Reproduce:
1. add use flag -cubeb to your package.use file
```package.use
games-emulation/yuzu -cubeb
```

2. emerge -1q =games-emulation/yuzu-9999
Actual Results:  
fails to compile

Expected Results:  
compile succeded
Comment 1 Esad Katmer 2024-01-07 15:26:16 UTC
Created attachment 881597 [details]
emerge --info
Comment 2 Esad Katmer 2024-01-07 15:26:31 UTC
Created attachment 881598 [details]
build log
Comment 3 Esad Katmer 2024-01-07 15:30:01 UTC
Created attachment 881599 [details, diff]
die only if sed command fails

die only if sed command fails to add 

  find_package(Threads REQUIRED)

line to end of 'CMakeLists.txt' file
Comment 4 Esad Katmer 2024-01-07 15:36:26 UTC
Upstream already includes below line.

  find_package(Threads REQUIRED)

I might be missing something, but is it necessary to add again?

see:
- https://github.com/yuzu-emu/yuzu/blob/ecfba79d987b68a2ec1a4cc524e9303e48f398cb/CMakeLists.txt#L577
- https://github.com/yuzu-emu/yuzu-mainline/blob/ecfba79d987b68a2ec1a4cc524e9303e48f398cb/CMakeLists.txt#L577
Comment 5 Larry the Git Cow gentoo-dev 2024-01-08 07:22:15 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=2c36fd3324a5c88d1cc6db39d09e1a5d4118deaf

commit 2c36fd3324a5c88d1cc6db39d09e1a5d4118deaf
Author:     Takuya Wakazono <pastalian46@gmail.com>
AuthorDate: 2024-01-08 06:03:40 +0000
Commit:     Takuya Wakazono <pastalian46@gmail.com>
CommitDate: 2024-01-08 06:03:40 +0000

    games-emulation/yuzu: fix build with USE=-cubeb
    
    Closes: https://bugs.gentoo.org/921566
    Signed-off-by: Takuya Wakazono <pastalian46@gmail.com>

 games-emulation/yuzu/yuzu-0_p20230202.ebuild | 5 +----
 games-emulation/yuzu/yuzu-9999.ebuild        | 3 +--
 2 files changed, 2 insertions(+), 6 deletions(-)