Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 921166 - media-video/handbrake-1.6.1 fails to compile (GCC-14-SYSTEM): muxavformat.c:1209:18: error: implicit declaration of function time [-Wimplicit-function-declaration]
Summary: media-video/handbrake-1.6.1 fails to compile (GCC-14-SYSTEM): muxavformat.c:1...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard: fixed in 1.6.1
Keywords: PATCH
Depends on:
Blocks: c99-porting
  Show dependency tree
 
Reported: 2024-01-01 14:40 UTC by Agostino Sarubbo
Modified: 2024-10-31 22:12 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,106.31 KB, text/plain)
2024-01-01 14:40 UTC, Agostino Sarubbo
Details
backported patch (c99.patch,727 bytes, patch)
2024-01-10 14:02 UTC, Kostadin Shishmanov
Details | Diff
build.log with patch failure (build.log,3.85 KB, text/plain)
2024-10-03 17:53 UTC, Nicole O'Connor
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2024-01-01 14:40:44 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-video/handbrake-1.6.1 fails to compile (GCC-14-SYSTEM).
Discovered on: amd64 (internal ref: gcc14_tinderbox)

NOTE:
(GCC-14-SYSTEM) in the summary means that the bug was found on a machine that runs gcc-14 but this bug MAY or MAY NOT BE related to the new compiler
Comment 1 Agostino Sarubbo gentoo-dev 2024-01-01 14:40:46 UTC
Created attachment 881216 [details]
build.log

build log and emerge --info
Comment 2 H. Peter Pfeufer 2024-01-06 22:38:28 UTC
Getting the same message during compile on GCC 13.

```
 * QA Notice: Package triggers severe warnings which indicate that it
 *            may exhibit random runtime failures.
 * ../libhb/muxavformat.c:1212:5: warning: incompatible implicit declaration of built-in function ‘strftime’ [-Wbuiltin-declaration-mismatch]
```


```
root@thor.walhalla.lan ~ $
» gcc-config -l
 [1] x86_64-pc-linux-gnu-13 *
```


Handbrake compiles and starts, but as soon as I want to start a transcode job it crashes with a segmentation fault.

```
ppfeufer@thor.walhalla.lan ~ $
» ghb

(fr.handbrake.ghb:17948): Gtk-WARNING **: 23:34:37.181: Locale not supported by C library.
        Using the fallback 'C' locale.
Segmentation fault (core dumped)
```
Comment 3 Kostadin Shishmanov 2024-01-10 14:02:29 UTC
Created attachment 881819 [details, diff]
backported patch

This is fixed upstream: https://github.com/HandBrake/HandBrake/commit/5fc06017f40eb152bad36cfa7436a8f50f4ed2ca
Comment 4 Larry the Git Cow gentoo-dev 2024-07-05 09:05:40 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c8e55f2fac7987ceba39f73eebe4a93ca268a16f

commit c8e55f2fac7987ceba39f73eebe4a93ca268a16f
Author:     Miroslav Šulc <fordfrog@gentoo.org>
AuthorDate: 2024-07-05 09:05:16 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2024-07-05 09:05:16 +0000

    media-video/handbrake: added missing includes + scrubbed patches
    
    Closes: https://bugs.gentoo.org/921166
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 .../handbrake-1.3.0-dont-search-for-python.patch     |  2 --
 .../handbrake/files/handbrake-1.3.3-x265-link.patch  |  4 ++--
 .../handbrake/files/handbrake-1.5.1-ffmpeg-5.0.patch |  9 ---------
 .../files/handbrake-1.6.1-missing-include.patch      | 20 ++++++++++++++++++++
 .../handbrake-9999-remove-faac-dependency.patch      |  4 ----
 .../files/handbrake-9999-system-tools.patch          |  2 --
 media-video/handbrake/handbrake-1.6.1.ebuild         |  2 ++
 7 files changed, 24 insertions(+), 19 deletions(-)
Comment 5 Nicole O'Connor 2024-10-03 17:52:07 UTC
Hello,
Comment 6 Nicole O'Connor 2024-10-03 17:53:00 UTC
Apologies, wrong button.

It seems that the patch was backported to 1.6.1 upstream. media-video/handbrake-1.6.1 is now failing to compile with this new patch. Attaching build.log for completeness.
Comment 7 Nicole O'Connor 2024-10-03 17:53:30 UTC
Created attachment 904870 [details]
build.log with patch failure
Comment 8 Nicole O'Connor 2024-10-03 17:55:09 UTC
Apologies again, and this will be the last time I clutter up y'all's emails.

PEBKAC. I forgot I had the old patch in /etc/portage/patches.
Comment 9 Larry the Git Cow gentoo-dev 2024-10-31 22:12:51 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a7d62b253fad8aac4a287d10048e8609a404f626

commit a7d62b253fad8aac4a287d10048e8609a404f626
Author:     Andreas K. Hüttel <dilfridge@gentoo.org>
AuthorDate: 2024-10-31 21:24:29 +0000
Commit:     Andreas K. Hüttel <dilfridge@gentoo.org>
CommitDate: 2024-10-31 22:12:33 +0000

    media-video/handbrake: drop 1.4.2-r2, 1.5.1-r1
    
    Bug: https://bugs.gentoo.org/921166
    Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>

 media-video/handbrake/Manifest                     |   2 -
 .../handbrake-1.3.0-dont-search-for-python.patch   |  25 ----
 .../files/handbrake-1.5.1-ffmpeg-5.0.patch         |  31 ----
 media-video/handbrake/handbrake-1.4.2-r2.ebuild    | 160 --------------------
 media-video/handbrake/handbrake-1.5.1-r1.ebuild    | 165 ---------------------
 5 files changed, 383 deletions(-)