Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 920846 - cmake.eclass: pass -DFETCHCONTENT_FULLY_DISCONNECTED=ON
Summary: cmake.eclass: pass -DFETCHCONTENT_FULLY_DISCONNECTED=ON
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-12-28 03:28 UTC by Sam James
Modified: 2024-05-04 13:03 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-12-28 03:28:17 UTC
CMake supports -DFETCHCONTENT_FULLY_DISCONNECTED=ON to stop it from attempting to connect to the network.

We already pass an analogue for this for Meson. We could _maybe_ have some variable which ::gentoo ebuilds shouldn't set if overlays would find it useful to override it, but then they could already do it via mycmakeargs.

Anyway, the reason to do this is:
* better error messages when trying to download something
* faster failure
* not relying on network-sandbox which isn't available on e.g. prefix
Comment 1 Larry the Git Cow gentoo-dev 2024-01-04 10:09:12 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=b279c4b7ebcf150673919f8d1b84565a2662e358

commit b279c4b7ebcf150673919f8d1b84565a2662e358
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-01-03 22:14:53 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-01-03 22:15:13 +0000

    cmake.eclass: Set FETCHCONTENT_FULLY_DISCONNECTED=ON
    
    Bug: https://bugs.gentoo.org/920846
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 eclass/cmake.eclass | 1 +
 1 file changed, 1 insertion(+)
Comment 2 Larry the Git Cow gentoo-dev 2024-01-10 11:01:27 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ca877f01a331bd239db8b6878c7f92fa85e02dae

commit ca877f01a331bd239db8b6878c7f92fa85e02dae
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-01-03 22:14:53 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-01-10 11:00:52 +0000

    cmake.eclass: Set FETCHCONTENT_FULLY_DISCONNECTED=ON
    
    Closes: https://bugs.gentoo.org/920846
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 eclass/cmake.eclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)