Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 920839 - mate-base/mate-session-manager does not have to depend on elogind or systemd (PATCH)
Summary: mate-base/mate-session-manager does not have to depend on elogind or systemd ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-27 23:23 UTC by rajas
Modified: 2024-01-19 10:53 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
mate-session-manager-1.26.1.ebuild.patch (mate-session-manager-1.26.1.ebuild.patch,631 bytes, patch)
2023-12-27 23:25 UTC, rajas
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description rajas 2023-12-27 23:23:23 UTC
The package mate-base/mate-session-manager does not have to depend on neither elogind nor systemd.

As stated in https://github.com/mate-desktop/mate-session-manager/blob/master/configure.ac they both are optional and neither is required to compile nor run the package. I can confirm by every day usage without any obvious problems.

Since the MATE Desktop Environment is meant to be lightweight we should remove the hard dependency on elogind resp. systemd.

Reproducible: Always

Steps to Reproduce:
1. Try to emerge mate-base/mate-session-manager without elogind or systemd use flag.
Actual Results:  
2. You are forced to either use elogind or systemd.
3. :-/

Expected Results:  
One should be able to emerge the package both without using elogind or systemd.

Let people emerge and live with a systemd-free system if they wish so.
Comment 1 rajas 2023-12-27 23:25:29 UTC
Created attachment 880788 [details, diff]
mate-session-manager-1.26.1.ebuild.patch

Added patch to remove hard use flag requirement on elogind/systemd.
Comment 2 immolo 2023-12-28 07:42:40 UTC
I can see a couple of ways this could cause an issue which I'm sure is why it was added in the first place. I'll do some tests to make sure those are resolved and merge in your patch if successful. 

Thanks for the patch and test data.
Comment 3 Larry the Git Cow gentoo-dev 2024-01-19 10:53:54 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dd1d4cd96422edfc33ae952e8173c65966861ef6

commit dd1d4cd96422edfc33ae952e8173c65966861ef6
Author:     Ian Jordan <immoloism@gmail.com>
AuthorDate: 2024-01-03 19:23:36 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-19 10:49:37 +0000

    mate-base/mate-session-manager: remove forcing the need for elogind or system
    
    Not required upstream, keeping to testing keywords for now to see if anything was missed but from early testing this seems safe to apply in Gentoo.
    
    Closes: https://bugs.gentoo.org/920839
    Signed-off-by: Ian Jordan <immoloism@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 mate-base/mate-session-manager/mate-session-manager-1.26.1.ebuild | 4 +---
 mate-base/mate-session-manager/mate-session-manager-1.27.0.ebuild | 7 +------
 2 files changed, 2 insertions(+), 9 deletions(-)