Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 920823 - dev-libs/libpwquality-1.4.5: add those ldscripts
Summary: dev-libs/libpwquality-1.4.5: add those ldscripts
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
: 925930 (view as bug list)
Depends on:
Blocks: usrmerge, usrmerge-fixes
  Show dependency tree
 
Reported: 2023-12-27 19:57 UTC by Rafael Kitover
Modified: 2024-03-01 16:29 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build log (libpwquality-1.4.5-build.log,35.33 KB, text/x-log)
2023-12-27 19:57 UTC, Rafael Kitover
Details
emerge --info (emerge-info.txt,20.46 KB, text/plain)
2023-12-27 19:58 UTC, Rafael Kitover
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Kitover 2023-12-27 19:57:21 UTC
Build fails in lib_check with:

 * QA Notice: Missing gen_usr_ldscript for libpwquality.so
 * ERROR: dev-libs/libpwquality-1.4.5::gentoo failed:
 *   add those ldscripts

> emerge -pqv =dev-libs/libpwquality-1.4.5
[ebuild  N    ] dev-libs/libpwquality-1.4.5  USE="pam python (-split-usr) static-libs" PYTHON_TARGETS="-python3_10 python3_11"
Comment 1 Rafael Kitover 2023-12-27 19:57:56 UTC
Created attachment 880747 [details]
build log
Comment 2 Rafael Kitover 2023-12-27 19:58:16 UTC
Created attachment 880748 [details]
emerge --info
Comment 3 Rafael Kitover 2023-12-27 20:00:14 UTC
Builds successfully with USE="-static-libs"
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-12-27 20:03:49 UTC
Hm. src_install has:
```
        if use static-libs; then
                # Do not install static libs in /lib
                mkdir -p "${ED}/usr/$(get_libdir)"
                mv "${ED}/$(get_libdir)/libpwquality.a" "${ED}/usr/$(get_libdir)/" || die
                gen_usr_ldscript libpwquality.so
        fi
```
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-03-01 16:17:35 UTC
*** Bug 925930 has been marked as a duplicate of this bug. ***
Comment 6 smail.muk2 2024-03-01 16:26:06 UTC
see my detection problem in https://bugs.gentoo.org/925930
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-03-01 16:27:32 UTC
(In reply to smail.muk2 from comment #6)
> see my detection problem in https://bugs.gentoo.org/925930

Yes, it's the same thing.

Honestly, we could fix this properly, but we're trying to remove usr-ldscript anyway, so let's just do that here.
Comment 8 Larry the Git Cow gentoo-dev 2024-03-01 16:29:24 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e58fd04c167b4a234ad0f79b02cc186565a5ca8b

commit e58fd04c167b4a234ad0f79b02cc186565a5ca8b
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-03-01 16:26:47 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-01 16:29:13 +0000

    dev-libs/libpwquality: drop usr-ldscript hacks
    
    We're removing usr-ldscript per the recent news item, but this also
    breaks with USE=static-libs.
    
    Drop all the hacks for relocating the libraries. Keep installing the PAM
    module to / though as other PAM modules too.
    
    (Also, drop a patch which was already merged in 1.4.5.)
    
    Closes: https://bugs.gentoo.org/920823
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-libs/libpwquality/libpwquality-1.4.5-r1.ebuild | 74 ++++++++++++++++++++++
 1 file changed, 74 insertions(+)