Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 920793 - net-firewall/fwknop-2.6.10-r3 - configure fails after eautoreconf: ./configure:line <snip>: syntax error near unexpected token ;;
Summary: net-firewall/fwknop-2.6.10-r3 - configure fails after eautoreconf: ./configur...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Hank Leininger
URL:
Whiteboard:
Keywords: PullRequest
: 926137 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-12-27 08:59 UTC by Toralf Förster
Modified: 2024-03-04 08:46 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,17.22 KB, text/plain)
2023-12-27 08:59 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,233.17 KB, text/plain)
2023-12-27 08:59 UTC, Toralf Förster
Details
environment (environment,106.00 KB, text/plain)
2023-12-27 08:59 UTC, Toralf Förster
Details
etc.clang.tar.xz (etc.clang.tar.xz,1.25 KB, application/x-xz)
2023-12-27 08:59 UTC, Toralf Förster
Details
etc.portage.tar.xz (etc.portage.tar.xz,41.89 KB, application/x-xz)
2023-12-27 08:59 UTC, Toralf Förster
Details
logs.tar.xz (logs.tar.xz,10.77 KB, application/x-xz)
2023-12-27 08:59 UTC, Toralf Förster
Details
net-firewall:fwknop-2.6.10-r3:20231226-224201.log (net-firewall:fwknop-2.6.10-r3:20231226-224201.log,11.94 KB, text/plain)
2023-12-27 08:59 UTC, Toralf Förster
Details
qlist-info.txt.xz (qlist-info.txt.xz,56.91 KB, application/x-xz)
2023-12-27 08:59 UTC, Toralf Förster
Details
temp.tar.xz (temp.tar.xz,29.38 KB, application/x-xz)
2023-12-27 08:59 UTC, Toralf Förster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2023-12-27 08:59:48 UTC
checking for execvpe... yes
checking for library containing socket... none required
checking for library containing inet_addr... none required
checking for gpgme-config... /usr/bin/gpgme-config
checking for gpg... /usr/bin/gpg
checking for wget... /usr/bin/wget
./configure: line 18792: syntax error near unexpected token `;;'
./configure: line 18792: `   ;;'


  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_hardened-20231224-003503

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-10
 [2] x86_64-pc-linux-gnu-13 *
clang/llvm (if any):
clang version 17.0.6
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/17/bin
Configuration file: /etc/clang/x86_64-pc-linux-gnu-clang.cfg
/usr/lib/llvm/17
17.0.6
Python 3.11.7
Available Ruby profiles:
  [1]   ruby31 (with Rubygems) *
Available Rust versions:
  [1]   rust-bin-1.74.1 *
The following VMs are available for generation-2:
1)	Eclipse Temurin JDK 17.0.8.1_p1 [openjdk-bin-17]
2)	Eclipse Temurin JDK 21.0.1_p12 [openjdk-bin-21]
*)	Eclipse Temurin JDK 8.382_p05 [openjdk-bin-8]
Available Java Virtual Machines:
  [1]   openjdk-bin-8  system-vm
  [2]   openjdk-bin-17 
  [3]   openjdk-bin-21 

The Glorious Glasgow Haskell Compilation System, version 9.2.8
php cli (if any):
go version go1.21.5 linux/amd64

  HEAD of ::gentoo
commit 5f2f79e6c633e8cc92b8beed9337432b59093ca6
Author: Repository mirror & CI <repomirrorci@gentoo.org>
Date:   Tue Dec 26 21:46:59 2023 +0000

    2023-12-26 21:46:59 UTC

emerge -qpvO net-firewall/fwknop
[ebuild  N    ] net-firewall/fwknop-2.6.10-r3  USE="client gdbm iptables server -extras -firewalld -gpg -nfqueue -static-libs -udp-server"
Comment 1 Toralf Förster gentoo-dev 2023-12-27 08:59:49 UTC
Created attachment 880591 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2023-12-27 08:59:50 UTC
Created attachment 880592 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2023-12-27 08:59:51 UTC
Created attachment 880593 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2023-12-27 08:59:52 UTC
Created attachment 880594 [details]
etc.clang.tar.xz
Comment 5 Toralf Förster gentoo-dev 2023-12-27 08:59:53 UTC
Created attachment 880595 [details]
etc.portage.tar.xz
Comment 6 Toralf Förster gentoo-dev 2023-12-27 08:59:54 UTC
Created attachment 880596 [details]
logs.tar.xz
Comment 7 Toralf Förster gentoo-dev 2023-12-27 08:59:55 UTC
Created attachment 880597 [details]
net-firewall:fwknop-2.6.10-r3:20231226-224201.log
Comment 8 Toralf Förster gentoo-dev 2023-12-27 08:59:56 UTC
Created attachment 880598 [details]
qlist-info.txt.xz
Comment 9 Toralf Förster gentoo-dev 2023-12-27 08:59:57 UTC
Created attachment 880599 [details]
temp.tar.xz
Comment 10 orbea 2024-02-09 17:41:02 UTC
I cant reproduce this and it builds with slibtool. In the log it is failing before slibtool is even used so it might be unrelated.
Comment 11 Hank Leininger 2024-02-09 17:50:26 UTC
I reproduced it last night with fwknop-2.6.10-r3 by enabling slibtool.

Disabled slibtool, built fine.

Tested with slibtool and fwknop-2.6.11 (see PR) and it built fine.
Comment 12 orbea 2024-02-09 18:42:05 UTC
I've tested this with slibtool 0.5.35 and 9999, on glibc and musl, with gcc and clang, but no issues on my end. How are you enabling slibtool? The Gentoo wiki should cover it.

https://wiki.gentoo.org/wiki/Slibtool#Usage

I also tested your PR without any build issues. If it fixes the build for you then its probably fine to close this issue when its merged.
Comment 13 Hank Leininger 2024-02-09 19:42:16 UTC
Huh. So I can still reproduce it, but... also without slibtool enabled!

I now suspect some kind of autoconf issue. The distribution includes a configure script; we regenerate it with eautoreconf. After which there's syntax errors in the updated configure script.

The difference between stock & regenerated configure that seems responsible:

@@ -17077,97 +18789,100 @@
 
 
 
-
-fi
-fi
-fi
+   ;;
+esac
+fi ;;
+esac
+fi ;;
+esac
+fi ;;
+esac
 fi
 fi

But that's hardly helpful since there's zero indentation, so trying to track down what exactly went off the rails seems pointless.

Now what I don't know is why I did *not* get the same error when I flipped slibtool back off and tried again in testing, because now I get it regardless. I'm at autoconf-2.72-r1 same as Toralf's tinderbox, but I have been there since Dec, so certainly hasn't changed since yesterday. Maybe I simply rebuilt the wrong one by accident.

Toralf, do you know for sure that the same setup did *not* fail without slibtool enabled?

Nothing jumps out at me in fwknop's changelog about an update that would have made 2.6.11 fare better, but it does. So let's update this bug to remove the slibtool block but regardless, it'll close when the fwknop update lands.
Comment 14 orbea 2024-02-09 20:05:37 UTC
I see the new version has significantly fewer autoconf warnings, that might of fixed w/e it was. However I have the same autoconf version and still cant break it with or without autoreconf so I don't have much of an explanation.
Comment 15 orbea 2024-02-09 20:29:50 UTC
Looking at their git history I think the only commit that could of fixed it is.

https://github.com/mrash/fwknop/commit/e23e1197206e7b4bd93ca6683cb857cae381dc56
Comment 16 Hank Leininger 2024-02-09 20:58:49 UTC
(In reply to orbea from comment #15)
> Looking at their git history I think the only commit that could of fixed it
> is.
> 
> https://github.com/mrash/fwknop/commit/
> e23e1197206e7b4bd93ca6683cb857cae381dc56

Spot on!

Indeed, the issue that closes looks quite familiar: https://github.com/mrash/fwknop/issues/360

I tried 2.6.10-r3 with that (after a little cleanup because it didn't apply cleanly), and indeed, that fixes 'ebuild ... configure' here, and presumably on Toralf's tinderbox.

I probably won't do anything with this updated patch since 2.6.10 should go away, but tyvm for the detective work, it is nice to get to the bottom of this!
Comment 17 Larry the Git Cow gentoo-dev 2024-03-04 07:53:52 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1d29ef3e3ee3cfed5cc90e993c21d7abd7fe6d15

commit 1d29ef3e3ee3cfed5cc90e993c21d7abd7fe6d15
Author:     Hank Leininger <hlein@korelogic.com>
AuthorDate: 2024-02-08 22:41:09 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2024-03-04 07:53:47 +0000

    net-firewall/fwknop: add 2.6.11
    
    Signed-off-by: Hank Leininger <hlein@korelogic.com>
    Closes: https://bugs.gentoo.org/822741
    Closes: https://bugs.gentoo.org/920793
    Closes: https://github.com/gentoo/gentoo/pull/35236
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 net-firewall/fwknop/Manifest             |   2 +
 net-firewall/fwknop/fwknop-2.6.11.ebuild | 133 +++++++++++++++++++++++++++++++
 2 files changed, 135 insertions(+)
Comment 18 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-03-04 08:46:15 UTC
*** Bug 926137 has been marked as a duplicate of this bug. ***