Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 920696 - app-editors/emacs-29.4 fails tests on hppa
Summary: app-editors/emacs-29.4 fails tests on hppa
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: HPPA Linux
: Normal normal
Assignee: GNU Emacs project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 920689
  Show dependency tree
 
Reported: 2023-12-25 17:05 UTC by matoro
Modified: 2024-09-05 08:30 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log and emerge --info (file_920696.txt,507.67 KB, text/plain)
2023-12-25 17:07 UTC, matoro
Details
build.log and emerge --info (file_920696.txt,484.30 KB, text/plain)
2024-09-03 21:17 UTC, matoro
Details
Patch for emacs-29.4 erc-networks-tests (emacs-29.4-erc-tests.patch,549 bytes, patch)
2024-09-04 11:30 UTC, Ulrich Müller
Details | Diff
Patch for emacs-29.4 erc-networks-tests (05_all_erc-network-tests.patch,604 bytes, patch)
2024-09-04 14:41 UTC, Ulrich Müller
Details | Diff
build.log and emerge --info (file_920696.txt,497.14 KB, text/plain)
2024-09-04 18:40 UTC, matoro
Details

Note You need to log in before you can comment on or make changes to this bug.
Description matoro archtester 2023-12-25 17:05:37 UTC
Does not repro on ppc so not a 32-bit nor endian problem.  build.log and emerge --info in attachment.  Two failures are:

Test erc-networks--id-sort-buffers condition:
    (ert-test-failed
     ((should
       (equal
        (erc-networks--id-sort-buffers ...)
        (list newest middle oldest)))
      :form
      (equal
       (#<killed buffer> #<killed buffer> #<killed buffer>)
       (#<killed buffer> #<killed buffer> #<killed buffer>))
      :value nil :explanation
      (list-elt 0
                (different-atoms #<killed buffer> #<killed buffer>))))
   FAILED   6/41  erc-networks--id-sort-buffers (0.000000 sec) at lisp/erc/erc-networks-tests.el:133

(Somewhat truncated since it includes full environment dump):

Test server-tests/emacsclient/create-frame condition:
    Server logs: Mon Dec 25 16:26:23 2023 Started server
                 Mon Dec 25 16:26:24 2023 /var/tmp/portage/app-editors/emacs-29.1-r6/temp/server-testscn960A/test-server <1>: Status changed to open: open from -
                 Mon Dec 25 16:26:24 2023 /var/tmp/portage/app-editors/emacs-29.1-r6/temp/server-testscn960A/test-server <1>: server-delete-client
                 Mon Dec 25 16:26:24 2023 /var/tmp/portage/app-editors/emacs-29.1-r6/temp/server-testscn960A/test-server <1>: Received -env PWD=/var/tmp/portage/app-editors/emacs-29.1-r>
                 Mon Dec 25 16:26:24 2023 /var/tmp/portage/app-editors/emacs-29.1-r6/temp/server-testscn960A/test-server <1>: Sent -emacs-pid 9043
                 Mon Dec 25 16:26:24 2023 /var/tmp/portage/app-editors/emacs-29.1-r6/temp/server-testscn960A/test-server <1>: Received usr/lib32/conftest:/usr/lib64/cf:/usr/lib64/confte>
29.1-r6/distdir -env SHLVL=3 -env GPG_VERIFY_USER_DROP=nobody -env INPUT_DEVICES= -env USE_EXPAND_VALUES_ARCH=alpha&_amd64&_amd64-linux&_arm&_arm64&_arm64-macos&_hppa&_ia64&_loong&_m68k>
                 Mon Dec 25 16:26:24 2023 /var/tmp/portage/app-editors/emacs-29.1-r6/temp/server-testscn960A/test-server <1>: Sent -emacs-pid 9043
                 Mon Dec 25 16:26:24 2023 /var/tmp/portage/app-editors/emacs-29.1-r6/temp/server-testscn960A/test-server <1>: Received TION=192.168.2.2&_44538&_192.168.5.7&_22 -env PORT>
                 Mon Dec 25 16:26:24 2023 /var/tmp/portage/app-editors/emacs-29.1-r6/temp/server-testscn960A/test-server <1>: Sent -emacs-pid 9043
                 Mon Dec 25 16:26:24 2023 /var/tmp/portage/app-editors/emacs-29.1-r6/temp/server-testscn960A/test-server: Status changed to closed: deleted
                 Mon Dec 25 16:26:24 2023 /var/tmp/portage/app-editors/emacs-29.1-r6/temp/server-testscn960A/test-server: server-delete-client
                 Mon Dec 25 16:26:24 2023 Stopped server
                 Mon Dec 25 16:26:24 2023 /var/tmp/portage/app-editors/emacs-29.1-r6/temp/server-testscn960A/test-server <1>: server-delete-client
                 Mon Dec 25 16:26:24 2023 /var/tmp/portage/app-editors/emacs-29.1-r6/temp/server-testscn960A/test-server <1>: Status changed to closed: deleted
                 Mon Dec 25 16:26:24 2023 /var/tmp/portage/app-editors/emacs-29.1-r6/temp/server-testscn960A/test-server <1>: server-delete-client
                 Mon Dec 25 16:26:24 2023 /var/tmp/portage/app-editors/emacs-29.1-r6/temp/server-testscn960A/test-server <1>: Deleted
                 
    Client output: 
                   Process /var/tmp/portage/app-editors/emacs-29.1-r6/work/emacs-29.1/lib-src/emacsclient exited abnormally with code 1
                   
    (ert-test-failed
     ((should
       (length=
        (frame-list)
        (1+ starting-frame-count)))
      :form
      (length=
       (#<frame F1 0x435ebca0>)
       2)
      :value nil))
   FAILED  1/7  server-tests/emacsclient/create-frame (0.407998 sec) at lisp/server-tests.el:162

Reproducible: Always
Comment 1 matoro archtester 2023-12-25 17:07:02 UTC
Created attachment 880304 [details]
build.log and emerge --info
Comment 2 Ulrich Müller gentoo-dev 2023-12-26 03:37:25 UTC
Could you also report this upstream please?
Comment 3 matoro archtester 2024-09-03 21:16:35 UTC
Still an issue on 29.4.  Seems I forgot to report this to upstream; let me see if I can figure out how.
Comment 4 matoro archtester 2024-09-03 21:17:38 UTC
Created attachment 901997 [details]
build.log and emerge --info
Comment 5 Ulrich Müller gentoo-dev 2024-09-04 08:45:11 UTC
What does the following command output for you?

$ emacs -batch -Q -l erc-networks -eval "(with-temp-buffer (let ((erc-networks--id (erc-networks--id-fixed-create 'newest))) (print (current-time)) (print (erc-networks--id-ts (buffer-local-value 'erc-networks--id (current-buffer))))))"
Comment 6 Ulrich Müller gentoo-dev 2024-09-04 11:30:42 UTC
Created attachment 902052 [details, diff]
Patch for emacs-29.4 erc-networks-tests

Does attached patch fix the test failure?
Comment 7 Ulrich Müller gentoo-dev 2024-09-04 14:41:36 UTC
Created attachment 902078 [details, diff]
Patch for emacs-29.4 erc-networks-tests

(In reply to Ulrich Müller from comment #6)
> Does attached patch fix the test failure?

Let's use 20 ms delay rather than 5 ms, to be on the safe side.
Comment 8 matoro archtester 2024-09-04 18:40:38 UTC
Created attachment 902083 [details]
build.log and emerge --info

No improvement with that patch unfortunately.
Comment 9 Ulrich Müller gentoo-dev 2024-09-04 19:20:10 UTC
(In reply to matoro from comment #8)
> Created attachment 902083 [details]
> build.log and emerge --info
> 
> No improvement with that patch unfortunately.

Different failure now. In the previous log the failure was in lisp/erc/erc-networks-tests.el. In the new log it is in lisp/server-tests.el:

   FAILED  server-tests/emacsclient/create-frame  ((should (length= (frame-list) (1+ starting-frame-count))) :form (length= (#<frame F1 0x42163d80>) 2) :value nil)
Comment 10 Larry the Git Cow gentoo-dev 2024-09-04 20:08:27 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ec3cc76c3791a5111535be918361e640f352f170

commit ec3cc76c3791a5111535be918361e640f352f170
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2024-09-04 20:02:11 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2024-09-04 20:08:22 +0000

    app-editors/emacs: Fix test failures on HPPA
    
    Bug: https://bugs.gentoo.org/920696
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 app-editors/emacs/Manifest                  | 2 +-
 app-editors/emacs/emacs-28.2-r13.ebuild     | 1 +
 app-editors/emacs/emacs-29.4.ebuild         | 3 ++-
 app-editors/emacs/emacs-30.0.9999-r1.ebuild | 1 +
 app-editors/emacs/emacs-31.0.9999.ebuild    | 1 +
 5 files changed, 6 insertions(+), 2 deletions(-)
Comment 11 Ulrich Müller gentoo-dev 2024-09-04 20:10:04 UTC
Should hopefully be fixed in emacs-29.4 (without revbump).
Please test again.
Comment 12 matoro archtester 2024-09-04 23:02:25 UTC
(In reply to Ulrich Müller from comment #11)
> Should hopefully be fixed in emacs-29.4 (without revbump).
> Please test again.

Indeed passes now, thanks!
Comment 13 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-09-05 07:18:01 UTC
Thank you both!
Comment 14 Ulrich Müller gentoo-dev 2024-09-05 08:30:25 UTC
Fixed upstream:

https://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-30&id=87a8b12a0c45cd92665978e63cb56354d61cc076
commit 87a8b12a0c45cd92665978e63cb56354d61cc076
Author: Ulrich Müller <ulm@gentoo.org>
Date:   Wed Sep 4 13:35:51 2024 +0200

    Fix test failure in erc-networks-tests
    
    * test/lisp/erc/erc-networks-tests.el
    (erc-networks--id-sort-buffers): Make sure that buffers have
    different timestamps.  (Bug#73036)