Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 920548 - media-libs/libsdl2[fcitx] can depend on app-i18n/fcitx:5
Summary: media-libs/libsdl2[fcitx] can depend on app-i18n/fcitx:5
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-12-22 16:49 UTC by Liu Yujie
Modified: 2024-09-28 20:43 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Liu Yujie 2023-12-22 16:49:59 UTC
Now fcitx5 is in the tree as app-i18n/fcitx:5[1], media-libs/libsdl2[fcitx] can also depend on fcitx:5, not just fcitx:4.

[1].https://github.com/gentoo/gentoo/pull/34066

Reproducible: Always
Comment 1 Alfred Wingate 2023-12-22 17:11:41 UTC
https://github.com/libsdl-org/SDL/commit/eadc8693dd4a8d47fc63985ef70d082084081bab

It appears libsdl2 has had support for both for a while, so replacing the fcitx4 flag with a more general fcitx flag would be warranted.
Comment 2 Larry the Git Cow gentoo-dev 2024-09-28 20:43:21 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b54738872b490558153d026e987639c29fe888b3

commit b54738872b490558153d026e987639c29fe888b3
Author:     Yongxiang Liang <tanekliang@gmail.com>
AuthorDate: 2024-09-06 16:41:47 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2024-09-28 20:43:06 +0000

    media-libs/libsdl2: rename use flag fcitx4 to fcitx
    
    Closes: https://bugs.gentoo.org/920548
    Closes: https://bugs.gentoo.org/936970
    Signed-off-by: Yongxiang Liang <tanekliang@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/38487
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 .../{libsdl2-2.28.5-r2.ebuild => libsdl2-2.28.5-r3.ebuild}        | 8 ++++----
 .../libsdl2/{libsdl2-2.30.7.ebuild => libsdl2-2.30.7-r1.ebuild}   | 6 +++---
 media-libs/libsdl2/metadata.xml                                   | 2 +-
 profiles/arch/alpha/package.use.mask                              | 2 +-
 profiles/arch/arm/package.use.mask                                | 2 +-
 profiles/arch/arm64/package.use.stable.mask                       | 2 +-
 profiles/arch/hppa/package.use.stable.mask                        | 2 +-
 profiles/arch/mips/package.use.mask                               | 2 +-
 profiles/arch/sparc/package.use.mask                              | 2 +-
 9 files changed, 14 insertions(+), 14 deletions(-)