Several issues fixed here - add qt6 support (has been supported for some time) - make hard media-plugs/gst-plugins-soup requirement optional, nowhere in upstream code does this dependency exist, all internet streaming works fine without it. Reproducible: Always
Created attachment 880100 [details] media-sound/strawberry-1.0.22-r1.ebuild
Created attachment 880101 [details] dev-qt/kdsinglespplication-1.0.0.ebuild
You can also use pull requests on GitHub to get changes applied. With GitHub the interface would be better for getting reviewed. https://wiki.gentoo.org/wiki/GitHub_Pull_Requests
yes, it would be really better for me to handle it on github if that's possible.
I did test the build from Gino McCarty on my local repository. build fine with or without dev-qt/kdsinglespplication-1.0.0.ebuild witch is in guru repository about kdsinglespplication no clue what is for. I probably misunderstood but I thought kdsinglespplication was also needed for qt5. I built with (cdda gstreamer icu mtp pulseaudio qt6 udisks vlc -debug -ipod -moodbar -soup) warning I have a bug with gentoo repository version of media-sound/strawberry 1.0.22, 1.0.23 and with this build too "delete from disk" action does not delete file from disk don't know if it's only me ,gentoo or upstream. https://github.com/strawberrymusicplayer/strawberry/issues/1375
Thanks for looking at this @jms Look like if we don't include kdsingleapplication its built internally here: https://github.com/strawberrymusicplayer/strawberry/blob/05381096aa47b04117254f09d5954c0b2ab801ff/CMakeLists.txt#L312 I'm not thrilled about being proxy maintainer for a new app in the tree but I don't mind doing it. https://github.com/gentoo/gentoo/pull/34512 If we really want maybe just let the 3rd party build continue? feels very un-gentoo to do that though.. (In reply to jms from comment #5) > I did test the build from Gino McCarty on my local repository. > build fine with or without > dev-qt/kdsinglespplication-1.0.0.ebuild > witch is in guru repository > > about kdsinglespplication no clue what is for. > > I probably misunderstood but I thought kdsinglespplication was also needed > for qt5. > I built with > (cdda gstreamer icu mtp pulseaudio qt6 udisks vlc -debug -ipod -moodbar > -soup) > > warning I have a bug with gentoo repository version of > media-sound/strawberry > 1.0.22, 1.0.23 > and with this build too > "delete from disk" action does not delete file from disk > don't know if it's only me ,gentoo or upstream. > https://github.com/strawberrymusicplayer/strawberry/issues/1375
(In reply to Gino McCarty from comment #6) > Thanks for looking at this @jms you're welcome I wonder why it takes so long for this ebuild to be pushed > > Look like if we don't include kdsingleapplication its built internally > here: > https://github.com/strawberrymusicplayer/strawberry/blob/ > 05381096aa47b04117254f09d5954c0b2ab801ff/CMakeLists.txt#L312 > > I'm not thrilled about being proxy maintainer for a new app in the tree but > I don't mind doing it. > > https://github.com/gentoo/gentoo/pull/34512 > > If we really want maybe just let the 3rd party build continue? feels very > un-gentoo to do that though.. As basic user I feel this being un-gentoo to me if it's an external to the software it should be apart and if it's no required no be build if we don't have it/want it... Again thanks for theses ebuilds
about kdsingleapplication It will be a dependency anyway in the future https://forum.strawberrymusicplayer.org/topic/1441/why-not-make-kdsingleapplication-required-in-cmake archlinux already has it https://archlinux.org/packages/extra/x86_64/kdsingleapplication/ and include it in its strawberry build https://archlinux.org/packages/extra/x86_64/strawberry/ @Gino McCarty maybe you should change this bug's title and remove the -1.0.22 as this build issue is more for current and future strawberry build
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=526ce204e4951b800ee8bf21732f208db2496042 commit 526ce204e4951b800ee8bf21732f208db2496042 Author: Miroslav Šulc <fordfrog@gentoo.org> AuthorDate: 2024-03-13 11:45:19 +0000 Commit: Miroslav Šulc <fordfrog@gentoo.org> CommitDate: 2024-03-13 11:45:31 +0000 media-sound/strawberry: added qt6 support + fixed deps Closes: https://bugs.gentoo.org/920422 Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org> media-sound/strawberry/metadata.xml | 1 + media-sound/strawberry/strawberry-1.0.23-r1.ebuild | 129 +++++++++++++++++++++ 2 files changed, 130 insertions(+)
thanks!
