Bug 920358 – app-arch/torrentzip-0.9-r1 fails to compile (GCC-14-SYSTEM): zip.c:1145:28: error: assignment to [-Wincompatible-pointer-types]

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Agostino Sarubbo 2023-12-20 08:16:30 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-arch/torrentzip-0.9-r1 fails to compile (GCC-14-SYSTEM).
Discovered on: amd64 (internal ref: gcc14_tinderbox)

NOTE:
(GCC-14-SYSTEM) in the summary means that the bug was found on a machine that runs gcc-13 but this bug MAY or MAY NOT BE related to the new compiler

[Comment 1 Agostino Sarubbo 2023-12-20 08:16:32 UTC]

Created attachment 880033 [details]
build.log

build log and emerge --info

[Comment 2 Sam James 2023-12-20 08:29:19 UTC]

Looks like there's a fork at https://github.com/0-wiz-0/trrntzip (https://sourceforge.net/p/trrntzip/discussion/457469/thread/d3610ea3b6/).

[Comment 3 Alexander Miller 2023-12-22 00:59:01 UTC]

The fork lgtm, I'll put up a PR for the new release shortly.

Concerning the old 0.9-r1 ebuild: I can't test with gcc-14 right now.
Does it build successfully with CPPFLAGS="-Wno-error=incompatible-pointer-types"?
If so, should I append the flag in the old ebuild?

[Comment 4 Larry the Git Cow 2023-12-22 06:46:38 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=469d268abbf90f24770d3ad7ba332c82ccfe07f5

commit 469d268abbf90f24770d3ad7ba332c82ccfe07f5
Author:     Alexander Miller <[e-mail]>
AuthorDate: 2023-12-22 00:28:57 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2023-12-22 06:44:31 +0000

    app-arch/torrentzip: Switch to new upstream and add 1.0
    
    Bug: https://bugs.gentoo.org/920358
    Signed-off-by: Alexander Miller <[e-mail]>
    Signed-off-by: Sam James <[e-mail]>

 app-arch/torrentzip/Manifest              |  1 +
 app-arch/torrentzip/torrentzip-1.0.ebuild | 28 ++++++++++++++++++++++++++++
 2 files changed, 29 insertions(+)

[Comment 5 Larry the Git Cow 2024-02-24 20:07:29 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9f874493cad5779b95554498159cfe67f6519bad

commit 9f874493cad5779b95554498159cfe67f6519bad
Author:     Alexander Miller <[e-mail]>
AuthorDate: 2024-01-16 23:45:50 +0000
Commit:     Michał Górny <[e-mail]>
CommitDate: 2024-02-24 20:07:25 +0000

    app-arch/torrentzip: add 1.2
    
    Update LICENSE clarified upstream.
    Drop src_configure() since OF() macro is finally gone.
    Looks like a good stable candidate (so we can drop 0.9-r1 for #920358).
    
    Bug: https://bugs.gentoo.org/920358
    Signed-off-by: Alexander Miller <[e-mail]>
    Signed-off-by: Michał Górny <[e-mail]>

 app-arch/torrentzip/Manifest              |  1 +
 app-arch/torrentzip/torrentzip-1.2.ebuild | 25 +++++++++++++++++++++++++
 2 files changed, 26 insertions(+)

[Comment 6 Larry the Git Cow 2024-06-02 07:00:43 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dda8854fe9fdffee3e166d6548534f93980107e4

commit dda8854fe9fdffee3e166d6548534f93980107e4
Author:     Alexander Miller <[e-mail]>
AuthorDate: 2024-04-16 11:56:31 +0000
Commit:     Joonas Niilola <[e-mail]>
CommitDate: 2024-06-02 07:00:41 +0000

    app-arch/torrentzip: drop 0.9-r1, 1.2-r1
    
    Closes: https://bugs.gentoo.org/920358
    Closes: https://github.com/gentoo/gentoo/pull/36279
    Signed-off-by: Alexander Miller <[e-mail]>
    Signed-off-by: Joonas Niilola <[e-mail]>

 app-arch/torrentzip/Manifest                       |  2 -
 .../files/torrentzip-0.9-autoconf-quote.patch      |  8 ----
 .../files/torrentzip-1.2-checksum-detection.patch  | 51 ----------------------
 app-arch/torrentzip/torrentzip-0.9-r1.ebuild       | 27 ------------
 app-arch/torrentzip/torrentzip-1.2-r1.ebuild       | 28 ------------
 5 files changed, 116 deletions(-)