Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 919913 - sys-process/htop should support python3.12
Summary: sys-process/htop should support python3.12
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-14 20:22 UTC by Boris Staletic
Modified: 2023-12-18 07:10 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Boris Staletic 2023-12-14 20:22:04 UTC
Currently available htop only supports up to python 3.11.
I've ran the tests with python 3.12 and everything works.
Just changing thte PYTHON_COMPAT variable to include python3_12 is enough.

Reproducible: Always
Comment 2 Boris Staletic 2023-12-18 00:58:35 UTC
> Does htop even need python anymore?

Good catch! Dropping every mention of python from the ebuild does succeed, but the verbose output still mentions "python" in a few places

> checking for a BSD-compatible install... /usr/lib/portage/python3.12/ebuild-helpers/xattr/install -c

I don't know if that is expected. I was rather expecting it to find `/usr/bin/install`.

Then later the output contains:

>  /usr/lib/portage/python3.12/ebuild-helpers/xattr/install -c -m 644 htop.desktop '/var/tmp/portage/sys-process/htop-3.2.2/image/usr/share/applications'
 /usr/lib/portage/python3.12/ebuild-helpers/xattr/install -c -m 644 htop.svg '/var/tmp/portage/sys-process/htop-3.2.2/image/usr/share/icons/hicolor/scalable/apps'
  /usr/lib/portage/python3.12/ebuild-helpers/xattr/install -c htop '/var/tmp/portage/sys-process/htop-3.2.2/image/usr/bin'
 /usr/lib/portage/python3.12/ebuild-helpers/xattr/install -c -m 644 htop.png '/var/tmp/portage/sys-process/htop-3.2.2/image/usr/share/pixmaps'
 /usr/lib/portage/python3.12/ebuild-helpers/xattr/install -c -m 644 htop.1 '/var/tmp/portage/sys-process/htop-3.2.2/image/usr/share/man/man1'

But those only mention python, because that's the BSD-compatible `install` the configure script has discovered.
Comment 3 Eli Schwartz 2023-12-18 05:06:13 UTC
Those are internal implementation details of portage and work as long as portage is installed correctly with whichever PYTHON_COMPAT value portage is selected to use.
Comment 4 Larry the Git Cow gentoo-dev 2023-12-18 07:10:15 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=727a16cedb529b0225b5847082bcbd4f72c3380f

commit 727a16cedb529b0225b5847082bcbd4f72c3380f
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-12-18 07:09:21 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-12-18 07:09:21 +0000

    sys-process/htop: drop stale Python usage
    
    Thanks to parona for pointing this out, it was dropped upstream in a852fae8e02650d621abdd5aea29b7a56d9a3090 [0]
    
    [0] https://github.com/htop-dev/htop/commit/a852fae8e02650d621abdd5aea29b7a56d9a3090
    
    Closes: https://bugs.gentoo.org/919913
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-process/htop/htop-3.2.2.ebuild | 12 ++----------
 sys-process/htop/htop-9999.ebuild  | 12 ++----------
 2 files changed, 4 insertions(+), 20 deletions(-)