Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 919874 - sys-apps/ucspi-tcp-0.88-r19 - pathexec_env.c: error: passing argument 1 of alloc_free from incompatible pointer type [-Wincompatible-pointer-types]
Summary: sys-apps/ucspi-tcp-0.88-r19 - pathexec_env.c: error: passing argument 1 of al...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Jaco Kroon
URL:
Whiteboard:
Keywords: PullRequest
: 952908 (view as bug list)
Depends on:
Blocks: c99-porting gcc-14-stable
  Show dependency tree
 
Reported: 2023-12-14 09:02 UTC by Toralf Förster
Modified: 2025-03-31 04:14 UTC (History)
8 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,16.49 KB, text/plain)
2023-12-14 09:02 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,14.09 KB, text/plain)
2023-12-14 09:02 UTC, Toralf Förster
Details
environment (environment,88.64 KB, text/plain)
2023-12-14 09:02 UTC, Toralf Förster
Details
etc.portage.tar.xz (etc.portage.tar.xz,23.77 KB, application/x-xz)
2023-12-14 09:02 UTC, Toralf Förster
Details
qlist-info.txt (qlist-info.txt,38.55 KB, text/plain)
2023-12-14 09:02 UTC, Toralf Förster
Details
sys-apps:ucspi-tcp-0.88-r19:20231214-085320.log (sys-apps:ucspi-tcp-0.88-r19:20231214-085320.log,9.69 KB, text/plain)
2023-12-14 09:02 UTC, Toralf Förster
Details
temp.tar.xz (temp.tar.xz,23.20 KB, application/x-xz)
2023-12-14 09:02 UTC, Toralf Förster
Details
patch (file_919874.txt,265 bytes, text/plain)
2025-01-13 14:17 UTC, Arniiiii
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2023-12-14 09:02:36 UTC
./compile open_write.c
./compile openreadclose.c
./compile pathexec_env.c
./compile pathexec_run.c
./compile chkshsgr.c
pathexec_env.c: In function pathexec:
pathexec_env.c:66:14: error: passing argument 1 of alloc_free from incompatible pointer type [-Wincompatible-pointer-types]
   66 |   alloc_free(e);
      |              ^

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_no_multilib_systemd-20231213-230004

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-14 *
clang/llvm (if any):
Python 3.11.6
The following VMs are available for generation-2:
*)	Eclipse Temurin JDK 8.382_p05 [openjdk-bin-8]
Available Java Virtual Machines:
  [1]   openjdk-bin-8  system-vm

php cli (if any):

  HEAD of ::gentoo
commit 3e28d0d6e497028ecea2b23f9b72e5643ad0947e
Author: Repository mirror & CI <repomirrorci@gentoo.org>
Date:   Thu Dec 14 08:16:59 2023 +0000

    2023-12-14 08:16:58 UTC

emerge -qpvO sys-apps/ucspi-tcp
[ebuild  N    ] sys-apps/ucspi-tcp-0.88-r19  USE="ipv6 -qmail-spp (-selinux)"
Comment 1 Toralf Förster gentoo-dev 2023-12-14 09:02:37 UTC
Created attachment 879354 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2023-12-14 09:02:38 UTC
Created attachment 879355 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2023-12-14 09:02:39 UTC
Created attachment 879356 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2023-12-14 09:02:41 UTC
Created attachment 879357 [details]
etc.portage.tar.xz
Comment 5 Toralf Förster gentoo-dev 2023-12-14 09:02:42 UTC
Created attachment 879358 [details]
qlist-info.txt
Comment 6 Toralf Förster gentoo-dev 2023-12-14 09:02:43 UTC
Created attachment 879359 [details]
sys-apps:ucspi-tcp-0.88-r19:20231214-085320.log
Comment 7 Toralf Förster gentoo-dev 2023-12-14 09:02:44 UTC
Created attachment 879360 [details]
temp.tar.xz
Comment 8 Aidan Marks 2025-01-06 20:22:37 UTC
Same issue seen here with gcc 14.
Comment 9 Arniiiii 2025-01-13 14:17:20 UTC
Created attachment 916430 [details]
patch
Comment 10 Arniiiii 2025-01-13 14:19:27 UTC
(In reply to Arniii from comment #9)
> Created attachment 916430 [details]
> patch

the simple patch seems to be correct for me because:
in the function it allocs one array and then casts to (char**)
and then deallocates. 

The library allocates and deallocates memory via it's wrapper that uses malloc and if failed to alloc, writes to errno the error. So, they are just wrappers of malloc and free.
Comment 11 Jaco Kroon 2025-01-30 10:14:19 UTC
Will fix this one.
Comment 12 Larry the Git Cow gentoo-dev 2025-03-25 02:28:02 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5d3c81170c0f305a7b068456252b82c816dd6293

commit 5d3c81170c0f305a7b068456252b82c816dd6293
Author:     Z. Liu <zhixu.liu@gmail.com>
AuthorDate: 2025-01-14 11:28:52 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-03-25 02:27:42 +0000

    sys-apps/ucspi-tcp: fix -Wincompatible-pointer-types, update EAPI, ...
    
    1. add patch to fix -Wincompatible-pointer-types
    2. update to EAPI 8
    3. app-doc/ucspi-tcp-man is not exist
    4. add myself as proxy maintainer
    5. rev bump & keep stable due to old revision FTBFS
    
    Closes: https://bugs.gentoo.org/919874
    Signed-off-by: Z. Liu <zhixu.liu@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/40129
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/ucspi-tcp/files/0.88-protype-alloc.patch  | 34 ++++++++++++++++
 sys-apps/ucspi-tcp/metadata.xml                    |  9 ++++-
 ...p-0.88-r19.ebuild => ucspi-tcp-0.88-r20.ebuild} | 47 +++++++++++++---------
 3 files changed, 69 insertions(+), 21 deletions(-)
Comment 13 Zhixu Liu 2025-03-31 04:14:31 UTC
*** Bug 952908 has been marked as a duplicate of this bug. ***