Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 919772 - net-p2p/bitcoin-core-26.0: when compiling with USE="-daemon" the build breaks
Summary: net-p2p/bitcoin-core-26.0: when compiling with USE="-daemon" the build breaks
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-12-12 16:47 UTC by Herbert Wantesh
Modified: 2023-12-13 07:47 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
this patch fixes the build (compile_fix.patch,577 bytes, patch)
2023-12-12 17:04 UTC, Herbert Wantesh
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Herbert Wantesh 2023-12-12 16:47:29 UTC
when compiling net-p2p/bitcoin-core-26.0 with USE="-daemon" the build breaks

Reproducible: Always

Actual Results:  
/tmp/emerge/portage/net-p2p/bitcoin-core-26.0/work/bitcoin-26.0/src/bitcoind not found or not executable.
 * ERROR: net-p2p/bitcoin-core-26.0::gentoo failed (compile phase):
 *   (no error message)
 * 
 * Call stack:
 *     ebuild.sh, line 136:  Called src_compile
 *   environment, line 3627:  Called die
 * The specific snippet of code:
 *       tc-is-cross-compiler || TOPDIR="${S}" bash contrib/devtools/gen-bitcoin-conf.sh || die;
 * 
 * If you need support, post the output of `emerge --info '=net-p2p/bitcoin-core-26.0::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=net-p2p/bitcoin-core-26.0::gentoo'`.
 * The complete build log is located at '/tmp/portage/net-p2p:bitcoin-core-26.0:20231212-151603.log'.
 * For convenience, a symlink to the build log is located at '/tmp/emerge/portage/net-p2p/bitcoin-core-26.0/temp/build.log'.
 * The ebuild environment file is located at '/tmp/emerge/portage/net-p2p/bitcoin-core-26.0/temp/environment'.
 * Working directory: '/tmp/emerge/portage/net-p2p/bitcoin-core-26.0/work/bitcoin-26.0'
 * S: '/tmp/emerge/portage/net-p2p/bitcoin-core-26.0/work/bitcoin-26.0'

>>> Failed to emerge net-p2p/bitcoin-core-26.0, Log file:


Expected Results:  
the package compiles without error
Comment 1 Alfred Wingate 2023-12-12 16:59:15 UTC
Please include build.log and emerge --info
Comment 2 Herbert Wantesh 2023-12-12 17:04:27 UTC
Created attachment 878943 [details, diff]
this patch fixes the build
Comment 3 Herbert Wantesh 2023-12-12 17:06:41 UTC
the ebuild calls - bash contrib/devtools/gen-bitcoin-conf.sh

which checks if bitcoind exists, without daemon, bitcoind isn't build

code snippet from contrib/devtools/gen-bitcoin-conf.sh:

[ ! -x "$BITCOIND" ] && echo "$BITCOIND not found or not executable." && exit 1
Comment 4 Matt Whitlock 2023-12-12 21:33:51 UTC
https://github.com/gentoo/gentoo/pull/34255
Comment 5 Larry the Git Cow gentoo-dev 2023-12-13 07:47:13 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=05a44653f0cb459b22349e4b15c447ac70bf09be

commit 05a44653f0cb459b22349e4b15c447ac70bf09be
Author:     Matt Whitlock <gentoo@mattwhitlock.name>
AuthorDate: 2023-12-12 21:25:56 +0000
Commit:     Florian Schmaus <flow@gentoo.org>
CommitDate: 2023-12-13 07:46:39 +0000

    net-p2p/bitcoin-core: fix build failure when USE="-daemon"
    
    Regenerating the example bitcoin.conf doesn't work when we didn't build
    bitcoind.
    
    No revbump required since it was not possible to complete a build in the
    affected configurations.
    
    Closes: https://bugs.gentoo.org/919772
    Signed-off-by: Matt Whitlock <gentoo@mattwhitlock.name>
    Closes: https://github.com/gentoo/gentoo/pull/34255
    Signed-off-by: Florian Schmaus <flow@gentoo.org>

 net-p2p/bitcoin-core/bitcoin-core-26.0.ebuild | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)