Compilation of =sci-libs/kineto-0.4.0_p20231208 fails with FAILED: CMakeFiles/kineto_base.dir/src/DaemonConfigLoader.cpp.o /opt/gentoo/usr/bin/x86_64-pc-linux-gnu-g++ -I/tmp/portage/sci-libs/kineto-0.4.0_p20231031/work/kineto-a30ca3f9509c2cfd28561abbca51328f0bdf9014/libkineto/include -I/tmp/portage/sci-libs/kineto-0.4.0_p20231031/work/kineto-a30ca3f9509c2cfd28561abbca51328f0bdf9014/libkineto/src -I/usr/include/dynolog -I/usr/include/dynolog/src/ipcfabric -I/extras/CUPTI/include -I/include -I/include/roctracer -march=znver2 -O2 -pipe -std=c++17 -DKINETO_NAMESPACE=libkineto -fPIC -DFMT_HEADER_ONLY -DENABLE_IPC_FABRIC -std=c++17 -MD -MT CMakeFiles/kineto_base.dir/src/DaemonConfigLoader.cpp.o -MF CMakeFiles/kineto_base.dir/src/DaemonConfigLoader.cpp.o.d -o CMakeFiles/kineto_base.dir/src/DaemonConfigLoader.cpp.o -c /tmp/portage/sci-libs/kineto-0.4.0_p20231031/work/kineto-a30ca3f9509c2cfd28561abbca51328f0bdf9014/libkineto/src/DaemonConfigLoader.cpp In file included from /tmp/portage/sci-libs/kineto-0.4.0_p20231031/work/kineto-a30ca3f9509c2cfd28561abbca51328f0bdf9014/libkineto/src/DaemonConfigLoader.cpp:16: /tmp/portage/sci-libs/kineto-0.4.0_p20231031/work/kineto-a30ca3f9509c2cfd28561abbca51328f0bdf9014/libkineto/src/IpcFabricConfigClient.h:21:10: fatal error: FabricManager.h: No such file or directory 21 | #include "FabricManager.h" | ^~~~~~~~~~~~~~~~~ compilation terminated. Reproducible: Always
Created attachment 878604 [details] emerge --info
Created attachment 878605 [details] build.log
Confirm that 0.4.0 can build without this issue on the same system.
Tried bumping to the lastest https://github.com/pytorch/kineto/commit/fea669c33474eefb93a4954cd1875203282fb382, does not resolve the issue
Here it is in this location: /usr/include/dynolog/src/ipcfabric/FabricManager.h from dev-libs/dynolog
(In reply to Tupone Alfredo from comment #5) > Here it is in this location: > > /usr/include/dynolog/src/ipcfabric/FabricManager.h > from > dev-libs/dynolog So that means it's a prefix specific bug, my dev-libs/dynolog provides /opt/gentoo/usr/include/dynolog/src/ipcfabric/FabricManager.h but in build.ninja there's `-I/usr/include/dynolog/src/ipcfabric` (and also there are many other -I flags not properly prefixified)
(In reply to Yiyang Wu from comment #6) > (In reply to Tupone Alfredo from comment #5) > > Here it is in this location: > > > > /usr/include/dynolog/src/ipcfabric/FabricManager.h > > from > > dev-libs/dynolog > > So that means it's a prefix specific bug, my dev-libs/dynolog provides > > /opt/gentoo/usr/include/dynolog/src/ipcfabric/FabricManager.h > > but in build.ninja there's `-I/usr/include/dynolog/src/ipcfabric` (and also > there are many other -I flags not properly prefixified) do you know how to fix it?
(In reply to Tupone Alfredo from comment #7) > (In reply to Yiyang Wu from comment #6) > > (In reply to Tupone Alfredo from comment #5) > > > Here it is in this location: > > > > > > /usr/include/dynolog/src/ipcfabric/FabricManager.h > > > from > > > dev-libs/dynolog > > > > So that means it's a prefix specific bug, my dev-libs/dynolog provides > > > > /opt/gentoo/usr/include/dynolog/src/ipcfabric/FabricManager.h > > > > but in build.ninja there's `-I/usr/include/dynolog/src/ipcfabric` (and also > > there are many other -I flags not properly prefixified) > > do you know how to fix it? Let me have a try
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=837259803593f16223ba81a222b8b7d160362367 commit 837259803593f16223ba81a222b8b7d160362367 Author: Yiyang Wu <xgreenlandforwyy@gmail.com> AuthorDate: 2023-12-11 07:03:29 +0000 Commit: Alfredo Tupone <tupone@gentoo.org> CommitDate: 2023-12-11 07:42:53 +0000 sci-libs/kineto: prefixify absolute paths Closes: https://bugs.gentoo.org/919678 Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com> Closes: https://github.com/gentoo/gentoo/pull/34230 Signed-off-by: Alfredo Tupone <tupone@gentoo.org> sci-libs/kineto/files/kineto-0.4.0_p20231031-gentoo.patch | 4 ++-- sci-libs/kineto/kineto-0.4.0_p20231031.ebuild | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-)
