Bug 919424 – net-misc/asterisk ~sparc keyword request

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description 2857 2023-12-08 03:12:08 UTC]

Latest net-misc/asterisk successfully compiles and runs on sparc, but misses the keyword.

First, I've tried to crosscompile it via crossdev and it failed with configure error: "C compiler cannot create executables". I don't know how crosscompiling works for other arches, so this failure may or may not be unique to sparc.

Nevertheless it compiled successfully and runs on a real hardware.

I've copied following ebuilds and just added "sparc" to KEYWORDS variable, no other changes have been made:

net-libs/libsrtp-2.4.2
net-libs/pjproject-2.13.1
net-misc/asterisk-20.3.1
net-misc/asterisk-base-2
net-misc/asterisk-core-sounds-1.6.1-r1
net-misc/asterisk-extra-sounds-1.5.2
net-misc/asterisk-moh-opsound-2.03-r1

I decided to include pjproject to the list as well since Gentoo has a separate ebuild for it and Asterisk bundles it anyway.

[Comment 1 2857 2023-12-08 03:13:08 UTC]

Created attachment 878187 [details]
emerge --info

[Comment 2 2857 2023-12-08 03:15:24 UTC]

Another argument: source search confirms it has been running on Solaris/Sparc since ~2003 so some basic architecture handling should be in place.

[Comment 3 Alfred Wingate 2023-12-09 00:09:13 UTC]

https://wiki.gentoo.org/wiki/Knowledge_Base:Missing_keywords_and_keyword_requests#Fixing_it_for_everybody

In future follow this template for a keyword request.


To get a valid package list use nattka like below.

nattka make-package-list net-misc/asterisk -a sparc

[addCollapseLink(4, 1, 'Toggle comment display'); Comment 4 NATTkA bot 2023-12-09 00:16:11 UTC Comment hidden (obsolete)]

Unable to check for sanity:

> package masked: net-libs/libsrtp-2.4.2, by keywords: -sparc

[Comment 5 Jaco Kroon 2024-01-05 05:58:45 UTC]

srtp? ( net-libs/libsrtp:0 )

Mask the srtp USE flag for sparc?

I note libsrtp is -sparc, not merely unspecified - so I'm assuming libsrtp WILL NOT compile/work on sparc.  This comes from before migration to git, so might be worth a re-test?

[Comment 6 Sam James 2024-01-05 07:53:25 UTC]

I'd say just mask it for now given there's enough other stuff to do in the list.

[Comment 7 Larry the Git Cow 2024-01-09 07:22:37 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0f32d69f9b90c271a24ec15ceab57f84e4898f53

commit 0f32d69f9b90c271a24ec15ceab57f84e4898f53
Author:     Jaco Kroon <[e-mail]>
AuthorDate: 2024-01-09 06:50:27 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-01-09 07:22:22 +0000

    net-misc/asterisk: mask USE=srtp for sparc.
    
    Bug: https://bugs.gentoo.org/919424
    Signed-off-by: Jaco Kroon <[e-mail]>
    Closes: https://github.com/gentoo/gentoo/pull/34718
    Signed-off-by: Sam James <[e-mail]>

 profiles/arch/sparc/package.use.mask | 4 ++++
 1 file changed, 4 insertions(+)

[Comment 8 Jaco Kroon 2024-01-09 09:53:06 UTC]

resetting sanity check so that nattka will recheck.

[addCollapseLink(9, 1, 'Toggle comment display'); Comment 9 NATTkA bot 2024-01-09 09:56:17 UTC Comment hidden (obsolete)]

Unable to check for sanity:

> package masked: net-libs/libsrtp-2.4.2, by keywords: -sparc

[addCollapseLink(10, 1, 'Toggle comment display'); Comment 10 NATTkA bot 2024-01-09 11:05:02 UTC Comment hidden (obsolete)]

Sanity check failed:

> net-libs/pjproject-2.13.1
>   depend ~sparc stable profile default/linux/sparc/17.0 (8 total)
>     >=net-libs/libsrtp-2.3.0:=
>   rdepend ~sparc stable profile default/linux/sparc/17.0 (8 total)
>     >=net-libs/libsrtp-2.3.0:=

[Comment 11 2857 2024-01-10 14:07:24 UTC]

Hi Jaco, Sam,

libsrtp indeed compiles (works as well, I guess?) on sparc:
matoro-sparcdev / # emerge --search net-libs/libsrtp
  
[ Results for search key : net-libs/libsrtp ]
Searching...

*  net-libs/libsrtp
      Latest version available: 2.4.2
      Latest version installed: 2.4.2
      Size of files: 617 KiB
      Homepage:      https://github.com/cisco/libsrtp
      Description:   Open-source implementation of the Secure Real-time Transport Protocol (SRTP)
      License:       BSD

[ Applications found : 3 ]

matoro-sparcdev / # uname -a
Linux matoro-sparcdev 6.7.0-gentoo-sparc64 #1 SMP Tue Jan  9 00:04:31 EST 2024 sparc64 sun4v UltraSparc T4 (Niagara4) GNU/Linux

Although despite I've specified USE="test" for it, it seems that tests are skipped:
...
>>> Source compiled.
>>> Test phase [not enabled]: net-libs/libsrtp-2.4.2

Trivial code search indicates they've been testing it on Solaris and NetBSD before:
https://github.com/search?q=repo%3Acisco%2Flibsrtp+sparc&type=code

I do understand it's probably too many moving parts by now, but as you've noticed pjproject unconditionally depends on libsrtp: https://gitweb.gentoo.org/repo/gentoo.git/tree/net-libs/pjproject/pjproject-2.13.1.ebuild#n25

[Comment 12 Sam James 2024-01-10 14:08:05 UTC]

Tests are controlled by FEATURES=test, not USE.

[Comment 13 Jaco Kroon 2024-01-10 14:14:19 UTC]

Sam,

I suggest we merge the PR and keyword as is, then in a separate PR re-keyword libsrtp and unmask the USE flag?

[Comment 14 Sam James 2024-01-10 14:28:10 UTC]

ack will handle when home later today

[Comment 15 Larry the Git Cow 2024-01-10 15:50:41 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=df890705fe818409c024387376e289ead06077f8

commit df890705fe818409c024387376e289ead06077f8
Author:     Jaco Kroon <[e-mail]>
AuthorDate: 2024-01-09 11:56:02 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-01-10 15:49:55 +0000

    net-libs/pjproject: bump to 2.13.1-r1 to add IUSE=srtp
    
    Bump to make linking in libsrtp optional so we can keyword asterisk for
    sparc.
    
    There are no known project in gentoo other than asterisk, which don't
    care for pjproject having (or not having) srtp.  Thus in order to enable
    pjproject to be used on sparc we need to be able to not depend on libsrtp.
    
    Bug: https://bugs.gentoo.org/919424
    Signed-off-by: Jaco Kroon <[e-mail]>
    Closes: https://github.com/gentoo/gentoo/pull/34719
    Signed-off-by: Sam James <[e-mail]>

 .../files/pjproject-2.13.1-r1-config_site.h        |  86 +++++++++++++
 net-libs/pjproject/metadata.xml                    |   1 +
 net-libs/pjproject/pjproject-2.13.1-r1.ebuild      | 142 +++++++++++++++++++++
 profiles/arch/sparc/package.use.mask               |   4 +-
 4 files changed, 232 insertions(+), 1 deletion(-)

[Comment 16 NATTkA bot 2024-01-10 15:52:23 UTC]

All sanity-check issues have been resolved

[Comment 17 Arthur Zamarin 2024-01-12 08:30:20 UTC]

sparc done

all arches done