Bug 919201 – media-libs/tg_owt-0_pre20230921 doesn't compile with dev-cpp/abseil-cpp-20230802 and CXFLAGS="-fno-delete-null-pointer-checks": error: ‘(((const char*)(& webrtc::RtpExtension::kTimestampOffsetUri)) != 0)’ is not a constant expression

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Aleksey 2023-12-04 19:25:55 UTC]

media-libs/tg_owt-0_pre20230921 requires dev-cpp/abseil-cpp from keyword amd64 and isn't compiling with it from ~amd64

[Comment 1 Alfred Wingate 2023-12-04 19:42:56 UTC]

Please always include the full build.log (compressed if necessary) and emerge --info.

[Comment 2 Aleksey 2023-12-04 20:22:38 UTC]

Created attachment 877210 [details]
The issue

[Comment 3 Aleksey 2023-12-04 20:24:31 UTC]

Created attachment 877211 [details]
emerge --info

[Comment 4 Aleksey 2023-12-04 20:25:50 UTC]

To be clear - i don't need a solution. It's a request to fix tg_owt BDEPS

[Comment 5 Alfred Wingate 2023-12-04 22:15:41 UTC]

[1064/1369] /usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -DABSL_ALLOCATOR_NOTHROW=1 -DBWE_TEST_LOGGING_COMPILE_TIME_ENABLE=0 -DHAVE_NETINET_IN_H -DHAVE_SCTP -DHAVE_WEBRTC_VIDEO -DNO_MAIN_THREAD_WRAPPING -DRTC_DISABLE_TRACE_EVENTS -DRTC_ENABLE_VP9 -DWEBRTC_APM_DEBUG_DUMP=0 -DWEBRTC_DUMMY_AUDIO_BUILD -DWEBRTC_ENABLE_PROTOBUF=0 -DWEBRTC_HAVE_DCSCTP -DWEBRTC_HAVE_SCTP -DWEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE -DWEBRTC_LIBRARY_IMPL -DWEBRTC_LINUX -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=1 -DWEBRTC_OPUS_SUPPORT_120MS_PTIME=1 -DWEBRTC_OPUS_VARIABLE_COMPLEXITY=0 -DWEBRTC_POSIX -DWEBRTC_USE_BUILTIN_ISAC_FLOAT -DWEBRTC_USE_H264 -DWEBRTC_USE_X11 -Dtg_owt_EXPORTS -I/var/tmp/portage/media-libs/tg_owt-0_pre20230921/work/tg_owt-592b14d13bf9103226e90a83571e24c49f6bfdcd/src -I/var/tmp/portage/media-libs/tg_owt-0_pre20230921/work/tg_owt-592b14d13bf9103226e90a83571e24c49f6bfdcd/src/third_party/pffft/src -I/var/tmp/portage/media-libs/tg_owt-0_pre20230921/work/tg_owt-592b14d13bf9103226e90a83571e24c49f6bfdcd/src/third_party/libsrtp/include -I/var/tmp/portage/media-libs/tg_owt-0_pre20230921/work/tg_owt-592b14d13bf9103226e90a83571e24c49f6bfdcd/src/third_party/libsrtp/crypto/include -I/var/tmp/portage/media-libs/tg_owt-0_pre20230921/work/tg_owt-592b14d13bf9103226e90a83571e24c49f6bfdcd/src/third_party/libsrtp/../libsrtp_config -I/var/tmp/portage/media-libs/tg_owt-0_pre20230921/work/tg_owt-592b14d13bf9103226e90a83571e24c49f6bfdcd/src/third_party/libyuv/include -I/var/tmp/portage/media-libs/tg_owt-0_pre20230921/work/tg_owt-592b14d13bf9103226e90a83571e24c49f6bfdcd_build/cmake/protobuf -isystem /usr/include/opus -isystem /usr/include/openh264  -DNDEBUG -O2 -march=znver1 -pipe -fno-delete-null-pointer-checks -Wno-deprecated -Wno-deprecated-declarations -fno-plt -fstack-protector-strong -fstack-clash-protection -fcf-protection=full -std=gnu++20 -fPIC -Wno-deprecated-declarations -Wno-attributes -Wno-narrowing -Wno-return-type -MD -MT CMakeFiles/tg_owt.dir/src/modules/rtp_rtcp/source/rtp_header_extension_map.cc.o -MF CMakeFiles/tg_owt.dir/src/modules/rtp_rtcp/source/rtp_header_extension_map.cc.o.d -o CMakeFiles/tg_owt.dir/src/modules/rtp_rtcp/source/rtp_header_extension_map.cc.o -c /var/tmp/portage/media-libs/tg_owt-0_pre20230921/work/tg_owt-592b14d13bf9103226e90a83571e24c49f6bfdcd/src/modules/rtp_rtcp/source/rtp_header_extension_map.cc
[31mFAILED: [0mCMakeFiles/tg_owt.dir/src/modules/rtp_rtcp/source/rtp_header_extension_map.cc.o 
/usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -DABSL_ALLOCATOR_NOTHROW=1 -DBWE_TEST_LOGGING_COMPILE_TIME_ENABLE=0 -DHAVE_NETINET_IN_H -DHAVE_SCTP -DHAVE_WEBRTC_VIDEO -DNO_MAIN_THREAD_WRAPPING -DRTC_DISABLE_TRACE_EVENTS -DRTC_ENABLE_VP9 -DWEBRTC_APM_DEBUG_DUMP=0 -DWEBRTC_DUMMY_AUDIO_BUILD -DWEBRTC_ENABLE_PROTOBUF=0 -DWEBRTC_HAVE_DCSCTP -DWEBRTC_HAVE_SCTP -DWEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE -DWEBRTC_LIBRARY_IMPL -DWEBRTC_LINUX -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=1 -DWEBRTC_OPUS_SUPPORT_120MS_PTIME=1 -DWEBRTC_OPUS_VARIABLE_COMPLEXITY=0 -DWEBRTC_POSIX -DWEBRTC_USE_BUILTIN_ISAC_FLOAT -DWEBRTC_USE_H264 -DWEBRTC_USE_X11 -Dtg_owt_EXPORTS -I/var/tmp/portage/media-libs/tg_owt-0_pre20230921/work/tg_owt-592b14d13bf9103226e90a83571e24c49f6bfdcd/src -I/var/tmp/portage/media-libs/tg_owt-0_pre20230921/work/tg_owt-592b14d13bf9103226e90a83571e24c49f6bfdcd/src/third_party/pffft/src -I/var/tmp/portage/media-libs/tg_owt-0_pre20230921/work/tg_owt-592b14d13bf9103226e90a83571e24c49f6bfdcd/src/third_party/libsrtp/include -I/var/tmp/portage/media-libs/tg_owt-0_pre20230921/work/tg_owt-592b14d13bf9103226e90a83571e24c49f6bfdcd/src/third_party/libsrtp/crypto/include -I/var/tmp/portage/media-libs/tg_owt-0_pre20230921/work/tg_owt-592b14d13bf9103226e90a83571e24c49f6bfdcd/src/third_party/libsrtp/../libsrtp_config -I/var/tmp/portage/media-libs/tg_owt-0_pre20230921/work/tg_owt-592b14d13bf9103226e90a83571e24c49f6bfdcd/src/third_party/libyuv/include -I/var/tmp/portage/media-libs/tg_owt-0_pre20230921/work/tg_owt-592b14d13bf9103226e90a83571e24c49f6bfdcd_build/cmake/protobuf -isystem /usr/include/opus -isystem /usr/include/openh264  -DNDEBUG -O2 -march=znver1 -pipe -fno-delete-null-pointer-checks -Wno-deprecated -Wno-deprecated-declarations -fno-plt -fstack-protector-strong -fstack-clash-protection -fcf-protection=full -std=gnu++20 -fPIC -Wno-deprecated-declarations -Wno-attributes -Wno-narrowing -Wno-return-type -MD -MT CMakeFiles/tg_owt.dir/src/modules/rtp_rtcp/source/rtp_header_extension_map.cc.o -MF CMakeFiles/tg_owt.dir/src/modules/rtp_rtcp/source/rtp_header_extension_map.cc.o.d -o CMakeFiles/tg_owt.dir/src/modules/rtp_rtcp/source/rtp_header_extension_map.cc.o -c /var/tmp/portage/media-libs/tg_owt-0_pre20230921/work/tg_owt-592b14d13bf9103226e90a83571e24c49f6bfdcd/src/modules/rtp_rtcp/source/rtp_header_extension_map.cc
In file included from /var/tmp/portage/media-libs/tg_owt-0_pre20230921/work/tg_owt-592b14d13bf9103226e90a83571e24c49f6bfdcd/src/modules/rtp_rtcp/include/rtp_header_extension_map.h:18,
                 from /var/tmp/portage/media-libs/tg_owt-0_pre20230921/work/tg_owt-592b14d13bf9103226e90a83571e24c49f6bfdcd/src/modules/rtp_rtcp/source/rtp_header_extension_map.cc:11:
/var/tmp/portage/media-libs/tg_owt-0_pre20230921/work/tg_owt-592b14d13bf9103226e90a83571e24c49f6bfdcd/src/modules/rtp_rtcp/source/rtp_header_extension_map.cc:36:44:   in ‘constexpr’ expansion of ‘webrtc::{anonymous}::CreateExtensionInfo<webrtc::TransmissionOffset>()’
/var/tmp/portage/media-libs/tg_owt-0_pre20230921/work/tg_owt-592b14d13bf9103226e90a83571e24c49f6bfdcd/src/modules/rtp_rtcp/source/rtp_header_extension_map.cc:32:41:   in ‘constexpr’ expansion of ‘webrtc::TransmissionOffset::Uri()’
/var/tmp/portage/media-libs/tg_owt-0_pre20230921/work/tg_owt-592b14d13bf9103226e90a83571e24c49f6bfdcd/src/modules/rtp_rtcp/source/rtp_header_extension_map.cc:32:43:   in ‘constexpr’ expansion of ‘absl::lts_20230802::string_view(((const char*)(& webrtc::RtpExtension::kTimestampOffsetUri)))’
/usr/include/absl/strings/string_view.h:198:28: error: ‘(((const char*)(& webrtc::RtpExtension::kTimestampOffsetUri)) != 0)’ is not a constant expression
  198 |       : ptr_(str), length_(str ? StrlenInternal(str) : 0) {}
      |                            ^~~

[Comment 6 Alfred Wingate 2023-12-04 23:22:55 UTC]

I could only replicate this by adding -fno-delete-null-pointer-checks to my C{,XX}FLAGS.

[Comment 7 Esteve Varela Colominas 2023-12-05 08:04:25 UTC]

Thanks for reporting and diagnosing this issue.
Is that flag some GCC13 thing that will be enabled by default in the long run or can I ignore this and tell user to not mess with flags as bad (or add filter-flags to ebuild)

[Comment 8 Sam James 2023-12-05 08:06:25 UTC]

(In reply to Esteve Varela Colominas from comment #7)
> Thanks for reporting and diagnosing this issue.
> Is that flag some GCC13 thing that will be enabled by default in the long
> run or can I ignore this and tell user to not mess with flags as bad (or add
> filter-flags to ebuild)

There is no plan to enable this by default and further, I don't see it ever happening, given it's a workaround for UB.

You should feel free to filter it.

[Comment 9 Larry the Git Cow 2023-12-11 13:25:49 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3006f656e6dd79d109533b220b224ad7de22a818

commit 3006f656e6dd79d109533b220b224ad7de22a818
Author:     Esteve Varela Colominas <[e-mail]>
AuthorDate: 2023-12-10 22:24:04 +0000
Commit:     Yixun Lan <[e-mail]>
CommitDate: 2023-12-11 13:23:25 +0000

    net-im/telegram-desktop: Backport fixes
    
    Closes: https://bugs.gentoo.org/917409
    Closes: https://bugs.gentoo.org/919201
    Thanks-to: Pacho Ramos <[e-mail]>
    Thanks-to: Aleksey <[e-mail]>
    Signed-off-by: Esteve Varela Colominas <[e-mail]>
    Signed-off-by: Yixun Lan <[e-mail]>

 ...egram-desktop-4.11.7.ebuild => telegram-desktop-4.11.7-r1.ebuild} | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e772fbf176397c21026223ba002f8d7e5aab6518

commit e772fbf176397c21026223ba002f8d7e5aab6518
Author:     Esteve Varela Colominas <[e-mail]>
AuthorDate: 2023-12-10 22:21:02 +0000
Commit:     Yixun Lan <[e-mail]>
CommitDate: 2023-12-11 13:23:22 +0000

    net-im/telegram-desktop: Bump to 4.12.2
    
    Bug: https://bugs.gentoo.org/917409
    Bug: https://bugs.gentoo.org/919201
    Thanks-to: Pacho Ramos <[e-mail]>
    Thanks-to: Aleksey <[e-mail]>
    Signed-off-by: Esteve Varela Colominas <[e-mail]>
    Signed-off-by: Yixun Lan <[e-mail]>

 net-im/telegram-desktop/Manifest                   |   1 +
 .../telegram-desktop-4.12.2.ebuild                 | 227 +++++++++++++++++++++
 2 files changed, 228 insertions(+)