Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 919099 - [patch] x11-misc/safeeyes-2.1.6-r1 does not support python 3.12
Summary: [patch] x11-misc/safeeyes-2.1.6-r1 does not support python 3.12
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Sebastian Pipping
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-03 04:34 UTC by Anton Bolshakov
Modified: 2023-12-04 01:58 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Bolshakov 2023-12-03 04:34:58 UTC
Traceback (most recent call last):
  File "/usr/lib/python-exec/python3.12/safeeyes", line 5, in <module>
    from safeeyes.__main__ import main
  File "/usr/lib/python3.12/site-packages/safeeyes/__main__.py", line 32, in <module>
    from safeeyes import utility
  File "/usr/lib/python3.12/site-packages/safeeyes/utility.py", line 24, in <module>
    import imp
ModuleNotFoundError: No module named 'imp'


There is an official patch, but no new version released yet:
https://github.com/slgobinath/SafeEyes/commit/777d48603d4fb9a8baa118314a9073f6f580bd1c
Comment 1 Sebastian Pipping gentoo-dev 2023-12-03 14:58:00 UTC
Thanks for the report!

I have just asked for a new release upstream at https://github.com/slgobinath/SafeEyes/issues/552 . If in a few days we have no release, I will cherry-pick the upstream fix to the package. If that sounds unacceptable, please report back and we can discuss alternatives like cherry-picking the upstream fix.
Comment 2 Alfred Wingate 2023-12-03 15:04:34 UTC
Well in the mean time x11-misc/safeeyes shouldn't have python3_12 target enabled.
Comment 3 Sebastian Pipping gentoo-dev 2023-12-03 15:15:22 UTC
Are you saying that waiting for a few days for a reply from upstream is not acceptable?
Comment 4 Alfred Wingate 2023-12-03 15:32:41 UTC
Well currently x11-misc/safeeyes with python3_12 is broken, it shouldn't been pushed with it enabled in the first place.

Waiting for upstream is fine, but in the meantime python3_12 should be disabled while waiting for a response.
Comment 5 Larry the Git Cow gentoo-dev 2023-12-03 15:58:18 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0af193126b0874fc5e7f76addb8fb81b7bfcd0e7

commit 0af193126b0874fc5e7f76addb8fb81b7bfcd0e7
Author:     Sebastian Pipping <sping@gentoo.org>
AuthorDate: 2023-12-03 15:42:01 +0000
Commit:     Sebastian Pipping <sping@gentoo.org>
CommitDate: 2023-12-03 15:57:30 +0000

    x11-misc/safeeyes: Fix support for Python 3.12
    
    Closes: https://bugs.gentoo.org/919099
    Signed-off-by: Sebastian Pipping <sping@gentoo.org>

 x11-misc/safeeyes/files/safeeyes-2.1.6-py312.patch | 34 ++++++++++++++++
 x11-misc/safeeyes/safeeyes-2.1.6-r1.ebuild         |  2 +-
 x11-misc/safeeyes/safeeyes-2.1.6-r2.ebuild         | 46 ++++++++++++++++++++++
 3 files changed, 81 insertions(+), 1 deletion(-)
Comment 6 Anton Bolshakov 2023-12-04 01:58:26 UTC
(In reply to Alfred Wingate from comment #4)
> Well currently x11-misc/safeeyes with python3_12 is broken, it shouldn't
> been pushed with it enabled in the first place.
> 
> Waiting for upstream is fine, but in the meantime python3_12 should be
> disabled while waiting for a response.

disabling python3_12 would be going backwards. There is an official patch and next version will have it included. So you either wait for a release or push a patch (very minor and simple) earlier.


Thanks for the -r2, it works!