Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 918855 - games-emulation/mgba-0.10.2 add USE for BUILD_ROM_TEST
Summary: games-emulation/mgba-0.10.2 add USE for BUILD_ROM_TEST
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-29 16:18 UTC by Esteve Varela Colominas
Modified: 2023-11-29 17:56 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Esteve Varela Colominas 2023-11-29 16:18:44 UTC
Enabling the -DBUILD_ROM_TEST=ON build flag, causes the "mgba-rom-test" binary to be installed.
I think this tool is useful for creating tests for homebrew ROMs and the like, and feel that including it in gentoo would be useful.
Comment 1 Ionen Wolkens gentoo-dev 2023-11-29 16:26:26 UTC
Seems to barely add a second to the build time and is small without extra deps, think can just enable it without needing a USE.
Comment 2 Larry the Git Cow gentoo-dev 2023-11-29 16:32:30 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fb8c110bb4507827a283ba682744ea518755a566

commit fb8c110bb4507827a283ba682744ea518755a566
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2023-11-29 16:30:18 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2023-11-29 16:31:59 +0000

    games-emulation/mgba: build the mgba-rom-test tool
    
    Closes: https://bugs.gentoo.org/918855
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 games-emulation/mgba/mgba-0.10.2-r1.ebuild | 109 +++++++++++++++++++++++++++++
 games-emulation/mgba/mgba-9999.ebuild      |   1 +
 2 files changed, 110 insertions(+)
Comment 3 Esteve Varela Colominas 2023-11-29 17:56:56 UTC
oh... I mean that's fine too, it's just disabled by default in the build system and in any other distros, but I agree it's very unintrusive.