Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 918705 - dev-util/pwndbg-20230717: Cannot find Pwndbg virtualenv directory
Summary: dev-util/pwndbg-20230717: Cannot find Pwndbg virtualenv directory
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: mario.haustein
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-11-28 19:33 UTC by Stefan Gloor
Modified: 2023-12-04 08:33 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch which fixes the problem for me by removing the .venv check. (0001-Use-global-python-packages-instead-of-virtualenv.patch,1.69 KB, patch)
2023-11-28 19:33 UTC, Stefan Gloor
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Gloor 2023-11-28 19:33:06 UTC
Created attachment 875874 [details, diff]
Patch which fixes the problem for me by removing the .venv check.

The upstream install script creates a python venv to install packages. As far as I can see, the ebuild does not rely on this and instead installs the required python packages as dependencies.

However, the script ignores the global packages and instead looks for .venv, resulting in "Cannot find Pwndbg virtualenv directory: /usr/share/pwndbg/.venv: please re-run setup.sh".


If I apply the patch below, the problem does not occur.
Comment 1 Larry the Git Cow gentoo-dev 2023-12-04 08:33:11 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=512978d6c38fca7d041a445c9d301847871958f0

commit 512978d6c38fca7d041a445c9d301847871958f0
Author:     Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
AuthorDate: 2023-11-29 19:42:17 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-12-04 08:33:01 +0000

    dev-util/pwndbg: use upstreams way to disable private venv
    
    Closes: https://bugs.gentoo.org/918705
    Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-util/pwndbg/pwndbg-99999999.ebuild | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=646a889ecd781bdaf6176d15f7bb56171bb70389

commit 646a889ecd781bdaf6176d15f7bb56171bb70389
Author:     Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
AuthorDate: 2023-11-29 18:14:41 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-12-04 08:33:01 +0000

    dev-util/pwndbg: prevent pwndbg from setting up its own venv
    
    Bug: https://bugs.gentoo.org/918705
    Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
    Thanks-to: Stefan Gloor <code@stefan-gloor.ch>
    Signed-off-by: Sam James <sam@gentoo.org>

 .../pwndbg/files/pwndbg-20230717-no-venv.patch     | 46 ++++++++++++++++++++++
 ...g-20230717.ebuild => pwndbg-20230717-r1.ebuild} |  4 ++
 2 files changed, 50 insertions(+)