Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 918585 - gui-wm/hyprland: consider removing git from dependencies
Summary: gui-wm/hyprland: consider removing git from dependencies
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Julien
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks:
 
Reported: 2023-11-26 01:08 UTC by Andrew Brouwers
Modified: 2023-11-26 07:49 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild diff (hyprland_build.diff,1.95 KB, patch)
2023-11-26 01:08 UTC, Andrew Brouwers
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Brouwers 2023-11-26 01:08:24 UTC
Created attachment 875669 [details, diff]
ebuild diff

I might be wrong, but I assume the reason for including git in hyprland's build deps is due to the submodules.  I tested embedding them in the src array, and then extracting in src_unpack - at least in my local tests, this worked well!  I was able to build/install/run hyprland without git being installed.
Comment 1 Eli Schwartz 2023-11-26 01:29:29 UTC
This seems fundamentally suspicious that you need to remove the existing submodules. As far as meson is concerned, if the submodule exists in order to be rm -r'ed, then meson won't try to download them again and therefore does not need git.
Comment 2 Andrew Brouwers 2023-11-26 01:52:06 UTC
You might be right - I just removed "git" from deps, with no other changes (ie, no patch), and it worked fine, too :(  Sorry for the noise!
Comment 3 Larry the Git Cow gentoo-dev 2023-11-26 07:49:02 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=aa51076be76820a2e7ef7074c6c0289d8e3b5f87

commit aa51076be76820a2e7ef7074c6c0289d8e3b5f87
Author:     Alfred Wingate <parona@protonmail.com>
AuthorDate: 2023-11-26 02:19:53 +0000
Commit:     Yixun Lan <dlan@gentoo.org>
CommitDate: 2023-11-26 07:45:37 +0000

    gui-wm/hyprland: remove git buildtime dependency
    
    * Hasn't been a strict requirement since
      https://github.com/hyprwm/Hyprland/commit/914851b91aeb450592e2d62749169298ac48fb0c.
    
    Closes: https://bugs.gentoo.org/918585
    Signed-off-by: Alfred Wingate <parona@protonmail.com>
    Signed-off-by: Yixun Lan <dlan@gentoo.org>

 gui-wm/hyprland/hyprland-0.31.0-r1.ebuild | 1 -
 gui-wm/hyprland/hyprland-0.32.3.ebuild    | 1 -
 gui-wm/hyprland/hyprland-9999.ebuild      | 1 -
 3 files changed, 3 deletions(-)