See https://bugzilla.mozilla.org/show_bug.cgi?id=1864083 and https://phabricator.services.mozilla.com/D194080 After applying the patch the build succeeds. Reproducible: Always Actual Results: doesn't build. Expected Results: build.
Please include emerge --info and the build.log (I appreciate the build log may be hard in this instance and I won't insist on you rebuilding w/o patch unless mozilla@ wants it).
(In reply to Sam James from comment #1) > Please include emerge --info and the build.log (I appreciate the build log > may be hard in this instance and I won't insist on you rebuilding w/o patch > unless mozilla@ wants it). ... do include emerge -pvO www-client/firefox if not including the log though.
Created attachment 875288 [details] emerge --info
root ~ # emerge -pvO www-client/firefox These are the packages that would be merged, in order: [ebuild R ~] www-client/firefox-120.0:rapid::gentoo USE="clang dbus gmp-autoupdate jumbo-build lto pulseaudio screencast system-av1 system-harfbuzz system-icu system-jpeg system-libevent system-libvpx system-png system-webp wayland -X -debug -eme-free -geckodriver -hardened -hwaccel -jack -libproxy -openh264 -pgo (-selinux) -sndio (-system-python-libs) -telemetry (-valgrind) -wifi" L10N="-ach -af -an -ar -ast -az -be -bg -bn -br -bs -ca -ca-valencia -cak -cs -cy -da -de -dsb -el -en-CA -en-GB -eo -es-AR -es-CL -es-ES -es-MX -et -eu -fa -ff -fi -fr -fur -fy -ga -gd -gl -gn -gu -he -hi -hr -hsb -hu -hy -ia -id -is -it -ja -ka -kab -kk -km -kn -ko -lij -lt -lv -mk -mr -ms -my -nb -ne -nl -nn -oc -pa -pl -pt-BR -pt-PT -rm -ro -ru -sc -sco -si -sk -sl -son -sq -sr -sv -szl -ta -te -th -tl -tr -trs -uk -ur -uz -vi -xh -zh-CN -zh-TW" 0 KiB
>I appreciate the build log may be hard in this instance and I won't insist on you rebuilding w/o patch unless mozilla@ wants it I skipped build.log because it fails exactly like in the linked upstream issue and applying the patch from upstream fixes it. It's just the flags were not passed because upstream were not passing them...
(In reply to Kirill Chibisov from comment #5) The configuration needed to hit it matters is why I asked, but emerge -pvO answers this hopefully.
same problem for me --- 58:08.41 /var/tmp/portage-ondisk/portage/www-client/firefox-120.0/work/firefox-120.0/too lkit/components/protobuf/src/google/protobuf/generated_message_tctable_lite.cc:1631:10: warning : 'return' will never be executed [-Wunreachable-code-return] 58:08.42 return Error(PROTOBUF_TC_PARAM_PASS); 58:08.42 ^~~~~ 58:09.14 In file included from /var/tmp/portage-ondisk/portage/www-client/firefox-120.0/ work/firefox-120.0/toolkit/components/remote/nsDBusRemoteClient.cpp:9: 58:09.14 In file included from /var/tmp/portage-ondisk/portage/www-client/firefox-120.0/wor k/firefox-120.0/toolkit/components/remote/nsDBusRemoteClient.h:15: 58:09.14 In file included from /var/tmp/portage-ondisk/portage/www-client/firefox-120.0/wor k/firefox_build/dist/include/mozilla/DBusHelpers.h:10: 58:09.15 /var/tmp/portage-ondisk/portage/www-client/firefox-120.0/work/firefox_build/dis t/system_wrappers/dbus/dbus.h:3:15: fatal error: 'dbus/dbus.h' file not found 58:09.15 #include_next <dbus/dbus.h> 58:09.15 ^~~~~~~~~~~~~ 58:09.82 1 error generated. 58:09.84 gmake[4]: *** [/var/tmp/portage-ondisk/portage/www-client/firefox-120.0/work/firef ox-120.0/config/rules.mk:690: nsDBusRemoteClient.o] Error 1 58:09.85 gmake[4]: Leaving directory '/var/tmp/portage-ondisk/portage/www-client/firefox-12 0.0/work/firefox_build/toolkit/components/remote' 58:09.86 gmake[3]: *** [/var/tmp/portage-ondisk/portage/www-client/firefox-120.0/work/firef ox-120.0/config/recurse.mk:72: toolkit/components/remote/target-objects] Error 2 58:09.87 gmake[3]: *** Waiting for unfinished jobs.... ---
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=23ac0821e332f2b9e042bfe8742c9a1cff1d483d commit 23ac0821e332f2b9e042bfe8742c9a1cff1d483d Author: Joonas Niilola <juippis@gentoo.org> AuthorDate: 2023-11-22 06:13:34 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2023-11-22 06:13:34 +0000 www-client/firefox: add upstream patch to fix missing dbus.h on 120.0 Closes: https://bugs.gentoo.org/917684 Signed-off-by: Joonas Niilola <juippis@gentoo.org> www-client/firefox/Manifest | 1 + www-client/firefox/firefox-120.0.ebuild | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-)
it seems like this is a clang only problem though?
My guess was on the -X.
Some data points for the discussion: A version using "-clang -X wayland dbus" failed for me, just switching to "-dbus" compiled. On another machine, "-clang X -wayland dbus" did compile fine. So the "-X dbus" combo seems to not work, but it's not looking related to the clang build.
