Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 917623 - ninja-utils.eclass: use app-alternatives/ninja
Summary: ninja-utils.eclass: use app-alternatives/ninja
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on: 919969
Blocks: 915318
  Show dependency tree
 
Reported: 2023-11-20 07:05 UTC by Anna Vyalkova
Modified: 2024-01-09 07:55 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anna Vyalkova 2023-11-20 07:05:15 UTC 
There are three options now:

1. ninja (portage-managed symlink)

2. ninja-reference

3. samu
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-11-20 07:09:40 UTC 
That will be done when app-alternatives/ninja is stable.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-11-26 00:24:05 UTC 
(In reply to Sam James from comment #1)
> That will be done when app-alternatives/ninja is stable.

I suppose we may need to do it simultaneously, actually...
Comment 3 Anna Vyalkova 2023-11-26 07:32:59 UTC 
Note that the "CMAKE_MAKE_PROGRAM" variable needs to be also set.
Comment 4 Larry the Git Cow gentoo-dev 2023-12-15 06:52:07 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2fa125d055dcfebe34acf09ea04ff89c42eeb19b

commit 2fa125d055dcfebe34acf09ea04ff89c42eeb19b
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-12-15 06:50:39 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-12-15 06:50:39 +0000

    ninja-utils.eclass: use app-alternatives/ninja
    
    Needed now that it's stable.
    
    Bug: https://bugs.gentoo.org/919969
    Closes: https://bugs.gentoo.org/917623
    Signed-off-by: Sam James <sam@gentoo.org>

 eclass/ninja-utils.eclass | 21 +++++++++------------
 1 file changed, 9 insertions(+), 12 deletions(-)
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-12-15 06:52:35 UTC 
(In reply to Anna Vyalkova from comment #3)
> Note that the "CMAKE_MAKE_PROGRAM" variable needs to be also set.

Can you file a separate bug for that please? I've done the bare minimum here to avoid confusion without the alternative.
Comment 6 Anna Vyalkova 2024-01-08 21:47:55 UTC 
The current implementation doesn't allow to force "ninja-reference"
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-01-09 07:55:21 UTC 
(In reply to Anna Vyalkova from comment #6)
> The current implementation doesn't allow to force "ninja-reference"

New bug please, for each issue.