Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 917493 - media-video/pipewire: rekeywording
Summary: media-video/pipewire: rekeywording
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Keywording (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Sam James
URL:
Whiteboard:
Keywords: CC-ARCHES
Depends on:
Blocks:
 
Reported: 2023-11-17 12:10 UTC by Sam James
Modified: 2023-12-01 03:39 UTC (History)
2 users (show)

See Also:
Package list:
media-video/pipewire media-libs/webrtc-audio-processing
Runtime testing required: ---
nattka: sanity-check+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-11-17 12:10:05 UTC
I was convinced we had a bug for this...
Comment 1 matoro archtester 2023-11-27 15:30:20 UTC
FAILED: webrtc/system_wrappers/libsystem_wrappers.a.p/source_cpu_features.cc.o 
powerpc64-unknown-linux-gnu-g++ -Iwebrtc/system_wrappers/libsystem_wrappers.a.p -Iwebrtc/system_wrappers -I../webrtc-audio-processing-1.3/webrtc/system_wrappers -Iwebrtc -I../webrtc-audio-processing-1.3/webrtc -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=c++17 -O2 -pipe -fPIC -DNOMINMAX -pthread -DWEBRTC_LIBRARY_IMPL -DWEBRTC_ENABLE_SYMBOL_EXPORT -DNDEBUG -DWEBRTC_POSIX -DWEBRTC_LINUX -DWEBRTC_THREAD_RR -MD -MQ webrtc/system_wrappers/libsystem_wrappers.a.p/source_cpu_features.cc.o -MF webrtc/system_wrappers/libsystem_wrappers.a.p/source_cpu_features.cc.o.d -o webrtc/system_wrappers/libsystem_wrappers.a.p/source_cpu_features.cc.o -c ../webrtc-audio-processing-1.3/webrtc/system_wrappers/source/cpu_features.cc
In file included from ../webrtc-audio-processing-1.3/webrtc/system_wrappers/source/cpu_features.cc:13:
../webrtc-audio-processing-1.3/webrtc/rtc_base/system/arch.h:61:2: error: #error Please add support for your architecture in rtc_base/system/arch.h
   61 | #error Please add support for your architecture in rtc_base/system/arch.h
      |  ^~~~~
../webrtc-audio-processing-1.3/webrtc/rtc_base/system/arch.h:65:2: error: #error Define either WEBRTC_ARCH_LITTLE_ENDIAN or WEBRTC_ARCH_BIG_ENDIAN
   65 | #error Define either WEBRTC_ARCH_LITTLE_ENDIAN or WEBRTC_ARCH_BIG_ENDIAN
      |  ^~~~~
Comment 3 matoro archtester 2023-11-28 00:03:47 UTC
Also needs webrtc-audio-processing-0.3-big-endian-support.patch to be rebased
Comment 4 matoro archtester 2023-11-28 00:06:36 UTC
Actually this seems like a way better approach than more stupid arch-specific detection:  https://sources.debian.org/src/webrtc-audio-processing/0.3-1/debian/patches/Add-generic-byte-order-and-pointer-size-detection.patch/
Comment 6 Larry the Git Cow gentoo-dev 2023-11-29 04:23:26 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=66881e4894e324fa5578f823ca6f3990e1e356ee

commit 66881e4894e324fa5578f823ca6f3990e1e356ee
Author:     Matoro Mahri <matoro_gentoo@matoro.tk>
AuthorDate: 2023-11-28 18:45:59 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-11-29 04:20:40 +0000

    media-libs/webrtc-audio-processing: import debian patches for alt-arches
    
    [sam: Revbump as the patches aren't purely ifdef'd, just in case of differences
    on platforms it already built on.]
    
    See: https://sources.debian.org/src/webrtc-audio-processing/1.0-0.2/debian/patches/Add-generic-byte-order-and-pointer-size-detection.patch/
    See: https://sources.debian.org/src/webrtc-audio-processing/1.0-0.2/debian/patches/big-endian-support.patch/
    Bug: https://bugs.gentoo.org/917493
    Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk>
    Signed-off-by: Sam James <sam@gentoo.org>

 ...ric-byte-order-and-pointer-size-detection.patch |  32 ++
 ...c-audio-processing-1.3-big-endian-support.patch | 324 +++++++++++++++++++++
 .../webrtc-audio-processing-1.3-r2.ebuild          |  33 +++
 3 files changed, 389 insertions(+)
Comment 7 matoro archtester 2023-12-01 03:39:21 UTC
ppc64 done

all arches done